| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
to free them just before exiting.
|
|
|
|
|
| |
used and just freed at the end. The idea might have been to be able
to free all the strings, but what's the point to free just before exiting?
|
|
|
|
| |
so don't return anything.
|
|
|
|
|
| |
open directories so there is no need to remove it from there. This fixes
a core dump introduced by removing the run-time check from Lst_Remove.
|
|
|
|
| |
somewhat so that we can remove a local variable.
|
|
|
|
| |
Simplify the algorithm now that circular lists are gone.
|
|
|
|
| |
that the list's first element is not on the list.
|
|
|
|
| |
it. Remove stuff that was needed for circular lists.
|
|
|
|
| |
in the caller instead.
|
|
|
|
|
|
|
|
| |
only in a couple of places and all of them except for one were easily
converted to use Lst_First/Lst_Succ. The one place is compatibility
mode in job.c where the it was used to advance to the next command on
each invocation of JobStart. For this case add a pointer to the node to
hold the currently executed command.
|
|
|
|
|
|
|
|
| |
requires to make a copy of the filename in ReadMakefile and to duplicate
two small functions in suff.c. This hopefully will go away when everything
is constified.
Submitted by: Max Okumoto <okumoto@ucsd.edu> (partly)
|
|
|
|
| |
Submitted by: Max Okumoto <okumoto@ucsd.edu>
|
|
|
|
|
|
|
| |
purpose and explicitely free the input string in the one place that was
calling str_concat with that flag.
Submitted by: Max Okumoto <okumoto@ucsd.edu>
|
|
|
|
|
|
| |
the structs itself not of pointers to them. This will simplify constification.
Checked by: diff on the object files
|
|
|
|
|
|
|
|
| |
resulting executable.
Checked by: diff on original and new objects
Submitted by: Max Okumoto <okumoto@ucsd.edu>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Submitted by: ru
|
|
|
|
| |
to change to size_t in a couple of other places too.
|
| |
|
|
|
|
| |
Submitted by: johan
|
|
|
|
| |
should be Byte (as the numerous casts to Byte in the function calls show).
|
|
|
|
| |
Checked with: diff on object file.
|
|
|
|
| |
Reviewed by: ru
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the .SHELL target. Formerly it used to select the shell with the
longest common trailing substring, so that bash would select sh, but pocsh
would select csh. Now an exact match is required so that specifying bash
without also giving a path and the other keywords will give an error.
PR:
Submitted by:
Reviewed by: ru
Approved by:
Obtained from:
MFC after:
|
|
|
|
| |
macro for this; reorder an if.
|
|
|
|
|
|
| |
pointer constant as NULL.
Checked by: diff -r on the object files before and after
|
|
|
|
|
|
|
|
| |
and the sizeof operator, missing empty lines, void casts, extra empty lines.
Checked by: diff on make *.o lst.lib/*.o
Submitted by: Max Okumoto <okumoto@soe.ucsd.edu> (partly)
|
|
|
|
|
|
|
| |
versions of the structure definition for this: one with const char
pointers, because otherwise gcc won't let us initialize the fields with
constant strings, and one without the const, because we need to work
with the structure.
|
|
|
|
|
|
| |
the semantic of Lst_Datum which formerly returned NULL when the argument
node was NULL. There was only one place in the source that relied on this
so change that place.
|
|
|
|
|
|
|
|
| |
the length of happens to be larger than MAXPATHLEN.
PR: bin/74368
Submitted by: Max Okumoto <okumoto@ucsd.edu>
Obtained from: DragonFlyBSD
|
|
|
|
|
|
| |
to the list functions for better readability.
Submitted by: Max Okumoto <okumoto@ucsd.edu>
|
|
|
|
|
|
|
| |
rid of a lot of uneccesary casts and temporary variables that have just
obfuscated the code. This also let's us implement a couple of the one-
liner list functions as macros (the first one is Lst_IsEmpty) and
simplify life once we start to throw consts on the code.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
uses the brk_string function to parse the line. That function uses static
storage for both the expanded string and the returned argv[] vector.
The JobParseShell function simply stored away pointers into this static
storage. On the next use of something like ${FOO:O} this storage would
get overwritten with fatal results.
This also allows us to make the shells[] array const bringing us one step
further in making make WARNS=4 ready.
|
|
|
|
|
|
| |
function, and moves the related defines out of the middle of code body.
Submitted by: Max Okumoto less-than okumoto at ucsd dot edu greater-than
|
|
|
|
| |
JobMatchShell returns NULL when no shell name matches since revision 1.51.
|
|
|
|
|
| |
Our make has been build with POSIX enabled from the first day
and the ifdef'ed out code served no purpose.
|
|
|
|
|
|
| |
a -j arg which does the same thing), remove the MAKE_JOBS_FIFO
environment variable so we decouple any resulting sub-makes from
the token pool.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of submakes spawned during processing.
We create a fifo and stuff one character into it for each job we are
allowed to run. The name of the fifo is passed to child processes
in the MAKE_JOBS_FIFO environment variable.
A make which finds this variable on startup will open the fifo and
only spawn jobs when it managed to read a token from the fifo.
When the job completes a token is writen back to the fifo.
Slave make processes get one token for free: the one their parent
make got in order to run them. This makes the make processes
themselves invisible in the process counts.
The net effect is that "make -j 12 -s buildworld" will start at
most 12 jobs at the same time, instead of as previously up to
65 jobs would get started.
|
|
|
|
|
|
|
|
|
|
| |
from the beginning). Make used to handle all its interrupt-time stuff
directly from the signal handler, including calls to printf, accessing
global data and so on. This is of course wrong and could provoke a core
dump when interrupting make. Just set a flag in the signal handler and
do everything else from the main thread.
PR: bin/29103
|