| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
and tabs. This is still not correct for command line variable values
ending in a backslash because this would require a larger effort.
Document this limitation in the BUGS section of the man page. The
quoting is mostly compatible with that of gmake and smake.
Tested by: Max Okumoto and Joerg Sonnenberger from DragonFly BSD
Reviewed by: ru (man page, partly)
|
|
|
|
|
| |
just before exiting (especially given the number of memory leaks) -
it just costs time.
|
|
|
|
|
|
|
|
| |
now that their size is only two pointers. This eliminates a lot of calls
to Lst_Init and from there to malloc together with many calls to
Lst_Destroy (in places where the list is obviously empty). This also
reduces the chance to leave a list uninitilized so we can remove more
NULL pointer checks and probably eliminates a couple of memory leaks.
|
|
|
|
|
| |
used and just freed at the end. The idea might have been to be able
to free all the strings, but what's the point to free just before exiting?
|
|
|
|
|
|
| |
the structs itself not of pointers to them. This will simplify constification.
Checked by: diff on the object files
|
| |
|
|
|
|
| |
to change to size_t in a couple of other places too.
|
|
|
|
|
|
| |
pointer constant as NULL.
Checked by: diff -r on the object files before and after
|
|
|
|
|
|
|
|
| |
and the sizeof operator, missing empty lines, void casts, extra empty lines.
Checked by: diff on make *.o lst.lib/*.o
Submitted by: Max Okumoto <okumoto@soe.ucsd.edu> (partly)
|
|
|
|
|
|
| |
to the list functions for better readability.
Submitted by: Max Okumoto <okumoto@ucsd.edu>
|
|
|
|
|
| |
Our make has been build with POSIX enabled from the first day
and the ifdef'ed out code served no purpose.
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the PR failed, because the line skipping function is actually called
from two places in the code to do quite different things (this should
be two functions probably): in a false .if to skip to the next line
beginning with a dot and to collect .for loops. In the seconds case we
should not skip comments, because they are actually harder to handle than
we need for the .if case and should defer this to the main code.
PR: bin/25627
Submitted by: Seth Kingsley (original patch)
|
|
|
|
|
|
|
|
|
|
| |
slightly different from the patch in the PR. The problem is, that
make handles .if clauses inside false .if clauses simply by
counting them - it doesn't put them onto the conditional stack, nor even
parses them so we need an extra line number stack for these ifs.
PR: bin/61257
Submitted by: Mikhail Teterin <mi@aldan.algebra.com>
|
|
|
|
|
|
|
|
|
|
|
| |
tracking.
Use
make -V .MAKEFILE_LIST | tr \ \\n | awk '$0==".." {l--; next} {l++; printf "%*s%s\n", l, " ", $0}'
to print a tree of all included makefiles.
Approved by: joerg
MFC after: 1 week
|
|
|
|
| |
Submitted by: Cyrille Lefevre
|
|
|
|
|
|
|
|
|
|
|
| |
the .for loop:
- Replaced four global variables in parse.c with one.
- Made Parse_FromString() accept the "lineno" as an argument.
- Fixed line numbering when there are escaped newlines in the
body of the .for loop.
Adopted from: NetBSD
|
|
|
|
|
|
| |
the variable name to undef).
Submitted by: Cyrille Lefevre
|
|
|
|
| |
Submitted by: Cyrille Lefevre
|
|
|
|
|
|
| |
"greedy" with respect to finding the dependency operators.
Approved by: re
|
|
|
|
|
|
|
| |
PR: 32759
Submitted by: Mark Valentine
Reviewed by: Matthew Emmerton" <matt@gsicomp.on.ca>
MFC after: 15 days
|
|
|
|
|
|
|
|
|
|
|
| |
documentation already adequatedly existed in the description in most
cases. Where it did not, it was added. If no documentation existed
beforehand, then none was added. Some unused dummies for use in the
traversal functions were marked as __unused during the conversion.
Occasionally, local style fixes were applied to lines already being
modified or influenced.
Now make(1) should always build with WARNS=3.
|
|
|
|
| |
happily fit into headers.
|
|
|
|
| |
compatible mode, as far as I know, since we use it...
|
|
|
|
|
|
|
|
|
|
|
| |
renaming variables to not shadow libc functions or greater scope locals. Kinda
makes one wonder if the extern ones weren't meant in some of these places :)
The only thing I'd still like to do WRT this is possibly combine rstat and
status in compat.c -- that should be fine, as I do not think the codepaths
will want both around at once.
Sponsored by: Bright Path Solutions
|
|
|
|
|
|
|
|
|
|
| |
in compat.c which doesn't even have preprocessor-conditional-hidden support
code, and add a debugging statement where we might end up with a nil list
somehow, but where I doubt it.
First confirmed userland kill for Flexelint.
Sponsored by: Bright Path Solutions
|
|
|
|
|
| |
Spotted by: SPARC64 make WARNS=3
Sponsored by: Rachel Hestilow <rachel@jerkcity.com>
|
|
|
|
|
| |
is merely printf() but to stderr. This takes care of the caveat which lead
to the use of a vararg macro -- getting everything to stderr.
|
|
|
|
|
|
|
|
|
| |
variable length arguments to a macro. Bump version as this makes DEBUG
statements *always* go to stderr rather than sometimes stdout. There are
a few stragglers, which I will take care of as soon as I can. Mostly these
relate to the need-for-death-of some of the remote job code.
Nearby stylistic nits and XXX added/fixed where appropriate.
|
| |
|
|
|
|
|
|
| |
PR: bin/6612
Obtained from: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
|
| |
as wide-reaching nor intensive as NetBSD's similar, but the warning uses the
same text.
Inspired by: NetBSD
|
|
|
|
|
|
|
| |
an example Makefile I was showing someone just last night to report a variable
as being recursive.
Obtained from: NetBSD
|
|
|
|
| |
Obtained from: NetBSD
|
|
|
|
| |
Obtained from: NetBSD
|
|
|
|
| |
passing an argument to isspace(3).
|
| |
|
| |
|
| |
|
|
|
|
|
| |
o remove badly bit-rotted compat file that likely won't work on the systems
it purports to support.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
src/sys/modules/if_ef and possibly other things. I tested the build with
a make based on rev. 1.26, and it worked fine. Since I'm not particularly
inclined to figure out what's going on with this, it's probably prudent
just to back it out for now.
Found by: jkh
Suggested by: jhay
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.endif statements but can't be placed in .elif. Basically, the problem
was that ParseSkipLine() didn't handle comments the same way that
ParseReadLine() did, and thus you had errors with comments that are on a
conditional line (i.e. "^.") rather than a non-conditional line.
MFC candidate for 4.3-STABLE and 3.5-STABLE.
PR: 25627
Bug found by: jhs
Fix submitted by: Seth Kingsley <sethk@osd.bsdi.com> (thanks!!)
|
| |
|
|
|
|
|
|
| |
rip out ClientData/Address pointers and use standard types.
Obtained from: OpenBSD
|
|
|
|
|
|
| |
of NIL, NILLST, NILLGNODE, etc. with NULL.
Obtained from: OpenBSD
|
| |
|
| |
|
|
|
|
| |
Obtained from: OpenBSD, sometimes indirected from NetBSD; myself
|
|
|
|
| |
Spotted by: John W. DeBoskey <jwd@unx.sas.com>
|
|
|
|
|
| |
PR: 6720
Submitted by: Niall Smart <njs3@doc.ic.ac.uk>
|