| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
While I'm here fix a couple of whitespaces.
Requested by: netchild
MFC after: 1 day
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(atkbd(4)) and PS/2 mouse (psm(4)) are used together.
Turns out that atkbd(4) check_char() method may return "true" while
read_char() method returns NOKEY. When this happens kbdmux(4) was
simply stuck in the dead loop. Avoid dead loop in kbdmux(4) by breaking
out of the loop if read_char() method returns NOKEY.
It almost seems like a bug in atkkbd(4), atkbd_check_char() calls
kbdc_data_ready(), and, the later will return "true" if there are
pending data in either kbd or aux queue. However, because both aux
and kbd are on the same controller, I'm not sure if this is a bug
or feature.
Tested by: markus
MFC after: 1 day
|
|
|
|
|
|
|
|
| |
bulk transfers to have a chance of working.
PR: usb/93720
Submitted by: Nate Nielsen
MFC after: 1 week
|
|
|
|
| |
Lock the channel so master/slave setups wont trash during reinit.
|
| |
|
|
|
|
|
|
| |
Make my portions of the license clearer.
Thank Chris Ellsworth for his support in getting a bunch of this done.
|
|
|
|
|
| |
Reviewed by: avatar
MFC after: 2 weeks
|
|
|
|
|
|
| |
processors.
Obtained from: Intel Datasheet 302189-008
|
|
|
|
|
|
|
|
|
|
| |
is finished with it; this may only occur when the tx queue is setup as
dba-gated but since the fix is cheap apply it to all queues
while here make the queue depth signed for use in assertions
Reviewed by: apatti
MFC after: 2 weeks
|
|
|
|
|
|
| |
This should fix panic on "kldunload if_vlan" while vlanX are still there.
Reviewed by: glebius
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inside !if defined(KERNBUILDDIR).
Utilize the fact the module will support all frames by default --
it needs no ETHER_* options unless some frames need to be disabled.
Fix the comment respectively.
Don't forget to create fake opt_ef.h if no ETHER_* are set.
MFC after: 3 days
|
| |
|
| |
|
|
|
|
|
| |
or scc(4) to grab the device by default. In fact, we probably shouldn't
even claim the device at all...
|
|
|
|
|
| |
Stop using our local UART_IPEND_* and instead use the global SER_INT_*
as defined in <sys/serial.h>.
|
|
|
|
|
|
|
|
| |
o Add defines for the 5 interrupt sources typical for serial devices.
These defines can be used for more finegrained interrupt handling
between drivers that cooperatively handle multiple serial ports.
o Add defines for the various bitmasks applicable when all information
is passed between drivers as a single integral.
|
|
|
|
| |
style(9): <tab> after #define
|
|
|
|
|
|
| |
Return BUS_PROBE_LOW_PRIORITY for a successful probe. This is in
preparation of the introduction of scc(4), which is going to handle
SCCs in the near future.
|
|
|
|
|
| |
Add CHAN_A & CHAN_B for channel register offsets.
While here, fix a comment.
|
|
|
|
| |
instead define MFILES appropriately for the uart(4) module build.
|
|
|
|
|
|
|
|
|
|
| |
simultaneous open. Both the bug and the patch were verified using the
ANVL test suite.
PR: kern/74935
Submitted by: qingli (before I became committer)
Reviewed by: andre
MFC after: 5 days
|
|
|
|
|
| |
so we dont panic device removal or failure.
Clean up ata_fail_requests to prevent the queue munging to fail.
|
|
|
|
|
|
|
| |
Coverity ID: 822
Found by: Coverity Prevent
Reviewed by: ariff
MFC after: 1 week
|
|
|
|
|
|
| |
callout_drain() logic. We no longer need a separate non-spin mutex to
do sleep/wakeup with, instead we can now just use the one spin mutex to
manage all the callout functionality.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mutex.
- Don't use callout_drain() to stop the toffhandle callout while holding the
fdc mutex (this could deadlock) in functions called from softclock
(callouts aren't allowed to do voluntary sleeps). Instead, use
callout_stop(). Note that since we hold the associated mutex and are now
using callout_init_mtx(), callout_stop() is just as effective as
callout_drain(). (Though callout_drain() is still needed in detach to
make sure softclock isn't contesting on our mutex before we destroy the
mutex.)
- Remove unused callout 'tohandle' from softc.
MFC after: 1 week
|
|
|
|
| |
found by: jhb@
|
|
|
|
|
|
|
| |
Coverity ID: 839
Found by: Coverity Prevent
MFC after: 1 week
Reviewed by: ps, scottl
|
| |
|
|
|
|
|
|
|
| |
2. Fix a bug, if thread got a SIGKILL signal, call sigexit() to kill
its process.
MFC after: 3 days
|
| |
|
|
|
|
|
|
|
| |
is being called. Be sure to grab the ref before we unlock the vnode to
prevent the mount from disappearing.
Tested by: kris
|
|
|
|
|
|
|
|
|
| |
the last reference is dropped. I forgot that vnodes can stick around
for a very long time until processes discover that they are dead. This
means that a vnode reference is not sufficient to keep the mount
referenced and even more code will be required to ref mount points.
Discovered by: kris
|
| |
|
|
|
|
| |
Reviewed by: jhb
|
| |
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
| |
now and msleep blocks threads rather than processes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Reorder the events in exit(2) slightly so that we trigger the S_EXIT
stop event earlier. After we have signalled that, we set P_WEXIT and
then wait for any processes with a hold on the vmspace via PHOLD to
release it. PHOLD now KASSERT()'s that P_WEXIT is clear when it is
invoked, and PRELE now does a wakeup if P_WEXIT is set and p_lock drops
to zero.
- Change proc_rwmem() to require that the processing read from has its
vmspace held via PHOLD by the caller and get rid of all the junk to
screw around with the vmspace reference count as we no longer need it.
- In ptrace() and pseudofs(), treat a process with P_WEXIT set as if it
doesn't exist.
- Only do one PHOLD in kern_ptrace() now, and do it earlier so it covers
FIX_SSTEP() (since on alpha at least this can end up calling proc_rwmem()
to clear an earlier single-step simualted via a breakpoint). We only
do one to avoid races. Also, by making the EINVAL error for unknown
requests be part of the default: case in the switch, the various
switch cases can now just break out to return which removes a _lot_ of
duplicated PRELE and proc unlocks, etc. Also, it fixes at least one bug
where a LWP ptrace command could return EINVAL with the proc lock still
held.
- Changed the locking for ptrace_single_step(), ptrace_set_pc(), and
ptrace_clear_single_step() to always be called with the proc lock
held (it was a mixed bag previously). Alpha and arm have to drop
the lock while the mess around with breakpoints, but other archs
avoid extra lock release/acquires in ptrace(). I did have to fix a
couple of other consumers in kern_kse and a few other places to
hold the proc lock and PHOLD.
Tested by: ps (1 mostly, but some bits of 2-4 as well)
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
| |
interrupt handlers rather than BUS_SETUP_INTR() and BUS_TEARDOWN_INTR().
Uses of the BUS_*() versions in the implementation of foo_intr methods
in bus drivers were not changed. Mostly this just means that some
drivers might start printing diagnostic messages like [FAST] when
appropriate as well as honoring mpsafenet=0.
- Fix two more of the ppbus drivers' identify routines to function
correctly in the mythical case of a machine with more than one ppbus.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
associated with the passed in pfs_node. If it does return a pointer, it
keeps the process locked. This allows a lot of places that were calling
pfind() again right after pfs_visible() to not have to do that and avoids
races since we don't drop the proc lock just to turn around and lock it
again. This will become more important with future changes to fix races
between procfs/ptrace and exit(2). Also, removed a duplicate pfs_visible()
call in pfs_getextattr().
Reviewed by: des
MFC after: 1 week
|
|
|
|
|
|
|
| |
kthread_exit(). Rather than add the missing PRELE() I chose to just
axe the PHOLD() since it was redundant with the P_SYSTEM flag.
MFC after: 1 week
|
|
|
|
|
|
|
| |
it and remove a PRELE() that didn't have a matching PHOLD(). The calling
code already has a PHOLD anyway.
MFC after: 1 week
|
|
|
|
| |
puc still prints out [FAST] on Peter's box.
|
|
|
|
| |
Submitted by: bde
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
quotactl, statfs, fstatfs, fchdir, chdir, chroot, open, mknod, mkfifo,
link, symlink, undelete, unlink, access, eaccess, stat, lstat, pathconf,
readlink, chflags, lchflags, fchflags, chmod, lchmod, fchmod, chown,
lchown, fchown, utimes, lutimes, futimes, truncate, ftruncate, fsync,
rename, mkdir, rmdir, getdirentries, revoke, lgetfh, getfh, extattrctl,
extattr_set_file, extattr_set_link, extattr_get_file, extattr_get_link,
extattr_delete_file, extattr_delete_link, extattr_list_file, extattr_list_link.
In many cases the pathname and vnode auditing is done within namei lookup
instead of directly in the system call.
Audit the remaining arguments to these system calls:
fstatfs, fchdir, open, mknod, chflags, lchflags, fchflags, chmod, lchmod,
fchmod, chown, lchown, fchown, futimes, ftruncate, fsync, mkdir,
getdirentries.
|
|
|
|
| |
introduced by this change.
|
|
|
|
|
| |
Found and fixed by: Vsevolod Lobko <seva@ip.net.ua>
MFC after: 3 days
|
|
|
|
|
|
|
|
| |
statfs handler in nfs will lock vnodes which may lead to deadlock or
recursion.
Found by: kris
Pointy hat to: me
|
|
|
|
|
|
|
| |
it may not be removed from the freelist.
MFC After: 1 week
Found by: kris
|
|
|
|
|
|
|
|
|
|
|
| |
modules prior to looking up the directory which we will cover to avoid
this problem in mount.
- We must hold the coveredvp locked before we can busy the mountpoint to
prevent a lock order reversal with the vfs_busy() in lookup which holds
the directory lock prior to doing a vfs_busy(). The directory lock is
required to safely clear the v_mountedhere field on the directory.
MFC After: 1 week
|