| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Found by: Coverity Prevent (tm)
CID: 1066
|
|
|
|
|
|
|
| |
an error.
Found by: Coverity Prevent (tm)
CID: 71-78
|
|
|
|
|
|
|
| |
adaptive mutexes. Let witness(4) calm down and bring proper types of those
locks to the lock order database.
Glanced at by: rwatson
|
| |
|
|
|
|
|
|
|
| |
of the mii phy is intended for this chip.
Found by: Coverity Prevent (tm)
CID: 43
|
|
|
|
|
|
|
|
| |
usbd_endpoint_count(), the failure case is handled implicit in the
following code.
Found by: Coverity Prevent (tm)
CID: 56
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vfs_flags field is used for VFCF_* flags which are given at file system
driver creation time (via VFS_SET(9)) macro.
What this code did was bascially this:
If file system registers itself with VFCF_UNICODE flag (stores file names
as Unicode), it will gain MNT_SOFTDEP flag (UFS soft-updates).
If file system registers itself with VFCF_LOOPBACK flag (aliases some other
mounted FS), it will gain MNT_SUIDDIR flag (special handling of SUID on
dirs).
The latter will be quite dangerous, but those flags are reset later in
vfs_domount().
MFC after: 1 month
|
|
|
|
| |
to get definition of curthread, required by <sys/sx.h>.
|
|
|
|
| |
SMP and is now in the global NOTES.
|
|
|
|
| |
is held.
|
|
|
|
| |
Fix a white-space nit while I'm here.
|
|
|
|
|
|
|
|
| |
read the same register back. It can cause hangs or machine
checks in certain cases. One particular case is with bge(4)
when a reset is initiated for the controller.
MFC after: 1 month
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file system code (mostly *_reclaim()) which look like this:
VOP_LOCK(vp);
/* examine vp */
VOP_UNLOCK(vp);
vdrop(vp);
This can now be rewritten to:
VOP_LOCK(vp);
/* examine vp */
vdropl(vp); /* will unlock vp */
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
obtaining and releasing shared and exclusive locks. The algorithms for
manipulating the lock cookie are very similar to that rwlocks. This patch
also adds support for exclusive locks using the same algorithm as mutexes.
A new sx_init_flags() function has been added so that optional flags can be
specified to alter a given locks behavior. The flags include SX_DUPOK,
SX_NOWITNESS, SX_NOPROFILE, and SX_QUITE which are all identical in nature
to the similar flags for mutexes.
Adaptive spinning on select locks may be enabled by enabling the
ADAPTIVE_SX kernel option. Only locks initialized with the SX_ADAPTIVESPIN
flag via sx_init_flags() will adaptively spin.
The common cases for sx_slock(), sx_sunlock(), sx_xlock(), and sx_xunlock()
are now performed inline in non-debug kernels. As a result, <sys/sx.h> now
requires <sys/lock.h> to be included prior to <sys/sx.h>.
The new kernel option SX_NOINLINE can be used to disable the aforementioned
inlining in non-debug kernels.
The size of struct sx has changed, so the kernel ABI is probably greatly
disturbed.
MFC after: 1 month
Submitted by: attilio
Tested by: kris, pjd
|
| |
|
| |
|
|
|
|
|
|
|
| |
PCI_BAR_(IO|MEM)() that return true if the passed in value from a BAR
is for an IO or memory BAR, respectively.
Reviewed by: imp
|
| |
|
|
|
|
| |
- Add a few progif constants as well.
|
|
|
|
|
|
|
|
| |
explicitly test and panic. This should not ever happen, but if it does,
this is a preferred failure mode to a NULL pointer dereference in kernel.
Coverity CID: 1716
Found with: Coverity Prevent(tm)
|
|
|
|
|
|
|
| |
change should bring no performance decrease, as it did not in my tests.
Reviewed by: julian, glebius
Approved by: cognet (mentor)
|
|
|
|
|
|
|
|
| |
checked by intend.
Found by: Coverity Prevent (tm)
CID: 55
Reviewed by: ariff
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incorrect, non-bundlable fragmentation.
- Added min residual to better control split points for
both how big a msg must be as well as how much needs
to be left over.
- With our new algo in place, we need to implicitly
set "end of msg" on the sp-> structure otherwise we
end up with "hung" associations.
- Room reserved up front in IP header by pushing IP
header to back of mbuf.
- Fix so FR's peg count of retransmissions needed.
- Fix so an unlucky chunk that never gets across
will kill the assoc via the kill timer and send an
abort too.
- Fix bug in sctp_input which can result in a crash.
- Do not strip off IP options anymore.
- Clean up sctp_calculate_rto().
- Get rid of unused sysctl.
- Fixed so we discard all M-Cast
- Fixed so port check done AFTER checksum
- Fixed bug in fragmentation code that prevented
us from fragmenting a small complete message when
we needed to.
- Window probes were not marked back to unsent and
flight adjusted when a sack came in with no
window change or accepting of the probe data.
We now fix this with having a mark on the net and
the chunk so we can clear it out when the sack arrives
forcing it to retran just like it was "new" this
improves the handling of window probes, which were
dropped by the receiver.
- Tighten AUTH protocol error checks during INIT/INIT-ACK exchange
|
|
|
|
|
| |
Pointed out by: bde
Reviewed by: bde
|
|
|
|
|
|
|
|
| |
fix more style(9) nits.
Pointed out by: bde
Discussed with: kib
Reviewd by: bde
|
|
|
|
| |
MFC after: 3 days
|
|
|
|
| |
Pointed out by: bde[1]
|
|
|
|
| |
Pointed out by: bde
|
|
|
|
|
| |
- Move UGAR() macro up to the comment that describes it.
- Fix a couple of typos.
|
|
|
|
|
| |
barrier here as the earlier rw_rlock() already contained one.
- Comment fix.
|
|
|
|
|
|
|
| |
We can now use LOCK_CLASS() as a stronger check in lockmgr_chain() as a
result. This required putting back lk_flags as lockmgr's use of flags
conflicted with other flags in lo_flags otherwise.
- Tweak 'show lock' output for lockmgr to match sx, rw, and mtx.
|
|
|
|
|
|
|
|
|
| |
seminfo because kernel_sysctlbyname() is slow. There is no dependency
problem since linux module depends on both sysvmsg and sysvsem and linprocfs
depends on it in turn.
Pointed out by: des
Reviewed by: des
|
| |
|
|
|
|
|
|
|
| |
Dont "return" in linux_clone() after we forked the new process in a case
of problems. Move the copyout of p2->p_pid outside the emul_lock coverage.
Submitted by: Roman Divacky
|
|
|
|
|
|
|
| |
- In gctl_get_geom(), don't issue error when we were not
provided with an parameter, like gctl_get_provider() did.
Reviewed by: pjd
|
| |
|
|
|
|
|
|
|
| |
This should fix the problem that the first bus reset is
sometimes ignored because of FWBUSRESET status.
MFC after: 3 days
|
|
|
|
|
|
|
|
| |
for doing this job. This change will make it easy to migrate from using
spinning locks to adaptive ones.
Reviewed by: glebius, julian
Approved by: cognet (mentor)
|
|
|
|
|
|
|
| |
Initial patch was submitted by kib and additional work was done
by Divacky Roman.
Tested by: emulation
|
| |
|
|
|
|
|
|
| |
Initial version was submitted by Divacky Roman and mostly rewritten by me.
Tested by: emulation
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Join the IPv4 all-hosts multicast group 224.0.0.1 once only;
that is, when an IPv4 address is first configured on an interface.
* Do not join it for subsequent IPv4 addresses as this violates IGMP.
* Be sure to leave the group when all IPv4 addresses have been removed
from the interface.
* Add two DIAGNOSTIC printfs related to the issue.
Further care and attention is needed in this area; it is suggested that
netinet's attachment to the ifnet structure be compartmentalized and
non-implicit.
Bug found by: andre
MFC after: 1 month
|
| |
|
|
|
|
|
|
|
|
| |
it with vm_map_remove, which not only embeds additional check, but also
takes care of locking.
Reviewed by: alc
Approved by: alc, cognet (mentor)
|
|
|
|
|
|
|
|
|
| |
defined with VFS_LOCK_GIANT(NULL) call.
This shall fix softdep operation when mpsafe_vfs = 0.
Reported and tested by: kris
Submitted by: tegge
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
VFS_ASSERT_GIANT. Stop using reserved namespace.
Reported and tested by: kris
Reviewed and enhanced by: tegge
MFC after: 1 week
|
|
|
|
| |
Pointed out by: marcel, Joseph Terner
|
|
|
|
|
| |
Submitted by: Roman Divacky (rdivacky@)
MFC after: 2 weeks
|