summaryrefslogtreecommitdiffstats
path: root/sys/rpc/rpcclnt.c
Commit message (Collapse)AuthorAgeFilesLines
* Check for a NULL return from rpcclnt_buildheader- it can fail ifmjacob2007-06-161-0/+13
| | | | | | | | | the passed in auth_type is unacceptable to rpcauth_buildheader- this avoids a null pointer panic. Clean up allocations if this happens. This also quiets a gcc 4.2 complaint about ussing mheadend without it being initialized. Reviewed by: alfred
* Replace GIANT_REQUIRED's present for socket locking with NET_LOCK_GIANT().rwatson2007-03-251-9/+20
| | | | | | | If/when someone does the necessary MPSAFEty locking for the NFSv4 client, the socket code is generally MPSAFE now. Spotted by: kris
* Fix up some cut-n-paste damage and some out-of-date comments.rees2006-01-201-29/+34
| | | | | | No code changes. Submitted by: cel@citi.umich.edu
* Use thread0 instead of user's thread for sobind.rees2006-01-201-1/+5
| | | | | | | | | This fixes reconnect after, for example, tcp idle disconnection. Previously this would fail if a normal user tried to bind to a privileged port. Submitted by: cel@citi.umich.edu MFC after: 1 week
* Fix -Wundef.ru2005-12-041-3/+3
|
* Add GIANT_REQUIRED and WITNESS sleep warnings to uprintf() and tprintf(),rwatson2005-09-191-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | as they both interact with the tty code (!MPSAFE) and may sleep if the tty buffer is full (per comment). Modify all consumers of uprintf() and tprintf() to hold Giant around calls into these functions. In most cases, this means adding an acquisition of Giant immediately around the function. In some cases (nfs_timer()), it means acquiring Giant higher up in the callout. With these changes, UFS no longer panics on SMP when either blocks are exhausted or inodes are exhausted under load due to races in the tty code when running without Giant. NB: Some reduction in calls to uprintf() in the svr4 code is probably desirable. NB: In the case of nfs_timer(), calling uprintf() while holding a mutex, or even in a callout at all, is a bad idea, and will generate warnings and potential upset. This needs to be fixed, but was a problem before this change. NB: uprintf()/tprintf() sleeping is generally a bad ideas, as is having non-MPSAFE tty code. MFC after: 1 week
* - Don't call rpcclnt_realign() if we don't have any mbufs to realign.das2005-03-191-15/+12
| | | | | | | - Remove a bogus and unneeded null pointer check. Found by: Coverity Prevent analysis tool Approved by: alfred
* /* -> /*- for license, minor formatting changesimp2005-01-071-2/+2
|
* fix array index out of bounds in rpc->rc_srtt[], rpc->rc_sdrtt[]rees2004-07-151-3/+3
| | | | | Noticed by: tedu Approved by: alfred
* Constify 'rpcclnt_backoff'.rwatson2004-07-121-1/+1
|
* Reset callout if in nfs_timeout and rpcclnt_timeout functions. Timerkan2004-03-281-0/+2
| | | | | | | | | are supposed to continue firing as long as there is work to do, not stop after the first invocation. This is damage control after a patch that has been committed prematurely. Tested by: kris
* only do nfs rpc callouts if there is work to do.rees2004-03-251-5/+6
| | | | | Submitted by: kan Approved by: alfred
* Convert from timeout to callout API.kan2004-03-071-4/+4
|
* Don't panic because of RPC proto mismatches. Whitespace cleanup.alfred2004-01-171-35/+37
| | | | Submitted by: Jim Rees <rees@umich.edu>
* Prevent a panic when mounting a v2/v3 only server with mount_nfs4.alfred2004-01-131-0/+2
| | | | | Submitted by: Jim Rees <rees@umich.edu> Reported/testing: Florian C. Smeets <flo@kasimir.com>
* Fix a panic when attempting a v4 op against a v3/v2-only server.alfred2004-01-101-10/+12
| | | | | | | It happens because rpcclnt_request is incorrectly returning 0 in the case of an rpc mismatch or auth error. Submitted by: Jim Rees <rees@umich.edu>
* Use %zu to printf a size_t instead of an int cast.alfred2003-11-151-3/+3
| | | | Requested by: jmallett, wollman
* Fix compilation warnings on sparc.alfred2003-11-151-2/+2
| | | | Cast sizeof to int for printing with %d.
* University of Michigan's Citi NFSv4 kernel client code.alfred2003-11-141-0/+2083
Submitted by: Jim Rees <rees@umich.edu>
OpenPOWER on IntegriCloud