| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
o Call kdb_enter() instead of Debugger().
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Avoid an additional lock acquire/release when leaving xl_intr(), by
changing xl_start*() to xl_start*_locked(), and calling the appropriate
routine by chip revision (as the DMA descriptors are different).
- Simplify the appropriate routines now that they are called with the
lock held.
This should save a significant amount of CPU cycles spent on servicing
each interrupt for both UP and SMP whilst remaining MPSAFE.
Tested by: rwatson
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add *_locked() entry points as needed to avoid unnecessary lock thrashing.
- Use these entry points wisely.
- Only acquire the lock once when servicing an interrupt.
- Check 'suspended' on interrupt to avoid racing detach.
- Correct a mis-spelled comment.
- Don't take the lock in vr_reset() to avoid lock thrashing in attach.
- Comment this.
Reviewed by: -net (silence)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Avoid unnecessary re-acquisition elsewhere by adding *_locked()
entry points as needed.
- Correct locking for the DEVICE_POLLING case.
- Hold the driver lock for the entire duration of interrupt servicing,
to avoid unneeded, expensive re-acquisition; use *_locked() entry
points as needed.
Reviewed by: -net (silence)
|
| |
|
| |
|
| |
|
|
|
|
|
| |
- Space before bracketized non-void function returns.
- Space before condition for conditional blocks.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Eliminate the use of a recursive mutex.
- Mark the driver INTR_MPSAFE.
This work is incomplete and will be refined in a future commit.
- Most notably, _locked() variants of entry points need to be introduced.
- The mii upcall/downcall may still be racy.
- Add a stubbed-out guard against racing rl_detach() for the time being.
Tested on: UP, debug.mpsafenet && !debug.mpsafenet
Reviewed by: silence on -net
|
|
|
|
|
|
|
|
| |
Use C99 types. Use ANSI function definitions. Sort prototypes.
Split long lines correctly. Punctuate/wordsmith comments.
Use device_printf()/if_printf() where possible.
Reviewed by: -net (silence)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Eliminate the use of a recursive mutex.
- Mark the driver as INTR_MPSAFE.
- Split the default media choice code out into xl_choose_media() to
avoid making poor assumptions about the state of the lock during attach.
- The miibus upcall/downcall paths may still be racy.
Change to commented-out locking assertions there for now.
- Tested with nfsclient, routed, ssh, ntp, dhclient and quagga bgpd.
- This needs SMP test coverage. I do not have such resources.
Tested on: UP, !debug.mpsafenet && debug.mpsafenet
Hardware: 3C905B-TX (0x905510b7)
|
|
|
|
|
|
|
| |
- Use device_printf() during device probe/attach.
- Move if_xname initialization to before xl_reset() is called.
- Use if_printf() at all other times after struct ifnet has been
initialized.
|
|
|
|
|
| |
Remove unnecessary return keywords.
Other minor stylistic changes.
|
| |
|
| |
|
|
|
|
| |
in <sys/cdefs.h> for compilers without support for inline.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove recursive locking situations. Remove the MTX_RECURSE bit.
- Take the lock for any routine which is not called from within if_vr.c
itself; this includes entry points called by newbus, ifnet, callout,
ifmedia, and polling subsystems.
- Remove spl references from the code added to miibus callbacks in rev 1.60.
- Add the INTR_MPSAFE bit.
- Tidy up some assignments; locks are not needed for taking the address
of something at a known offset, for example.
- Tested on the machine this was committed from.
Tested on: UP only, !debug.mpsafenet && debug.mpsafenet
Reviewed by: rwatson
|
|
|
|
| |
- Use C99 types for vr_miibus_readreg().
|
|
|
|
|
|
|
|
|
| |
Put some braces around the busy-wait loop in vr_rxeoc() to make the
no-op semicolon more obvious.
No functional changes.
Running on the machine I am committing from without problems.
Reviewed by: jmallett
|
|
|
|
|
|
|
|
|
|
|
| |
following drivers: bfe(4), em(4), fxp(4), lnc(4), tun(4), de(4) rl(4),
sis(4) and xl(4)
More patches are pending on: http://peoples.freebsd.org/~mlaier/ Please take
a look and tell me if "your" driver is missing, so I can fix this.
Tested-by: many
No-objection: -current, -net
|
|
|
|
|
|
|
| |
the VIA v3 register offsets.
PR: 68545
Submitted by: Ariff Abdullah <skywizard@mybsd.org.my>
|
|
|
|
| |
Submitted by: Marius Strobl
|
|
|
|
|
| |
that are now handled in the pci bus layer. They are no longer
necessary.
|
| |
|
|
|
|
| |
Bump __FreeBSD_version accordingly.
|
| |
|
| |
|
| |
|
|
|
|
| |
one on death-row in <sys/kernel.h>
|
|
|
|
|
|
|
|
| |
Should make no binary difference.
Submitted by: Gleb Smirnoff <glebius@cell.sick.ru>
Reviewed by: Harti Brandt <harti@freebsd.org>
MFC after: 1 week
|
|
|
|
|
|
| |
#ifndef BURN_BRIDGES.
Noticed by: phk
|
|
|
|
|
|
|
| |
true. Otherwise, assertion checks for Giant in the network stack will
fail causing a panic.
Reported by: simon
|
|
|
|
|
|
|
| |
if_capenable unless the interface driver is actually able
to toggle the respective capability on and off.
Reviewed by: ru
|
| |
|
|
|
|
|
|
|
| |
the agp mutex. We do this because vm_page_grab() called with the
VM_ALLOC_RETRY flag can sleep.
Pointed out by: alc
|
|
|
|
|
| |
since it's always acquiring the lock exclusively. This was tested
with X on an SMP box, with and without WITNESS.
|
| |
|
|
|
|
| |
Prompted by: i386/59503
|
|
|
|
|
|
|
|
|
|
|
| |
algorithm, supplied by wpaul himself. The lame one has an origin
that's been called into question, so rather than argue about that (one
could make an excellent fair use argument), replace it with better
code since that's what FreeBSD is about.
Submitted by: wpaul[1], Klaus Klein
[1] Bill called this a silly bikeshed. Maybe his is not incorrect.
|
|
|
|
|
|
|
|
|
|
|
| |
registers, so add a register offset array to the softc. We key off the
device ID to determine which set of register offsets. Currently the 8385
host bridge used on amd64 is the only bridge to use the AGP3_VIA_*
register offsets and all other bridges use the AGP_VIA_* offsets. It is
currently unclear if the AGP3_VIA_* offsets are for VIA bridges that
implement AGP 3.0 bridges or just for amd64 bridges.
Submitted by: Kenneth Culver culverk at sweetdreamsracing dot biz
|
|
|
|
| |
sys/dev/ic and adjusted to work there.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caller to vm_page_grab(). Although this gives VM_ALLOC_ZERO a
different meaning for vm_page_grab() than for vm_page_alloc(), I feel
such change is necessary to accomplish other goals. Specifically, I
want to make the PG_ZERO flag immutable between the time it is
allocated by vm_page_alloc() and freed by vm_page_free() or
vm_page_free_zero() to avoid locking overheads. Once we gave up on
the ability to automatically recognize a zeroed page upon entry to
vm_page_free(), the ability to mutate the PG_ZERO flag became useless.
Instead, I would like to say that "Once a page becomes valid, its
PG_ZERO flag must be ignored."
|
| |
|
| |
|