summaryrefslogtreecommitdiffstats
path: root/sys/netinet/sctp_indata.c
Commit message (Collapse)AuthorAgeFilesLines
* Address issues found by clang. While there, fix also some styletuexen2011-12-271-21/+11
| | | | | | issues. MFC after: 3 months.
* Fix unused parameter warnings.tuexen2011-12-171-36/+19
| | | | | | While there, fix some whitespace issues. MFC after: 3 months.
* The result of a joint work between rrs@ and myself at the IETF:tuexen2011-08-031-48/+127
| | | | | | | | | | | * Decouple the path supervision using a separate HB timer per path. * Add support for potentially failed state. * Bring back RTO.min to 1 second. * Accept packets on IP-addresses already announced via an ASCONF * While there: do some cleanups. Approved by: re@ MFC after: 2 months.
* Add support for the newly added SCTP API.tuexen2011-06-151-25/+87
| | | | | | | | | | | | | In particular add support for: * SCTP_SNDINFO, SCTP_PRINFO, SCTP_AUTHINFO, SCTP_DSTADDRV4, and SCTP_DSTADDRV6 cmsgs. * SCTP_NXTINFO and SCTP_RCVINFO cmgs. * SCTP_EVENT, SCTP_RECVRCVINFO, SCTP_RECVNXTINFO and SCTP_DEFAULT_SNDINFO socket option. * Special association ids (SCTP_FUTURE_ASSOC, ...) * sctp_recvv() and sctp_sendv() functions. MFC after: 1 month.
* Get rid of unused functions.tuexen2011-05-291-43/+0
| | | | MFC after: 1 week.
* Fix a locking issue showing up on Mac OS X when subscribing totuexen2011-05-081-9/+9
| | | | | | authentication events. DTLS/SCTP renegotiations trigger the bug. MFC after: 2 weeks.
* Tunes and fixes the new DC-CC to seem to hit therrs2011-03-081-27/+53
| | | | | | | | | right mix. Still may need some tweaks but it appears to almost not give away too much to an RFC2581 flow, but can really minimize the amount of buffers used in the net. MFC after: 3 months
* Improvements to CC modules:rrs2011-02-261-0/+26
| | | | | | | | | | | 1) Add four new points that allow you to get more information to cc algo's 2) Fix the case where user changes module on a existing TCB, in such a case, the initialization module needs to be called on all nets. 3) Move htcp_cc structure to a union that other modules can use. 4) Add 5th point for get/set socket options for cc_module specific options MFC after: 2 months
* 1) Typo correction in comments and one spacing change.rrs2011-02-051-0/+2
| | | | | 2) Mass update to all copyrights. MFC after: 3 Months
* 1) Allow a chunk to track the cwnd it was at when sent.rrs2011-02-021-8/+12
| | | | | | | | | | | | | | | | | | | 2) Add separate max-bursts for retransmit and hb. These are set to sysctlable values but not settable via the socket api. This makes sure we don't blast out HB's or fast-retransmits. 3) Determine on the first data transmission on a net if its local-lan (by being under or over a RTT). This can later be used to think about different algorithms based on locallan vs big-i (experimental) 4) The cwnd should NOT be allowed to grow when an ECNEcho is seen (TCP has this same bug). We fix this in SCTP so an ECNe being seen prevents an advance of cwnd. 5) CWR's should not be sent multiple times to the same network, instead just updating the TSN being transmitted if needed. MFC after: 1 Month
* More ECN fixes:rrs2011-01-311-182/+5
| | | | | | | | | | | 1) We now remove ECN-Nonce since it will no longer continue as a I-D 2) Eliminate last_tsn_echo, this tied us to an assoc not the net and thus we were not doing m-homing on the ECN-Echo senders side right. 3) Increment the count going out even if the TSN in lower in the pending ECN-Echo, this way the receiver knows exactly how many packets were marked even with network re-ordering 4) Fix so we DO NOT stop doing delayed sack if a ECN Echo is in queue MFC after: 1 month
* Fixes to ECN in SCTP.rrs2011-01-291-0/+8
| | | | | | | | | | | | | 1) ECN was on an association basis, this is incorrect and will not work with CMT or for that matter if the user is sending to multiple addresses. This commit makes ECN on a per path basis. 2) Adopt the new format for the ECN internet draft. This also maintains compatability with old format chunks as well. 3) Keep track of the real time of a RTT down to micro seconds. For some future conditional features (for like a data center this is good information to have). MFC after: 1 month
* Define and use SCTP_SSN_GE, SCTP_SSN_GT, SCTP_TSN_GE, SCTP_TSN_GT macrostuexen2010-12-301-152/+88
| | | | | | | and use them instead of the generic compare_with_wrap. Retire compare_with_wrap. MFC after: 3 months.
* Code cleanup: Use LIST_FOREACH, LIST_FOREACH_SAFE, TAILQ_FOREACH,tuexen2010-12-301-261/+183
| | | | | | | TAILQ_FOREACH_SAFE where appropriate. No functional change. MFC after: 3 months.
* Improve plausibility check in sctp_handle_sack().tuexen2010-12-221-29/+21
| | | | | | Allow cmt_on_off to support values 0 (no CMT), 1 (CMT), and 2 (CMT/RP). MFC after: 3 months.
* Bugfix: Take also the nr-mapping array into account when detectingtuexen2010-12-161-5/+7
| | | | | | | gaps. Reviewed by: rrs@ MFC after: 3 days.
* Add a missing cast. Reported by blade_ly at yahoo.com.cn.tuexen2010-12-161-1/+1
| | | | MFC after: 1 day.
* Fix a bug where also the number of non-renegable gap reportstuexen2010-12-041-47/+22
| | | | | | was considered to be potentially renegable. MFC after: 1 day.
* Not only stop all timers when entering the SHUTDOWN_SENT state,tuexen2010-11-071-2/+2
| | | | | | but also when entering the SHUTDOWN_ACK_SEND state. MFC after: 3 days.
* Fix a locking issue which resulted in aborted associationstuexen2010-09-201-4/+4
| | | | | | due to a corrupted nr-mapping array. MFC after: 2 weeks.
* Fix a bug where the wrong PR-SCTP policy was considered.tuexen2010-09-171-7/+1
| | | | | | | While there, use always the same code for the check of TTL expiration. MFC after: 2 weeks.
* Use TAILQ_EMPTY() for testing if a tail queue is empty.tuexen2010-09-151-4/+5
| | | | Set whoFrom to NULL after freeing whoFrom.
* Fix the switching on/off of CMT using sysctl and socket option.tuexen2010-08-281-10/+17
| | | | | | | | Fix the switching on/off of PF and NR-SACKs using sysctl. Add minor improvement in handling malloc failures. Improve the address checks when sending. MFC after: 4 weeks
* PR SCTP Bugs. Basically a full sized frame ofrrs2010-07-291-15/+16
| | | | | | | | PR SCTP FWD-TSN's would not be sent and thus cause a stalled connection. Also the rwnd Calculation was also off on the receiver side for PR-SCTP. MFC after: 1 month
* BUG:Turns out we need to use both bit mapsrrs2010-06-091-11/+1
| | | | | | | to calculate the cum-ack (we were not doing it for the NR-Sack case). With this fix NR-sack should now work correctly. MFC after: 1 week
* 2 Bugs:rrs2010-06-081-2/+20
| | | | | | | | | | | | | 1) Only use both mapping arrays when NR sack is off. This way we can hold off moving the cumack (not the best but workable) when NR-sack is on. 2) We must make sure to just return on the move of the bit to the NR array if the cum-ack as already went past the TSN. This prevents marking a bit behind the array and hitting the invariant code that panic's us. MFC after: 1 week
* This fixes a BUG in the handling of the cum-ack calculation.rrs2010-06-071-7/+12
| | | | | | | | | | | | | | We were only paying attention to the nr-mapping-array. Which seems to make sense on the surface, by definition things up to the cum-ack should be deliverable thus in the nr-mapping-array. However (there is always a gotcha) thats not true when it comes to large messages. The stack may hold the message while re-assembling it not not deliver it based on several thresholds. If that happens (which it would for smaller large messages) then the cum-ack is figured wrong. We now properly use both arrays in the cum-ack calculation. MFC after: 1 week.
* Use the proper increment macro when increasing therrs2010-06-051-3/+4
| | | | | | number on sent_queue_retran_cnt. MFC after: 1 week
* More PR-SCTP bugs:rrs2010-05-121-2/+3
| | | | | | | | | - Make sure that when you kick the streams you add correctly using a 16 bit unsigned. - Make sure when sending out you allow FWD-TSN to skip over and list the ACKED chunks in the stream/seq list (so the rcv will kick the stream) MFC after: 3 days
* Get rid of unused constants.tuexen2010-05-121-8/+0
| | | | MFC after: 3 days.
* This fixes PR-SCTP issues:rrs2010-05-121-36/+13
| | | | | | | | | | - Slide the map at the proper place. - Mark the bits in the nr_array ONLY if there is no marking. - When generating a FWD-TSN we allow us to skip past ACKED chunks too. MFC after: 1 weeks
* Undo my lastest fix since that wasn't one at all.tuexen2010-04-251-19/+19
| | | | MFC after: 3 days.
* * Fix compilation when using SCTP_AUDITING_ENABLED.tuexen2010-04-231-38/+20
| | | | | | | | | * Fix delaying of SACK by taking out old optimization code which does not optimize anymore. * Fix fast retransmission of chunks abandoned by the "number of retransmissions" policy. MFC after: 3 days.
* Update highest_tsn variables when sliding mapping arrays.tuexen2010-04-201-0/+6
|
* Get delayed SACK working again.tuexen2010-04-191-0/+4
| | | | MFC after: 3 days.
* Fix a bug where SACKs are not sent when they should.tuexen2010-04-171-8/+13
| | | | | | | Move some protection code to INVARIANTS. Cleanups. MFC after: 3 days.
* Fix a off-by-one bug in zeroing out the mapping arrays.tuexen2010-04-061-3/+2
| | | | | | Fix sctp_print_mapping_array(). MFC after: 1 week
* * Fix some race condition in SACK/NR-SACK processing.tuexen2010-04-031-251/+193
| | | | | | | | * Fix handling of mapping arrays when draining mbufs or processing FORWARD-TSN chunks. * Cleanup code (no duplicate code anymore for SACKs and NR-SACKs). Part of this code was developed together with rrs. MFC after: 2 weeks.
* Fix for NR-Sack code. The code was NOT working properly whenrrs2010-03-241-592/+125
| | | | | | | | | | | | | enabled. Basically most of the operations were incorrect causing bad sacks when you enabled nr-sack. The fixes range across 4 files and unifiy most of the processing so that we only test nr_sack flags to decide which type of sack to generate. Optimization left for this is to combine the sack generation code and make it capable of generating either sack thus shrinking out a routine. Reviewed by: tuexen@freebsd.org
* Fixes a bug where SACKs in the face ofrrs2010-03-231-35/+1
| | | | | | | | | | | | | | | | mapping_array expansion would break. Basically once we expanded the array we no longer had both mapping arrays in sync which the sack processing code depends on. This would mean we were randomly referring to memory that was probably not there. This mostly just gave us bad sack results going back to the peer. If INVARIENTS was on of course we would hit the panic routine in the sack_check call. We also add a print routine for the place where one would panic in invarients so one can see what the main mapping array holds. Reviewed by: tuexen@freebsd.org MFC after: 2 weeks
* Use uint32_t instead of u_long.tuexen2010-02-181-3/+3
| | | | MFC after: 1 week
* Get rid of a lot of duplicated code for NR-SACK handle.tuexen2010-01-171-1857/+153
| | | | Generalize the SACK to code handle also NR-SACKs.
* This fixes a bug where the value set by SCTP_PARTIAL_DELIVERY_POINTtuexen2009-08-241-3/+3
| | | | | | | was not honored, if the socket buffer size was not 4 times that large. Approved by: rrs (mentor) MFC after: 3 days.
* This fixes two bugs in the NR-Sack code:rrs2009-08-241-460/+255
| | | | | | | | | | | | 1) When calculating the table offset for sliding the sack array, the two byte values must be "ored" together in order for us to do the correct sliding of the arrays. 2) We were NOT properly doing CC and other changes to things only NR-Sacked. The solution here is to make a separate function that will actually do both CC/updates and free things if its NR sack'd. This actually shrinks out common code from three places (much better). MFC after: 3 days
* * Fix a bug where PR-SCTP settings are ignore when using implicittuexen2009-08-151-11/+22
| | | | | | | | | | | | | | | association setup. * Fix a bug where message with illegal stream ids are not deleted. * Fix a crash when reporting back unsent messages from the send_queue. * Fix a bug related to INIT retransmission when the socket is already closed. * Fix a bug where associations were stalled when partial delivery API was enabled. * Fix a bug where the receive buffer size was smaller than the partial_delivery_point. Approved by: re, rrs (mentor) MFC after: One day.
* Turns out that when a receiver forwards through its TNS's therrs2009-07-281-9/+15
| | | | | | | | | | | | | | | processing code holds the read lock (when processing a FWD-TSN for pr-sctp). If it finds stranded data that can be given to the application, it calls sctp_add_to_readq(). The readq function also grabs this lock. So if INVAR is on we get a double recurse on a non-recursive lock and panic. This fix will change it so that readq() function gets a flag to tell if the lock is held, if so then it does not get the lock. Approved by: re@freebsd.org (Kostik Belousov) MFC after: 1 week
* Fix the handling of unordered messages when usingtuexen2009-07-271-1/+7
| | | | | | | PR-SCTP. Approved by: re, rrs (mentor) MFC after: 3 weeks.
* Changes to the NR-Sack code so that:rrs2009-06-171-205/+131
| | | | | | | | | | | | 1) All bit disappears 2) The two sets of gaps (nr and non-nr) are disjointed, you don't have gaps struck in both places. This adjusts us to coorespond to the new draft. Still to-do, cleanup the code so that there are only one set of sack routines (original NR-Sack done by E cloned all sack code).
* Move the flight size reduction to right afterrrs2009-04-141-22/+22
| | | | | | | | | we recognize its a retransmit, ahead of the PR-SCTP work. Without this fix, we end up NOT reducing flight size and causing an miscalculation when PR-SCTP is active and data is skipped. Obtained from: Michael Tuexen.
* Fix a FR bug. When doing PR-SCTP with number rtxrrs2009-04-081-13/+19
| | | | | | | set to a low number. The check for skipping was in the incorrect place. Which meant we would FR chunks we should not. MFC after: 1 Month
OpenPOWER on IntegriCloud