| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
in r223429. As bde@ pointed out, it was mostly backwards.
|
|
|
|
| |
from messages.
|
|
|
|
|
|
|
|
| |
operate on one type of filesystem, mention this.
While here, capitalise the use of "UFS" in growfs.8 to match other uses of
the term in other man pages.
MFC after: 1 week
|
|
|
|
|
|
| |
PR: docs/154934
Submitted by: Eitan Adler <lists at eitanadler.com>
MFC after: 3 days
|
|
|
|
| |
Submitted by: Garrett Cooper
|
| |
|
|
|
|
|
|
|
| |
Casting from (char *) to (struct ufs1_dinode *) changes the
alignment requirement of the pointer and GCC does not know that
the pointer is adequately aligned (due to malloc(3)), and warns
about it. Cast to (void *) first to by-pass the check.
|
|
|
|
|
|
|
|
|
|
|
|
| |
into un-zeroed storage.
The original patch was questioned by Kirk as it forces the filesystem
to do excessive work initialising inodes on first use, and was never
MFC'd. This change mimics the newfs(8) approach of zeroing two
blocks of inodes for each new cylinder group.
Reviewed by: mckusick
MFC after: 3 weeks
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cylinder groups that are created. When the filesystem is first created,
newfs always initialises the first two blocks of inodes, and then in the
UFS1 case will also initialise the remaining inode blocks. The changes in
growfs.c 1.23 broke the initialisation of all inodes, seemingly based on
this implementation detail in newfs(8). The result was that instead of
initialising all inodes, we would actually end up initialising all but the
first two blocks of inodes. If the filesystem was grown into empty
(all-zeros) space then the resulting filesystem was fine, however when
grown onto non-zeroed space the filesystem produced would appear to have
massive corruption on the first fsck after growing.
A test case for this problem can be found in the PR audit trail.
Fix this by once again initialising all inodes in the UFS1 case.
PR: bin/115174
Submitted by: Nate Eldredgei nge cs.hmc.edu
Reviewed by: mjacob
MFC after: 1 month
|
| |
|
|
|
|
|
|
|
|
|
|
| |
(sblock.fs_magic == FS_UFS1_MAGIC) case, so the check within the
loop is redundant.
Submitted by: Nate Eldredge nge cs.hmc.edu
Reviewed by: mjacob
Approved by: ed (mentor)
MFC after: 1 month
|
|
|
|
| |
Submitted by: Ulrich Spörlein
|
|
|
|
|
|
|
|
|
| |
actually initialized. In the growfs case for UFS2, no inodes were actually
being initialized and the number of inodes noted as initialized was the
number of inodes per group. This created a filesystem that was deemed
corrupted because the inodes thus added were full of garbage.
MFC after: 1 month
|
|
|
|
|
| |
PR: bin/113399
Submitted by: Staffan Ulfberg <staffan@ulfberg.se>
|
|
|
|
| |
Sponsored by: home.pl
|
| |
|
|
|
|
|
|
|
| |
information to /tmp/growfs.debug, which is a world-writable directory.
MFC after: 3 days
Reported by: Jon Passki <cykyc@yahoo.com>
|
| |
|
| |
|
| |
|
|
|
|
| |
any fake value.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) ginode() is passed a cylinder group number and inode number. The inode
number is relative to the cg. Use this relative number rather than the
absolute inode number when searching the cg inode bitmap to see if the inode
is allocated. Using the absolute number quickly runs the check off the end
of the array and causes invalid inodes to be referenced.
2) ginode() checks the absolute indoe number to make sure that it is greater
than ROOTINO. However, the caller loops through all of the possible inode
numbers and directly passes in values that are < ROOTINO. Instead of halting
the program with an error, just return NULL.
3) When allocating new cylinder groups, growfs was initializing all of the
inodes in the group regardless of this only being required for UFS1. Not
doing this for UFS2 provides a significant performance increase.
These fixes allow growing a filesystem beyond a trivial amount and have
been tested to grow an 8GB filesystem to 1.9TB. Much more testing would
be appreciated.
Obtained from: Sandvine, Inc.
|
|
|
|
|
| |
to use when setting values that depend on the UFS version.
Raise WARNS again.
|
| |
|
|
|
|
| |
Use braces instead.
|
|
|
|
| |
for the declaration of time().
|
|
|
|
| |
Tested on: alpha, i386, ia64, sparc64
|
|
|
|
|
|
|
|
| |
WARNS=6. I don't change the WARNS level in the Makefile because I
didn't tested this on other archs.
The fs.h fix was suggested by: marcel
Reviewed by: md5(1)
|
|
|
|
|
|
|
| |
- Use the %jd format and a cast to intmax_t to print an int64_t.
- The return type of getopt() is an int, not a char.
This fixes some warnings but there's still much more work to do here.
|
|
|
|
|
|
| |
the {powerpc, sparc64, ia64} tinderboxes.
Sorry for the noise. :-(
|
|
|
|
| |
Approved by: grog (mentor)
|
|
|
|
| |
commit bits retired for safe keeping.
|
|
|
|
|
|
| |
all inodes are initialized when running newfs.
Approved by: grog (mentor)
|
|
|
|
|
|
| |
PR: bin/61472
Submitted by: Alex Popa <razor@ldc.ro>
MFC after: 1 week
|
|
|
|
| |
Noticed by: Andre Guibert de Bruet <andy@siliconlandmark.com> (via -doc)
|
|
|
|
| |
Submitted by: Andre Guibert de Bruet <andy@siliconlandmark.com> (via -doc)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for UFS2 to the UFS debugging routines in growfs; required
to update ffsinfo(8) for UFS2. A variety of types and fs variables are
renamed to reflect UFS1/2 structures. Also, the print routines for
inodes are now split into separate UFS1 and UFS2 versions. We now
define dbg_dump_csum_total(), but lose the printing of rotational
information since that's not present in UFS2. In the future, we may
want to re-add this functionality to print it solely for UFS1.
Submitted by: Lukas Ertl <l.ertl@univie.ac.at>
PR: bin/53517
|
|
|
|
| |
the build almost a year ago.
|
| |
|
|
|
|
|
| |
Submitted by: Lukas Ertl <l.ertl@univie.ac.at>
Approved by: re (scottl)
|
|
|
|
|
| |
PR: misc/50979
Submitted by: Lukas Ertl <l.ertl@univie.ac.at>
|
|
|
|
| |
Add FreeBSD Id tag where missing.
|
|
|
|
| |
Approved by: re
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the old 8-bit fs_old_flags to the new location the first time that the
filesystem is mounted by a new kernel. One of the unused flags in
fs_old_flags is used to indicate that the flags have been moved.
Leave the fs_old_flags word intact so that it will work properly if
used on an old kernel.
Change the fs_sblockloc superblock location field to be in units
of bytes instead of in units of filesystem fragments. The old units
did not work properly when the fragment size exceeeded the superblock
size (8192). Update old fs_sblockloc values at the same time that
the flags are moved.
Suggested by: BOUWSMA Barry <freebsd-misuser@netscum.dyndns.dk>
Sponsored by: DARPA & NAI Labs.
|
| |
|
| |
|
|
|
|
|
|
|
| |
before growing partitions with growfs(8), if necessary.
PR: docs/42148
Submitted by: Chris S.J. Peron <maneo@bsdpro.com>
|
| |
|
| |
|