summaryrefslogtreecommitdiffstats
path: root/sbin/devd
Commit message (Collapse)AuthorAgeFilesLines
* Document RCTL events in devd.conf(5).trasz2015-05-131-1/+23
| | | | | MFC after: 1 month Sponsored by: The FreeBSD Foundation
* Add devd(8) notifications for creation and destruction of GEOM devices.trasz2015-01-141-1/+28
| | | | | | Differential Revision: https://reviews.freebsd.org/D1211 MFC after: 1 month Sponsored by: The FreeBSD Foundation
* Convert sbin/ to LIBADDbapt2014-11-251-2/+1
| | | | Reduce overlinking
* Misc fixes suggested by Coverity.asomers2014-08-201-3/+9
| | | | | | | | | | | | sbin/devd/tests/client_test.c * In the event that popen fails, don't dereference its return value. * Fix array overwrite in the stream and seqpacket tests. * Close sockets at the end of successful ATF tests. Reported by: Coverity scan CID: 1232019, 1232020, 1232029, 1232030 MFC after: 1 week Sponsored by: Spectra Logic
* Remove bogus ; at the end of the if condition in order to unbreak gcc buildsbz2014-08-151-2/+2
| | | | | | | after r270004. MFC after: 4 days X-MFX with: r270004
* Convert devd's client socket to type SOCK_SEQPACKET.asomers2014-08-145-38/+276
| | | | | | | | | | | | | | | | | | | | | | | | | This change consists of two merges from projects/zfsd/head along with the addition of an ATF test case for the new functionality. sbin/devd/tests/Makefile sbin/devd/tests/client_test.c Add ATF test cases for reading events from both devd socket types. r266519: sbin/devd/devd.8 sbin/devd/devd.cc Create a new socket, of type SOCK_SEQPACKET, for communicating with clients. SOCK_SEQPACKET sockets preserve record boundaries, simplying code in the client. The old SOCK_STREAM socket is retained for backwards-compatibility with existing clients. r269993: sbin/devd/devd.8 Fix grammar bug. CR: https://reviews.freebsd.org/rS266519 MFC after: 5 days Sponsored by: Spectra Logic
* Revert r263694, and apply a better fix to squelch unnecessary warningsdim2014-03-261-1/+0
| | | | | | | | | | from clang about possible keywords being treated as identifiers for the remainder of the translation unit (a.k.a. -Wkeyword-compat), when using libstdc++ in combination with -Wsystem-headers. This will not only fix devd, but any C++ program using libstdc++. MFC after: 3 days X-MFC-With: r263694
* Update userspace users of hw.bus.devctl_disable.mjg2014-03-261-4/+4
| | | | | | | | This fixes breakage resulting from r263754. Reported by: AN <andy@neu.net> Reviewed by: imp Pointy hat to: me
* Apply a temporary band-aid for building devd with clang 3.4, libstdc++dim2014-03-241-0/+1
| | | | | | | | and -Wsystem-headers enabled (which is the default for any non-zero WARNS level, crazily enough!). This is primarily meant to be MFC'd as soon as possible. MFC after: 3 days
* sbin/devd/devd.8asomers2014-03-072-13/+19
| | | | | | | | | | sbin/devd/devd.cc Add a -q flag to devd that will suppress syslog logging at LOG_NOTICE or below. Requested by: ian@ and imp@ MFC after: 3 weeks Sponsored by: Spectra Logic Corporation
* sbin/devd/devd.ccasomers2013-12-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | Promoting the SIGINFO handler's log message from LOG_INFO to LOG_NOTICE, and promoting the "Processing event ..." message from LOG_DEBUG to LOG_INFO. Setting the logfile to LOG_NOTICE with this change will have the same result as setting it to LOG_INFO without this change. Setting it to LOG_INFO with this change will include the useful "Processing event ..." messages that were previously at LOG_DEBUG, without including useless messages like "Pushing table". The intent of this change is that one can log "Processing event ..." without logging "Pushing table" and related messages that are sent for every event. The number of lines actually logged is reduced by about 75% by making this change and setting syslog to LOG_INFO vs setting syslog to LOG_DEBUG. etc/syslog.conf Changing the recommended loglevel to notice instead of info. Sponsored by: Spectra Logic Corp MFC after: 4 weeks
* sbin/devd/devd.ccasomers2013-12-131-1/+20
| | | | | | | | | | | | | | Increase the size of devd's client socket's send buffer from the default (8k) to 128k. This prevents clients from getting POLLHUPped during event storms. For example, during zpool creation, the kernel emits a resource.fs.zfs.statechange event for every vdev in the pool. A 128k buffer is large enough to hold the statechange events for a pool with nearly 800 drives. Reviewed by: ian, imp Approved by: ken (mentor) Sponsored by: Spectra Logic Corp MFC after: 4 weeks
* devd: lower priority of action execution logging to infoavg2013-11-071-1/+1
| | | | Reviewed by: asomers
* devd: fix a typo in a commentavg2013-11-071-1/+1
| | | | Reviewed by: asomers
* Correct the printf format specifier for total_events.asomers2013-07-081-2/+3
| | | | | | | Add __printflike argument checking for devdlog(). Reported by: pjd Approved by: gibbs (co-mentor)
* Explicitly include <cstdarg> to fix compilation with libc++. It is implicitlyasomers2013-07-021-0/+1
| | | | | | | included by libstdc++. Reported By: Oliver Hartmann Approved by: gibbs (co-mentor, implicit)
* style(9) fixes, including the removal of page break characters. No functionalasomers2013-07-011-19/+19
| | | | | | changes. Approved by: gibbs (co-mentor)
* Add a SIGINFO handler to devd. It will send useful statistics to syslog orasomers2013-07-011-0/+19
| | | | | | | | stderr as appropriate. Currently, the only statistic printed is the number of events received. Reviewed by: eadler Approved by: gibbs (co-mentor)
* Add syslog(3) support to devd(8).asomers2013-07-012-36/+60
| | | | | | | | | | | | | | | | | | | | | sbin/devd/devd.cc All output will now go to syslog(3) if devd is daemonized, or stderr if it's running in the foreground. sbin/devd/devd.8 Remove the "-D" flag. Filtering messages by priority now happens in the usual syslog way. For performance reasons, a few extra-verbose debugging statements are now conditional on the "-d" (do not daemonize) flag. etc/syslog.conf etc/newsyslog.conf Direct messages from devd(8) to /var/log/devd.log, but leave it disabled by default Reviewed by: eadler Approved by: gibbs (co-mentor) MFC after: never (removed a command-line option from devd)
* Improve compatibility with recent flex from flex.sourceforge.net.jkim2013-05-031-2/+3
|
* Prefer using the C++ version of the standard headers. These place theeadler2013-05-021-6/+7
| | | | | | | | names within the std namespace (and possibly within the global namespace). The main advantage is that the C++ versions can provide optimized versions or simplified interfaces.
* According to devctl(4), clients must read events whole; they may notasomers2013-04-261-1/+1
| | | | | | | | | | | | piece them together from multiple reads(). It's as if /dev/devctl is a datagram device instead of a stream device. However, devd's internal buffer was too small (1025 bytes) to read an entire ereport.fs.zfs.checksum event (variable, up to ~1300 bytes). This commit enlarges the buffer to 8k. Reviewed by: imp Approved by: ken (mentor) MFC after: 2 weeks
* devd: Correct typo in comment.eadler2013-03-041-1/+1
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Use simpler dst += *x instead of str.append(x, 1).eadler2013-03-041-6/+6
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Use string::empty() instea of string::length() == 0.eadler2013-03-041-1/+1
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Remove unnecessary empty default constructors.eadler2013-03-041-2/+0
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Remove empty virtual destructor from class, which has noch subclasses.eadler2013-03-041-1/+0
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Avoid unnecessary temporary objects (and simplify the code) when ↵eadler2013-03-041-3/+3
| | | | | | | handling std::string. Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Use the standard constructor of std::string instead of string("").eadler2013-03-041-1/+1
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Simplify while (1) { if (x) break; } to while (!x) {}.eadler2013-03-041-3/+1
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Remove call to _exit() from signal handler, which also sets a stop flag.eadler2013-03-041-1/+0
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* devd: Use volatile sig_atomic_t for the flag set by a signal handler.eadler2013-03-041-2/+2
| | | | | Submitted by: Christoph Mallon <christoph.mallon@gmx.de> Approved by: cperciva (mentor)
* Constify where possible.eadler2013-03-042-2/+2
| | | | Approved by: cperciva (mentor)
* Reflect CARP media-type departure.pluknet2013-02-211-3/+2
| | | | X-MFC after: never
* Separate items in the list of System values with .Pp to ease readability.pluknet2013-02-211-0/+4
|
* Bump .Dd for the change in r246121.zeising2013-02-051-1/+1
| | | | Approved by: joel (mentor)
* Improve devd startup time, by tweaking some string handling routines that areian2013-01-302-25/+32
| | | | | | | | | | | | heavily used when parsing config files. Mostly these changes avoid making temporary copies of the strings, and avoid doing byte at a time append operations, on the most-used code path. On a 1.2 GHz ARM processor this reduces the time to parse the config files from 13 to 6 seconds. Reviewed by: imp Approved by: cognet (mentor)
* Fix a descriptor leak in devd. Clients reading /var/run/devd.pipe can closeian2013-01-302-14/+95
| | | | | | | | | | | | | | | | | their socket connection any time, and devd only notices that when it gets an error trying to write an event to the client. On a system with no device change activity, clients could connect and disappear repeatedly without devd noticing, leading to an ever-growing list of open socket descriptors in devd. Now devd uses poll(2) looking for POLLHUP on all existing clients every time a new client connection is established, and also periodically (once a minute) to proactively find zombie clients and reap the socket descriptors. It also now has a connection limit, configurable with a new -l <num> command line arg. When the maximum number of connections is reached it stops accepting new connections until some current clients drop off. Reviewed by: imp Approved by: cognet (mentor)
* Prefer the use of initalizer lists to ctor assignment.eadler2012-12-062-3/+2
| | | | | Approved by: cperciva MFC after: 2 weeks
* Avoid the creation of a temporary object by using the prefix operatoreadler2012-12-061-9/+9
| | | | | | | for non-primitive types. Approved by: cperciva MFC after: 2 weeks
* Constify where possibleeadler2012-12-062-7/+7
| | | | | Approved by: cperciva MFC after: 2 weeks
* Fix an old bug in devd, where it uses std::sort() to sort the variousdim2012-12-051-1/+1
| | | | | | | | | | | | | | | | | | | | | lists it reads from its configuration files on the priority field. Because some items in the lists have the same priority, and std::sort() is not stable, the exact order in which the items are enumerated does not have to correspond to the order they appear in the configuration files. Apparently this was never noticed with libstdc++, but with libc++ it could cause the "uhid" entry from /etc/devd/usb.conf to be used instead of the "ums" entry (which is earlier in the file). This caused the problem described in the PR: the USB mouse module was never loaded, and the other actions (such as starting moused) were not executed. To fix the problem, make devd use std:stable_sort() instead. Reported by: Jan Beich <jbeich@tormail.org> PR: bin/172958 MFC after: 2 weeks
* document acpi_cpu devd notification about _CST changeavg2012-10-201-0/+2
| | | | | | Based on prodding and a submission by Lars Engels <lars.engels@0x20.net>. MFC after: 5 days
* Use O_CLOEXEC for open instead of separate fcntl(2) call.pjd2012-09-221-3/+1
|
* Make devd build with libc++.dim2012-06-011-1/+1
| | | | MFC after: 3 days
* Fix world after byacc import:bapt2012-05-221-0/+1
| | | | | | | | - old yacc(1) use to magicially append stdlib.h, while new one don't - new yacc(1) do declare yyparse by itself, fix redundant declaration of 'yyparse' Approved by: des (mentor)
* Fix build.glebius2012-01-061-1/+0
|
* o Sort .Xrs.maxim2011-12-191-2/+2
|
* In sbin/devd/devd.h, 'event_proc' and 'eps' are declared as structs. Indim2011-12-171-2/+2
| | | | | | devd.hh, there are redeclared as classes. Fix the inconsistency. MFC after: 1 week
* Xref re_format(7) in devd.conf(5), not in devd(8).glebius2011-12-162-5/+5
| | | | Pointy hat to: glebius
OpenPOWER on IntegriCloud