| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
objects' reference counts. This function is called by the atexit
mechanism at program shutdown. I don't think the locking is necessary
here. It caused OpenOffice builds to hang more often than not.
Credit to Martin Blapp and Matt Dillon for helping to diagnose this
problem and for testing the fix.
|
|
|
|
|
|
|
|
| |
2) Remove unneeded "if not NULL" props from "pathstring",
which will never be NULL by the lexer design.
Inspired by: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
glob(3) will return at least one pathname unless
a system error has occured. It's not a "not found"
error otherwise.
MFC after: 3 days
|
|
|
|
|
|
|
|
| |
for NULL. The "pathname" rule may return NULL
on a glob(3) error.
Obtained from: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
Earlier, a decimal number (e.g., 890) could be passed
for mode, leading to dangerous permissions set:
-1, that is, 07777.
Obtained from: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
| |
requests against large files will be denied.
MFC after: 10 days
|
|
|
|
|
|
|
|
| |
This eliminates an opportunity for DoS attack.
Pointed out by: maxim
Inspired by: lukemftpd, OpenBSD
MFC after: 2 weeks
|
|
|
|
|
|
| |
to a successful MKD command.
MFC after: 1 week
|
|
|
|
|
|
|
| |
(as it was intended initially)
and document it in the manpage.
MFC after: 2 weeks
|
|
|
|
|
|
| |
(which has been there at least since 4.4BSD-Lite!)
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
alphabetical order, lower and upper case of the same letter
stick together, lower case first.
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
non-portable constants (in this case, hidden as offsets
to the "?AEIL" string.)
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
socket option to avoid exausting the passive port
space by TIME_WAIT'ing connections.
PR: bin/36955
Submitted by: Maxim Konovalov <maxim@FreeBSD.org>
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
| |
write(2), and getipnodebyaddr(3) calls. Now all the above functions
accept "void *" in that arguments and have prototypes. Thus, the
casts are useless under the normal circumstances (and would be harmful
if the functions had no prototypes.)
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
| |
o Always check a setsockopt(2) return value
o Use a consistent message format
o Don't abort if the failed setsockopt(2) was actually not vital
o Use LOG_WARNING, not LOG_ERR, in non-fatal cases
MFC after: 1 week
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
Double double-quotes in a PWD result
if they appear in the directory pathname.
PR: misc/18365
MFC after: 1 week
|
|
|
|
|
|
|
| |
to being an interface to finger(1), see -p flag. Remove a reference to
name(?) program we don't have.
Submitted by: wollman
|
|
|
|
|
|
|
|
| |
deleting symlinks pointing to directories.
PR: bin/37250
Submitted by: Nino Dehne <TeCeEm@gmx.de>
MFC after: 1 week
|
| |
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
o "struct addrinfo" contains a pointer to "struct sockaddr,"
not "struct sockaddr" itself
o the function takes a pointer to "struct in*_addr", not to
"struct sockaddr," so the address length must be corresponding
MFC after: 1 week
|
| |
|
|
|
|
|
|
|
| |
not to `for'. The previous indent was reather misleading for
the code reader.
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
by conventional one-way parsing of ftphosts(5).
Don't let NULL hostname pointers into virtual
host records as well.
PR: bin/18410
MFC after: 1 month
|
|
|
|
| |
Submitted by: Jean-Luc Richier <Jean-Luc.Richier@imag.fr>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thus lines of any length can be handled, unlike before.
Don't assume that each line read from the files ends with a newline.
As a side effect in inithosts(), don't use automatic buffer at all,
utilize malloc(3) when getting local host name instead.
PR: misc/21494
Reviewed by: maxim, mikeh
MFC after: 1 month
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
comsat:
only send two bell charecters if S_IXGRP is set and S_IXUSR is not.
biff:
add new option 'b' to set S_IXGRP.
PR: 10931
Submitted by: Andrew J. Korty <ajk@purdue.edu>
Approved by: sheldonh (mentor)
MFC after: 1 month
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They provided little benefit (if any) and they caused some problems
in OpenOffice, at least in post-KSE -current and perhaps in other
environments too. The nanosleep calls prevented the profiling timer
from advancing during the spinloops, thereby preventing the thread
scheduler from ever pre-empting the spinning thread. Alexander
Kabaev diagnosed this problem, Martin Blapp helped with testing,
and Matt Dillon provided some helpful suggestions.
This is a short-term fix for a larger problem. The use of spinlocking
isn't guaranteed to work in all cases. For example, if the spinning
thread has higher priority than all other threads, it may never be
pre-empted, and the thread holding the lock may never progress far
enough to release the lock. On the other hand, spinlocking is the
only locking that can work with an arbitrary unknown threads package.
I have some ideas for a much better fix in the longer term. It
would eliminate all locking inside the dynamic linker by making it
safe for symbol lookups and lazy binding to proceed in parallel
with a call to dlopen or dlclose. This means that the only mutual
exclusion needed would be to prevent multiple simultaneous calls
to dlopen and/or dlclose. That mutual exclusion could be put into
the native pthreads library. Applications using foreign threads
packages would have to make their own arrangements to ensure that
they did not have multiple threads in dlopen and/or dlclose -- a
reasonable requirement in my opinion.
MFC after: 3 days
|
| |
|
|
|
|
|
|
|
|
| |
to transfer a file.
PR: 39362
Submitted by: TANAKA Hiroyuki <kattyo@abk.nu>
MFC after: 1 week
|
|
|
|
|
|
| |
scope identifier).
MFC after: 3 weeks
|
| |
|
|
|
|
|
|
|
|
| |
variable and used in myoob().
PR: bin/38928
Submitted by: Oliver Fromme <olli@secnetix.de>
MFC after: 1 month
|
|
|
|
|
|
| |
PR: misc/38987
Submitted by: Peter da Silva <peter@abbnm.com>
MFC after: 1 week
|
|
|
|
| |
for this stuff.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the remote host (or rather, the name as mangled by realhostname_sa())
so that the process can use it to behave differently depending on the
origin on the request. We use this to implement rudimentary visibility
control on our user information.
Make sure that the child process's standard error goes through the same
NVT-ASCII filter as is applied to the standard output.
Don't attempt to call logerr() from the child since stdio is not safe in
a vforked process. Just write a message to fd 2 instead. (Ideally, the
parent would open two pipes, and siphon off our stderr to some place less
public, but I have not attempted to do so in this implementation.)
|
| |
|
|
|
|
|
|
|
|
|
|
| |
matching constraints where appropriate. This makes the dynamic
linker buildable at -O0 again.
Thanks to Bruce Evans for identifying the cause of the build
problem.
MFC after: 1 week
|
| |
|
|
|
|
|
|
|
|
| |
Untested (testing request went unanswered), but sparc64 is not expected to
cause problems. IA64 is not expected to cause problems but the patch was
slightly more complex so the possibility exists.
Approved by: jdp
|
|
|
|
|
|
|
|
| |
tested the patch on -stable.
Reviewed by: obrien
Approved by: jdp
MFC after: 3 days
|
|
|
|
|
|
| |
by me first have given me a good excuse to drop my MAINTAINERship.
MFC after: 1 week
|
|
|
|
|
|
|
| |
goto target was so the cache could be freed. So free the cache after
done: rather then before done: (!)
Submitted by: Gavin Atkinson <gavin@ury.york.ac.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Martin Blapp determined that the elf dynamic loader was at fault. In
particular, the loader uses alloca() to allocate a symbol cache on the
stack. Normally this would work just fine, but if the loader is called
from a threaded program and the object being loaded is fairly large the
alloca() can blow away the thread stack and effect other nearby thread
stacks as well. My testing showed that the symbol cache can be as large
as 250KBytes during the openoffice port build and install sequence. Martin
was able to work around the problem by disabling the symbol cache
(cache = NULL;). However, this solution is not adequate for commit because
it can cause an enormous cpu burden for applications which do a lot of
dynamic loading (e.g. like konqueror).
The solution is to use anonymous mmap() to temporarily allocate space to
hold the symbol cache. In testing I found that replacing the alloca()
with mmap() has no observable degredation in performance.
It should be noted that this bug does not necessarily cause an immediate
crash but can instead result in long term corruption and instability in
applications that load modules from threads. The bug is almost certainly
responsible for some of the instabilities found in konqueror, for example,
and possibly netscape too.
Sleuthing work by: Martin Blapp <mb@imp.ch>
X-MFC after: Before or after the 4.6 release depending on the release engineers
|
|
|
|
| |
Delete unused include of <strings.h>.
|
| |
|
|
|
|
| |
Remove private __P.
|
|
|
|
| |
Remove private __P.
|
| |
|