| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
tested the patch on -stable.
Reviewed by: obrien
Approved by: jdp
MFC after: 3 days
|
|
|
|
|
|
| |
by me first have given me a good excuse to drop my MAINTAINERship.
MFC after: 1 week
|
|
|
|
|
|
|
| |
goto target was so the cache could be freed. So free the cache after
done: rather then before done: (!)
Submitted by: Gavin Atkinson <gavin@ury.york.ac.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Martin Blapp determined that the elf dynamic loader was at fault. In
particular, the loader uses alloca() to allocate a symbol cache on the
stack. Normally this would work just fine, but if the loader is called
from a threaded program and the object being loaded is fairly large the
alloca() can blow away the thread stack and effect other nearby thread
stacks as well. My testing showed that the symbol cache can be as large
as 250KBytes during the openoffice port build and install sequence. Martin
was able to work around the problem by disabling the symbol cache
(cache = NULL;). However, this solution is not adequate for commit because
it can cause an enormous cpu burden for applications which do a lot of
dynamic loading (e.g. like konqueror).
The solution is to use anonymous mmap() to temporarily allocate space to
hold the symbol cache. In testing I found that replacing the alloca()
with mmap() has no observable degredation in performance.
It should be noted that this bug does not necessarily cause an immediate
crash but can instead result in long term corruption and instability in
applications that load modules from threads. The bug is almost certainly
responsible for some of the instabilities found in konqueror, for example,
and possibly netscape too.
Sleuthing work by: Martin Blapp <mb@imp.ch>
X-MFC after: Before or after the 4.6 release depending on the release engineers
|
|
|
|
| |
Delete unused include of <strings.h>.
|
| |
|
|
|
|
| |
Remove private __P.
|
|
|
|
| |
Remove private __P.
|
| |
|
|
|
|
| |
Reviewed by: md5
|
|
|
|
|
|
|
|
|
| |
can then end up not properly clearing wtmp/utmp entries.
PR: bin/37934
Submitted by: Sandeep Kumar <skumar@juniper.net>
Reviewed by: markm
MFC after: 2 weeks
|
|
|
|
| |
Submitted by: ru
|
|
|
|
|
|
| |
in the environment to it's value.
Approved by: archie (after a very cursory glance)
|
| |
|
|
|
|
| |
Sponsored by: DARPA, NAI Labs
|
|
|
|
| |
Sponsored by: DARPA, NAI Labs
|
|
|
|
| |
Reviewed by: bde
|
|
|
|
| |
Sponsored by: DARPA, NAI Labs
|
|
|
|
|
|
| |
fact that caddr_t is often misspelled as char *.
Sponsored by: DARPA, NAI Labs
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o Set st_shndx for sym_zero to SHN_UNDEF instead of SHN_ABS.
This gives us something to reliably test against.
o For weak references to undefined sysmbols (as indicated by
having st_shndx equals SHN_UNDEF) in the context of OPDs,
the address of the OPD is to be zero, not the address of
the function it contains.
o For weak references to undefined symbols in all other cases
(only DIR64LSB at this time), the actual relocated value is
to be zero, not the value prior to relocating.
Roughly speaking, weak references to undefined symbols are no-ops.
Tested on: i386, ia64
|
|
|
|
| |
binding works for local symbols. Remove the workaround...
|
|
|
|
|
|
|
|
| |
relocation identifies the symbol to which we need to bind. This
solves a problem seen on ia64 where the symbol hash table does not
contain local symbols and thus resulted in unresolved symbols.
Tested on: alpha, i386, ia64
|
| |
|
|
|
|
|
| |
Also change one case of blatant __progname abuse (several more remain)
This commit does not touch anything in src/{contrib,crypto,gnu}/.
|
|
|
|
| |
Tested by: kuriyama
|
|
|
|
|
|
|
| |
I dunno if there is an IPv6 supported rexec client. So, it was
tested that this change doesn't break an IPv4.
Tested by: kuriyama (IPv4 only)
|
|
|
|
| |
Hint by: ume
|
|
|
|
|
| |
Obtained from: KAME
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
|
| |
with a back off. This was discovered when Luigi sent me code to
handle this for Etherboot. The Etherboot patch worked okay but
FreeBSD's tftpd had trouble handling it and would fail to transfer
the file since it would abort on send and not retry.
Submitted by: luigi
MFC after: 1 week
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
objects were not being correctly set to zero. Instead, the function
descriptor pointer was set to the load address of the .so object. This
caused gcc generated binaries to segfault on exit when crtbegin.asm's
_fini code tested the __cxa_finalize() function pointer for zero.
This is a bit of a hack because of a problem nearby workaround for
find_symdef and its quirks (failures) for local symbols. This still
needs to be fixed.
|
|
|
|
| |
Sponsored by: DARPA, NAI Labs
|
|
|
|
|
| |
Approved by: jdp
Tested on: alpha, i386, sparc64
|
|
|
|
| |
pollution from <strings.h>.
|
| |
|
|
|
|
|
|
| |
the NULL.
o use snprintf in preference to unchecked strcat in a couple of places that
likely can't overflow. Makes it easier to grep for strcpy :-)
|
|
|
|
|
|
|
|
|
|
|
|
| |
returns off_t in yylval.u.o. REST is the only user of yylval.u.o at the
moment.
NB: seems lukemftpd has the same bug.
PR: misc/28629
Reviewed by: ru
Approved by: ru
MFC after: 1 month
|
|
|
|
|
| |
Largely obtained from: netbsd
Submitted by: jake, tmm
|
|
|
|
|
|
|
|
| |
No functional changes from rev. 1.31.
Reviewed by: ru
Approved by: ru
MFC after: 1 week
|
| |
|
|
|
|
| |
back out last commit to un-break world.
|
|
|
|
|
|
|
| |
sometimes causes fewer directories to be searched for includes. Thus
we have to be more explicit in our search list.
Pointy at to: GCC 3.1
|
|
|
|
|
|
| |
PR: bin/25059
Approved by: jdp
MFC after: 3 weeks
|
| |
|
| |
|
|
|
|
| |
(and dcc the committer a dictionary)
|
|
|
|
|
|
| |
it was inelegant and neglected to check the return value from malloc(3).
Sponsored by: DARPA, NAI Labs
|
|
|
|
|
|
| |
<sys/stat.h> for its prerequisite <sys/time.h>.
Removed a duplicated include. Sorted includes.
|
|
|
|
|
|
|
| |
namespace pollution only 1 layer deep in <sys/stat.h> for its
prerequisite <sys/time.h>
Removed other unused includes.
|
|
|
|
| |
MFC after: 1 week
|