| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
| |
o Don't free(3) memory occupied by host structures
already in the host list.
o Set hrp->hostinfo to NULL if a host record has to stay in
the host list, but is to be ignored. Selecthost() knows that.
o Reduce the pollution with excessive NULL checks.
o Close a couple of memory leaks.
MFC after: 1 week
|
|
|
|
|
| |
Submitted by: kris
MFC after: 3 days
|
| |
|
|
|
|
|
| |
Submitted by: maxim
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
|
|
| |
for the DT_IA64_PLT_RESERVE dynamic table entry. When a shared object
does not have any PLT relocations, the linker apparently doesn't find
it necessary to actually reserve the space for the BOR (Bind On
Reference) entries as pointed to by the DTE. As a result, relocatable
data in the PLT was overwritten, causing some unexpected control flow
with annoyingly predictable outcome: coredump.
To reproduce:
% echo 'int main() { return 0; }' > foo.c
% cc -o foo foo.c -lxpg4
|
|
|
|
| |
Reviewed by: jdp
|
|
|
|
|
|
|
|
|
| |
o check getaddrinfo(3) return value, not result pointer
o getaddrinfo(3) returns int, not pointer
o don't leak memory allocated for hostnames and hostinfo structures
o initialize pointers that will be checked for NULL somewhere
MFC after: 1 week
|
|
|
|
|
|
| |
This relocation creates a function descriptor at the specified
address and is commonly used for C++ to create virtual function
tables.
|
|
|
|
| |
pollution in <kvm.h>.
|
| |
|
| |
|
|
|
|
| |
MFC after: 3 days
|
|
|
|
|
|
|
| |
want it for some other service-running program.
Approved by: markm
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
o PORT takes six byte values, not five.
o TYPE argument is mandatory.
Submitted by: demon (the 1st part)
MFC after: 3 days
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
(I skipped those in contrib/, gnu/ and crypto/)
While I was at it, fixed a lot more found by ispell that I
could identify with certainty to be errors. All of these
were in comments or text, not in actual code.
Suggested by: bde
MFC after: 3 days
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o Remove the race between stat(2) & fopen(3) when creating
a unique file.
o Improve bound checking when generating a unique name from
a given pathname.
o Ignore REST marker on APPE. No RFC specifies this case,
but the idea of resuming APPE's implies this.
o By default, deny upload resumes and appends by anonymous users.
Previously these commands were translated to STOU silently,
which led to broken files on server without any notification
to the user.
o Add an option, -m, to allow anonymous users to modify
existing files (e.g., to resume uploads) if filesystem
permissions permit.
Portions obrainded from: OpenBSD
MFC after: 3 weeks
|
|
|
|
|
|
|
|
| |
objects' reference counts. This function is called by the atexit
mechanism at program shutdown. I don't think the locking is necessary
here. It caused OpenOffice builds to hang more often than not.
Credit to Martin Blapp and Matt Dillon for helping to diagnose this
problem and for testing the fix.
|
|
|
|
|
|
|
|
| |
2) Remove unneeded "if not NULL" props from "pathstring",
which will never be NULL by the lexer design.
Inspired by: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
glob(3) will return at least one pathname unless
a system error has occured. It's not a "not found"
error otherwise.
MFC after: 3 days
|
|
|
|
|
|
|
|
| |
for NULL. The "pathname" rule may return NULL
on a glob(3) error.
Obtained from: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
Earlier, a decimal number (e.g., 890) could be passed
for mode, leading to dangerous permissions set:
-1, that is, 07777.
Obtained from: OpenBSD
MFC after: 1 week
|
|
|
|
|
|
| |
requests against large files will be denied.
MFC after: 10 days
|
|
|
|
|
|
|
|
| |
This eliminates an opportunity for DoS attack.
Pointed out by: maxim
Inspired by: lukemftpd, OpenBSD
MFC after: 2 weeks
|
|
|
|
|
|
| |
to a successful MKD command.
MFC after: 1 week
|
|
|
|
|
|
|
| |
(as it was intended initially)
and document it in the manpage.
MFC after: 2 weeks
|
|
|
|
|
|
| |
(which has been there at least since 4.4BSD-Lite!)
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
alphabetical order, lower and upper case of the same letter
stick together, lower case first.
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
non-portable constants (in this case, hidden as offsets
to the "?AEIL" string.)
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
socket option to avoid exausting the passive port
space by TIME_WAIT'ing connections.
PR: bin/36955
Submitted by: Maxim Konovalov <maxim@FreeBSD.org>
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
| |
write(2), and getipnodebyaddr(3) calls. Now all the above functions
accept "void *" in that arguments and have prototypes. Thus, the
casts are useless under the normal circumstances (and would be harmful
if the functions had no prototypes.)
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
| |
o Always check a setsockopt(2) return value
o Use a consistent message format
o Don't abort if the failed setsockopt(2) was actually not vital
o Use LOG_WARNING, not LOG_ERR, in non-fatal cases
MFC after: 1 week
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
Double double-quotes in a PWD result
if they appear in the directory pathname.
PR: misc/18365
MFC after: 1 week
|
|
|
|
|
|
|
| |
to being an interface to finger(1), see -p flag. Remove a reference to
name(?) program we don't have.
Submitted by: wollman
|
|
|
|
|
|
|
|
| |
deleting symlinks pointing to directories.
PR: bin/37250
Submitted by: Nino Dehne <TeCeEm@gmx.de>
MFC after: 1 week
|
| |
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
o "struct addrinfo" contains a pointer to "struct sockaddr,"
not "struct sockaddr" itself
o the function takes a pointer to "struct in*_addr", not to
"struct sockaddr," so the address length must be corresponding
MFC after: 1 week
|
| |
|
|
|
|
|
|
|
| |
not to `for'. The previous indent was reather misleading for
the code reader.
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
by conventional one-way parsing of ftphosts(5).
Don't let NULL hostname pointers into virtual
host records as well.
PR: bin/18410
MFC after: 1 month
|
|
|
|
| |
Submitted by: Jean-Luc Richier <Jean-Luc.Richier@imag.fr>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thus lines of any length can be handled, unlike before.
Don't assume that each line read from the files ends with a newline.
As a side effect in inithosts(), don't use automatic buffer at all,
utilize malloc(3) when getting local host name instead.
PR: misc/21494
Reviewed by: maxim, mikeh
MFC after: 1 month
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
comsat:
only send two bell charecters if S_IXGRP is set and S_IXUSR is not.
biff:
add new option 'b' to set S_IXGRP.
PR: 10931
Submitted by: Andrew J. Korty <ajk@purdue.edu>
Approved by: sheldonh (mentor)
MFC after: 1 month
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They provided little benefit (if any) and they caused some problems
in OpenOffice, at least in post-KSE -current and perhaps in other
environments too. The nanosleep calls prevented the profiling timer
from advancing during the spinloops, thereby preventing the thread
scheduler from ever pre-empting the spinning thread. Alexander
Kabaev diagnosed this problem, Martin Blapp helped with testing,
and Matt Dillon provided some helpful suggestions.
This is a short-term fix for a larger problem. The use of spinlocking
isn't guaranteed to work in all cases. For example, if the spinning
thread has higher priority than all other threads, it may never be
pre-empted, and the thread holding the lock may never progress far
enough to release the lock. On the other hand, spinlocking is the
only locking that can work with an arbitrary unknown threads package.
I have some ideas for a much better fix in the longer term. It
would eliminate all locking inside the dynamic linker by making it
safe for symbol lookups and lazy binding to proceed in parallel
with a call to dlopen or dlclose. This means that the only mutual
exclusion needed would be to prevent multiple simultaneous calls
to dlopen and/or dlclose. That mutual exclusion could be put into
the native pthreads library. Applications using foreign threads
packages would have to make their own arrangements to ensure that
they did not have multiple threads in dlopen and/or dlclose -- a
reasonable requirement in my opinion.
MFC after: 3 days
|
| |
|
|
|
|
|
|
|
|
| |
to transfer a file.
PR: 39362
Submitted by: TANAKA Hiroyuki <kattyo@abk.nu>
MFC after: 1 week
|