summaryrefslogtreecommitdiffstats
path: root/lib/libthr
Commit message (Collapse)AuthorAgeFilesLines
* Make C applications statically compiled with libthr work. Previously,mtm2003-06-041-0/+6
| | | | | | an application compiled -static with libthr would dump core in malloc(3) because the stub thread initialization routine in libc would be used instead of the libthr supplied one.
* Teach recent changes in the umtx structure in the kernel to the libthrmtm2003-06-031-1/+1
| | | | | | initialiazer. Found by: tinderbox
* Unwind the _giant_mutex from pthread_detach(). When detaching a joiner threadmtm2003-06-021-8/+8
| | | | | it's important the correct lock order is observed: lock first the joined and then the joiner.
* Consolidate static_init() and static_init_private into one function.mtm2003-06-021-17/+11
| | | | The behaviour of this function is controlled by the argument: private.
* .S comments must be C comments, not ASM ones.obrien2003-06-021-1/+1
|
* I botched one of my committs in the last round. Fix it.mtm2003-05-312-12/+11
|
* Make the mutex static initializers look more like the one formtm2003-05-291-25/+19
| | | | | | | | | condition variables. Cosmetic. Explicitly compare against PTHREAD_MUTEX_INITIALIZER. We shouldn't encourage calls to the mutex functions with null pointers to mutexes. Approved by: re/jhb
* Use a static lock to ake sure pthread_cond_* functions calledmtm2003-05-291-2/+20
| | | | | | | | | | | | from multiple threads don't initialze the same condition variable more than once. Explicitly compare cond pointers with PTHREAD_COND_INITIALIZER instead of NULL. Just because it happens to be defined as NULL is no reason to encourage the idea that people can call those functions with NULL pointers to a condition variable. Approved by: re/jhb
* Missing unlock.mtm2003-05-291-0/+2
| | | | Approved by: re/jhb
* Don't hold the active thread list lock when signaling the gc thread.mtm2003-05-293-12/+21
| | | | | | | | | The dead list thread is sufficient for synchronization. Retire the arch_id (ldt array slot) in the gc thread instead of the doing it in the thread itself. Approved by: re/jhb
* It's unnecessary to lock the thread during creation. Simply extendmtm2003-05-291-5/+2
| | | | | | the scope of the active thread list lock. Approved by: re/jhb
* Minimize the potential for deadlocks between an exiting thread and it'smtm2003-05-271-2/+18
| | | | | | | | joiner by making sure all locks and unlocks occur in the same order. For the record the lock order is: DEAD_LIST, THREAD_LIST, exiting thread, joiner thread. Approved by: re/rwatson
* Revert part of the last commit. I don't know what I was smoking.mtm2003-05-271-2/+13
| | | | Approved by: re/rwatson
* Decouple the thread stack [de]allocating functions from the 'dead threads list'mtm2003-05-264-7/+16
| | | | | | | lock. It's not really necessary and we don't need the added complexity or potential for deadlocks. Approved by: re/blanket libthr
* Revise the unlock order in _pthread_join(). Also, if the joinedmtm2003-05-261-12/+6
| | | | | | | | thread is not dead, the join loop is guaranteed to execute at least once, so there is no need to pick up the thread list lock after we return from suspenstion only to release it after the loop. Approved by: re/blanket libthr
* Return gracefully, rather than aborting, when the maximum concurrentmtm2003-05-256-10/+27
| | | | | | threads per process has been reached. Return EAGAIN, as per spec. Approved by: re/blanket libthr
* _pthread_cancel() breaks the normal lock order of first locking themtm2003-05-253-4/+28
| | | | | | | | | | | | | joined and then the joiner thread. There isn't an easy (sane?) way to make it use the correct order without introducing races involving the target thread and finding which (active or dead) list it is on. So, after locking the canceled thread it will try to lock the joined thread and if it fails release the first lock and try again from the top. Introduce a new function, _spintrylock, which is simply a wrapper arround umtx_trylock(), to help accomplish this. Approved by: re/blanket libthr
* Part of the last patch.mtm2003-05-252-9/+9
| | | | | | | Modify the thread creation and thread searching routine to lock the thread lists with the new locks instead of GIANT_LOCK. Approved by: re/blanket libthr
* Start locking up the active and dead threads lists. The active threadsmtm2003-05-257-127/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | | list is protected by a spinlock_t, but the dead list uses a pthread_mutex because it is necessary to synchronize other threads with the garbage collector thread. Lock/Unlock macros are used so it's easier to make changes to the locks in the future. The 'dead thread list' lock is intended to replace the gc mutex. This doesn't have any practical ramifications. It simply makes it clearer what the purpose of the lock is. The gc will use this lock, instead of the gc mutex, to synchronize access to the dead list with other threads. Modify _pthread_exit() to use these two new locks instead of GIANT_LOCK, and also to properly lock and protect thread state changes, especially with respect to a joining thread. The gc thread was also re-arranged to be more organized and less nested. _pthread_join() was also modified to use the thread list locks. However, locking and unlocking here needs special care because a thread could find itself in a position where it's joining an exiting thread that is waiting on the dead list lock, which this thread (joiner) holds. If the joiner doesn't take care to lock *and* unlock in the same order they (the joiner and the joinee) could deadlock against each other. Approved by: re/blanket libthr
* The libthr code makes use of higher-level primitives (pthread_mutex_t andmtm2003-05-252-0/+14
| | | | | | | | | | | | | pthread_cond_t) internaly in addition to the low-level spinlock_t. The garbage collector mutex and condition variable are two such examples. This might lead to critical sections nested within critical sections. Implement a reference counting mechanism so that signals are masked only on the first entry and unmasked on the last exit. I'm not sure I like the idea of nested critical sections, but if the library is going to use the pthread primitives it might be necessary. Approved by: re/blanket libthr
* The struct mcontext has changed. It's using the register sets. Bringmarcel2003-05-251-1/+1
| | | | this in line.
* Lock the cond queue (condition variables):mtm2003-05-241-70/+43
| | | | | | | | | | | | | | | | Access to the thread's flags and state is protected by _thread_critical_enter/exit(). When a thread is signaled with a condition its state must be protected by locking it and disabling signals before it is taken of the waiters' queue. Move the implementation of pthread_cond_signal() and pthread_cond_broadcast() into one function, cond_signal(). Its behaviour is determined by the last argument, int broadcast. If this is set to 1 it will remove all waiters, otherwise it will wake up only the first waiter thread. Remove an extraneous call to pthread_testcancel(). Approved by: re/blanket libthr
* Add two functions: _spinlock_pthread() and _spinunlock_pthread()mtm2003-05-233-4/+20
| | | | | | | | | | that take the address of a struct pthread as their first argument. _spin[un]lock() just become wrappers arround these two functions. These new functions are for use in situations where curthread can't be used. One example is _thread_retire(), where we invalidate the array index curthread uses to get its pointer.. Approved by: re/blanket libthr
* EDOOFUSmtm2003-05-232-10/+3
| | | | | | | | Prevent one thread from messing up another thread's saved signal mask by saving it in struct pthread instead of leaving it as a global variable. D'oh! Approved by: re/blanket libthr
* Make WARNS2 clean. The fixes mostly included:mtm2003-05-2316-10/+41
| | | | | | | | o removed unused variables o explicit inclusion of header files o prototypes for externally defined functions Approved by: re/blanket libthr
* note to self: do not confuse void* with int.mtm2003-05-231-1/+1
| | | | Approved by: re/blanket libthr
* o Make the defenition of _set_curthread() match its declarationmtm2003-05-211-5/+27
| | | | | | | | | | | | in thr_private.h o Lock down the ldt_entries array and ldt_free, which points to the next free slot. As noted in the comments, it's necessary to special case the initial_thread because %gs is not setup for it yet. This is ok because that early in the program there won't be any reentrancy issues anyways. Approved by: re/blanket libthr
* Insert a debugging aid:mtm2003-05-212-2/+18
| | | | | | | | When in either the mutex or cond queue we notice that the thread is already on one of the queues, don't just simply abort(). Print out the thread's identifiers and what queue it was on. Approved by: markm/mentor, re/blanket libthr
* Re-enable the garbage collector thread in anticipation of furthermtm2003-05-211-2/+0
| | | | | | | locking work. I can't see anything obviously wrong with it (other than the need to update the locking). Approved by: markm/mentor, re/blanket libthr
* When a thread exits it does not return from the kernel unless itmtm2003-05-211-0/+4
| | | | | | | is the *only* remaining thread in the application, in which case we should not core dump, and instead exit gracefully. Approved by: markm/mentor, re/blanket libthr
* The thread id was being set *before* zeroing out the thread. Reversemtm2003-05-211-2/+3
| | | | | | the order. Approved by: markm/mentor, re/blanket libthr
* Move a misplaced comment.mtm2003-05-201-1/+1
| | | | Approved by: markm/mentor (implicit), re/blanket libthr
* Do some cleanup with respect to condition variables. The implementationmtm2003-05-151-15/+14
| | | | | | | | | | | | of pthread_cond_timedwait() is moved into cond_wait_common(). Pthread_cond_wait() and pthread_cond_timedwait() are now wrappers around this function. Previously, the former called the latter with the abstime pointing to 0 time. This violated Posix semantics should an application have reason to call it with that argument because instead or returning immediately it would have waited indefinitely for the cv to be signaled. Approved by: markm/mentor, re/blanket libthr Reviewed by: jeff
* o Make the setting/checking of cancel state atomic withmtm2003-05-151-87/+111
| | | | | | | | | | | | | | respect to other threads and signal handlers by moving to the _thread_critical_enter/exit functions. o Introduce an static function, testcancel(), that is used by the other functions in this module. This allows it to make locking assumptions that the top-level functions can't. o Rework the code flow a bit to reduce indentation levels. Approved by: markm/mentor, re/blanket libthr Reviewed by: jeff
* msg2mtm2003-05-121-7/+7
|
* msg1mtm2003-05-123-263/+181
|
* Fix a null dereference leading to a core dump whenmtm2003-05-061-1/+4
| | | | | | | | the number of threads exceeds the number of open slots in ldt_entries[]. Approved by: markm (mentor)(implicit) Reviewed by: jeff
* o Correct a debug message that refered to the wrong functionmtm2003-05-062-23/+20
| | | | | | | o Remove an unncecesary if clause Approved by: markm (mentor)(implicit) Reviewd by: jeff
* Add support for ia64.marcel2003-04-202-0/+64
| | | | | | | | | | | Note that the tp register (r13) is reserved as the TLS pointer in the same way that that gp register (r1) is reserved as the global pointer. This implementation uses the tp register to point to the thread structure used by the threads implementation. This is not in violation with the runtime specification provided the TLS is a fixed distance from the thread structure. This is only an issue when code used the __thread keyword to create TLS. This is not supported at the moment.
* Use STDERR_FILENO as the file descriptor passed to _thread_printf()marcel2003-04-201-4/+7
| | | | instead of 0 (ie stdin). Writing to stdin may not be possible.
* Fix build breakage (on ia64) caused by a missing file descriptor tomarcel2003-04-202-2/+2
| | | | _thread_printf(). Use STDERR_FILENO as the file descriptor.
* Add stub implementations of pthread_[gs]etconcurrency to libc_r andjdp2003-04-202-0/+61
| | | | | | | | | libthr. No changes were made to libpthread by request of deischen, who will soon commit a real implementation for that library. PR: standards/50848 Submitted by: Sergey A. Osokin <osa@freebsd.org.ru> MFC after: 1 week
* - Pass a ucontext_t to _set_curthread. If non-NULL the new thread is setjake2003-04-035-11/+18
| | | | | | | | as curthread in the new context, so that it will be set automatically when the thread is switched to. This fixes a race where we'd run for a little while with curthread unset in _thread_start. Reviewed by: jeff
* - Don't overrun the ldt buffer.jeff2003-04-021-2/+2
| | | | Submitted by: gordan@freebsd.org
* Implement _get_curthread and _set_curthread. This is especially easy.jake2003-04-022-0/+58
|
* - Define curthread as _get_curthread() and remove all direct calls tojeff2003-04-0220-96/+21
| | | | | | | _get_curthread(). This is similar to the kernel's curthread. Doing this saves stack overhead and is more convenient to the programmer. - Pass the pointer to the newly created thread to _thread_init(). - Remove _get_curthread_slow().
* Add MD makefile.jake2003-04-011-0/+3
|
* - Don't drop and reacquire giant in thread_suspend(). Change callers to dojeff2003-04-013-38/+8
| | | | | this manually. This will facilitate the unrolling of giant. - Don't allow giant to recurse anymore. This should never happen.
* - Reenable setschedparam and the prioceiling code now that the mutex codejeff2003-04-012-19/+10
| | | | has been restored.
* - Restore old mutex code from libc_r. It is more standards compliant.jeff2003-04-012-205/+1364
| | | | | | | This was changed because originally we were blocking on the umtx and allowing the kernel to do the queueing. It was decided that the lib should queue and start the threads in the order it decides and the umtx code would just be used like spinlocks.
OpenPOWER on IntegriCloud