| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Change the type and name of a variable introduced in 1.33.
|
| |
|
|
|
|
|
|
|
|
| |
the root cause of the bus errors I was experiencing.
Submitted by: fenner
Tested by: obrien
Prompted by: peter
|
|
|
|
|
| |
Revs 1.37-8 produce a bus error in some environments.
Revs 1.34-6 do not bus error, but write corrupted files.
|
| |
|
|
|
|
|
|
|
|
|
| |
_fetch_writev() to incorrectly report EPIPE in certain cases.
Also fix a number of const warnings by using __DECONST(), plus a signed /
unsigned comparison by casting the rhs to ssize_t.
Submitted by: fenner, Craig Rodrigues <rodrigc@attbi.com>
|
|
|
|
| |
Approved by: des
|
|
|
|
|
|
| |
error, only report an error if no data was read at all (unless len was
0 to start with). Otherwise, the final read of practically any transfer
will end in a fatal error.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the SSL case, it is no different from the old _fetch_write(), but in the
non-SSL case it uses writev(2) to send the entire vector as a single
packet (provided it can fit in one packet). Implement _fetch_write()
and _fetch_putln() in terms of _fetch_writev().
This should improve performance in the non-SSL case (by reducing protocol
overhead) and solve the problem where too-smart-for-their-own-good
firewalls reject FTP packets that do not end in CRLF.
PR: bin/44123
Submitted by: fenner
|
|
|
|
|
|
|
|
| |
not initialized before use, and _http_growbuf() did not return a value
on success.
Reported by: Peter Edwards <pmedwards@eircom.net>
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
symptoms: make timeouts and short transfers fatal, and set errno to an
appropriate value (ETIMEDOUT for a timeout, EPIPE for a short transfer).
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closed through _fetch_close() which is the only one who knows the connection
REALLY was closed (since ref -> 0). However, FTP keeps its own local
cached_connection and checks if it is valid by comparing it to NULL. This
is bogus since it may have been freed elsewhere by _fetch_close().
This change checks if we are closing the cached_connection and the ref is 1
(soon to be 0). If so, set cached_connection to NULL so we don't
accidentally reuse it. The REAL fix should be to move connection caching
to the common.c level (_fetch_* functions) and NULL the cache(s) in
_fetch_close(). Then all layers could benefit from caching.
|
| |
|
|
|
|
|
| |
the heap block does not get freed and reused. This should fix the
pkg_add -r crashes that have been happening for months.
|
| |
|
| |
|
|
|
|
|
| |
connection is broken), take this into account and return at this
point.
|
|
|
|
| |
Tell ftp that _fetch_connect() always sets the error code (http already knew)
|
|
|
|
|
| |
PR: misc/40399
MFC after: 3 days
|
|
|
|
|
|
|
| |
scope identifier).
Approved by: des
MFC after: 3 weeks
|
| |
|
| |
|
| |
|
|
|
|
| |
free a cached FTP connection.
|
| |
|
| |
|
|
|
|
|
| |
libfetch can't depend on lib{crypto,ssl}. Move the dependency to fetch
until we can figure out how to fix this.
|
|
|
|
| |
Submitted by: Henry Whincup <henry@techiebod.com> (in principle)
|
|
|
|
|
| |
(except for DNS operations). Always use funopen() for HTTP, to support
both timeouts and SSL.
|
| |
|
|
|
|
| |
cookie) and increase symmetry with equivalent FTP code.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
which contains the socket descriptor, the input buffer and (yet unused)
SSL state variables. This has the neat side effect of greatly improving
reentrance (though we're not *quite* there yet) and opening the door to
HTTP connection caching.
This commit is inspired by email conversations with and patches from
Henry Whincup <henry@techiebod.com> last fall.
|
|
|
|
|
|
| |
Also, make an internal _getprogname() that is used only inside
libc. For libc, getprogname(3) is a weak symbol in case a
function of the same name is defined in userland.
|
| |
|
| |
|
|
|
|
|
| |
ftp.c and http.c now have exceedingly long lines due to deep nesting;
this will be corrected by reorganizing the code in a later revision.
|
| |
|
|
|
|
|
|
|
| |
chunk.
PR: bin/33608
MFC after: 2 weeks
|
|
|
|
|
| |
PR: misc/34043
MFC after: 2 weeks
|
| |
|
|
|
|
|
|
|
| |
it of HTML tags and comments.
PR: bin/32989
MFC after: 1 week
|
|
|
|
|
|
|
| |
default.
PR: 32988
MFC after: 3 days
|
|
|
|
|
| |
PR: bin/32615
MFC after: 1 week
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
| |
debugging code if fetchDebug is set.
PR: bin/32615
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
Also fix a couple of not-so-minor bugs:
- missing case for HTTP_SEE_OTHER
- incorrect definition of HTTP_NEED_PROXY_AUTH
PR: 20259
MFC after: 2 weeks
|
| |
|
| |
|