| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Submitted by: Sandvine Incorporated
Reviewed by: des, emaste
Sponsored by: Sandvine Incorporated
MFC: 1 week
|
|
|
|
|
| |
Submitted by: Joerg Sonnenberger <joerg@britannica.bec.de>
MFC after: 2 weeks
|
|
|
|
|
|
| |
explaining why f cannot possibly be a valid FILE * at this point.
MFC after: 1 day
|
|
|
|
|
|
|
| |
way (not for the first time...)
Noticed by: bde, ru ++
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
lynx, curl etc. Note that this patch differs significantly from that
in the PR, as the submitter refined it after submitting the PR.
PR: 110388
Submitted by: Alexander Pohoyda <alexander.pohoyda@gmx.net>
MFC after: 3 weeks
|
|
|
|
|
|
| |
IWBNI gcc could warn about this the way it warns about printf() abuse.
MFC after: 1 week
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
| |
once (CWD a/b/c vs. 3 CWDs). If an error occurs, we fall back to the default
method of a single CWD per directory element. Since this is technically
a violation of the basic FTP RFC, this behavior is under a compile-time
option FTP_COMBINE_CWDS and is off by default. It should work with most
Unix-based FTP daemons and can save latency.
MFC after: 2 weeks
|
|
|
|
| |
PR: misc/98872
|
|
|
|
|
|
|
|
| |
to another, the first CWD after a string of CDUPs would incorrectly include
a slash before the directory name.
Reported by: obrien
PR: bin/83278
|
|
|
|
|
|
|
| |
ignore a MODE failure if and only if the mode we attempted to set was S
(which is supposed to be the default).
PR: bin/91973
|
|
|
|
|
|
|
| |
work in progress; it partially fixed bin/83278 and is a prerequisite to
fixing bin/83277.
PR: bin/83277, bin/83278
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
open) rather than 150 (opening connection). There's no reason why we
shouldn't accept that.
PR: misc/42172
MFC in: 3 days
|
|
|
|
| |
Approved by: des, markm (mentor)(implicit)
|
|
|
|
| |
functional difference, but debugging output will be less confusing.
|
|
|
|
| |
MFC after: 3 days
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closed through _fetch_close() which is the only one who knows the connection
REALLY was closed (since ref -> 0). However, FTP keeps its own local
cached_connection and checks if it is valid by comparing it to NULL. This
is bogus since it may have been freed elsewhere by _fetch_close().
This change checks if we are closing the cached_connection and the ref is 1
(soon to be 0). If so, set cached_connection to NULL so we don't
accidentally reuse it. The REAL fix should be to move connection caching
to the common.c level (_fetch_* functions) and NULL the cache(s) in
_fetch_close(). Then all layers could benefit from caching.
|
|
|
|
|
| |
the heap block does not get freed and reused. This should fix the
pkg_add -r crashes that have been happening for months.
|
|
|
|
| |
Tell ftp that _fetch_connect() always sets the error code (http already knew)
|
|
|
|
|
|
|
| |
scope identifier).
Approved by: des
MFC after: 3 weeks
|
|
|
|
| |
free a cached FTP connection.
|
|
|
|
|
| |
(except for DNS operations). Always use funopen() for HTTP, to support
both timeouts and SSL.
|
|
|
|
|
|
|
|
|
|
| |
which contains the socket descriptor, the input buffer and (yet unused)
SSL state variables. This has the neat side effect of greatly improving
reentrance (though we're not *quite* there yet) and opening the door to
HTTP connection caching.
This commit is inspired by email conversations with and patches from
Henry Whincup <henry@techiebod.com> last fall.
|
| |
|
|
|
|
|
| |
ftp.c and http.c now have exceedingly long lines due to deep nesting;
this will be corrected by reorganizing the code in a later revision.
|
|
|
|
|
| |
PR: misc/34043
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
default.
PR: 32988
MFC after: 3 days
|
| |
|
|
|
|
|
| |
ages - some of which wouldn't be necessary if gcc wasn't broken or TPTB were
willing to do something (-fno-builtin) about it.
|
| |
|
|
|
|
| |
MFC after: 2 weeks
|
|
|
|
| |
Spotted by: bde
|
|
|
|
| |
MFC after: 2 weeks
|
|
|
|
| |
fixes a bug in pkg_add(1) (which nobody noticed because of another bug).
|
| |
|
|
|
|
| |
PR: 27506
|
|
|
|
| |
Fix some other minor glitches.
|
|
|
|
| |
to -1 so the caller will know it's invalid. This is an MFC candidate.
|
|
|
|
| |
that forces the ftp code to use the low (default) port range instead.
|
| |
|
|
|
|
| |
PR: bin/25494
|
|
|
|
|
|
| |
Rather than have a separate (misnamed) FTP_ANONYMOUS_PASSWORD constant, use
FTP_ANONYMOUS_USER (i.e. "anonymous") to construct the anonymous ftp password
if getlogin() fails.
|
|
|
|
| |
FTP_ANONYMOUS_USER.
|
|
|
|
|
|
|
| |
and had libfetch selecting passive mode even when FTP_PASSIVE_MODE was not
set at all, which is really quite surprising unless you know about it. So
change it to the agreed default behaviour of selecting passive mode if
FTP_PASSIVE_MODE is set, but not "no".
|
|
|
|
| |
to HTTP if HTTP_PROXY was used instead.
|
|
|
|
| |
multiline response (proper fix this time).
|
| |
|