summaryrefslogtreecommitdiffstats
path: root/lib/libc/stdlib
Commit message (Collapse)AuthorAgeFilesLines
* Add .NOMETA missed in r291320.bdrewery2016-01-201-1/+1
| | | | Sponsored by: EMC / Isilon Storage Division
* Remove an unneeded assignment of the return value.ed2016-01-141-1/+0
| | | | | | | tdelete() is supposed to return the address of the parent node that has been deleted. We already keep track of this node in the loop between lines 94-107. The GO_LEFT()/GO_RIGHT() macros are used later on as well, so we must make sure not to change it to something else.
* Replace implementation of hsearch() by one that scales.ed2015-12-277-185/+335
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Traditionally the hcreate() function creates a hash table that uses chaining, using a fixed user-provided size. The problem with this approach is that this often either wastes memory (table too big) or yields bad performance (table too small). For applications it may not always be easy to estimate the right hash table size. A fixed number only increases performance compared to a linked list by a constant factor. This problem can be solved easily by dynamically resizing the hash table. If the size of the hash table is at least doubled, this has no negative on the running time complexity. If a dynamically sized hash table is used, we can also switch to using open addressing instead of chaining, which has the advantage of just using a single allocation for the entire table, instead of allocating many small objects. Finally, a problem with the existing implementation is that its deterministic algorithm for hashing makes it possible to come up with fixed patterns to trigger an excessive number of collisions. We can easily solve this by using FNV-1a as a hashing algorithm in combination with a randomly generated offset basis. Measurements have shown that this implementation is about 20-25% faster than the existing implementation (even if the existing implementation is given an excessive number of buckets). Though it allocates more memory through malloc() than the old implementation (between 4-8 pointers per used entry instead of 3), process memory use is similar to the old implementation as if the estimated size was underestimated by a factor 10. This is due to the fact that malloc() needs to perform less bookkeeping. Reviewed by: jilles, pfg Obtained from: https://github.com/NuxiNL/cloudlibc Differential Revision: https://reviews.freebsd.org/D4644
* Let tsearch()/tdelete() use an AVL tree.ed2015-12-224-86/+473
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing implementations of POSIX tsearch() and tdelete() don't attempt to perform any balancing at all. Testing reveals that inserting 100k nodes into a tree sequentially takes approximately one minute on my system. Though most other BSDs also don't use any balanced tree internally, C libraries like glibc and musl do provide better implementations. glibc uses a red-black tree and musl uses an AVL tree. Red-black trees have the advantage over AVL trees that they only require O(1) rotations after insertion and deletion, but have the disadvantage that the tree has a maximum depth of 2*log2(n) instead of 1.44*log2(n). My take is that it's better to focus on having a lower maximum depth, for the reason that in the case of tsearch() the invocation of the comparator likely dominates the running time. This change replaces the tsearch() and tdelete() functions by versions that create an AVL tree. Compared to musl's implementation, this version is different in two different ways: - We don't keep track of heights; just balances. This is sufficient. This has the advantage that it reduces the number of nodes that are being accessed. Storing heights requires us to also access all of the siblings along the path. - Don't use any recursion at all. We know that the tree cannot 2^64 elements in size, so the height of the tree can never be larger than 96. Use a 128-bit bitmask to keep track of the path that is computed. This allows us to iterate over the same path twice, meaning we can apply rotations from top to bottom. Inserting 100k nodes into a tree now only takes 0.015 seconds. Insertion seems to be twice as fast as glibc, whereas deletion has about the same performance. Unlike glibc, it uses a fixed amount of memory. I also experimented with both recursive and iterative bottom-up implementations of the same algorithm. This iterative top-down version performs similar to the recursive bottom-up version in terms of speed and code size. For some reason, the iterative bottom-up algorithm was actually 30% faster for deletion, but has a quadratic memory complexity to keep track of all the parent pointers. Reviewed by: jilles Obtained from: https://github.com/NuxiNL/cloudlibc Differential Revision: https://reviews.freebsd.org/D4412
* META MODE: Don't create .meta files when symlinking sources into the obj ↵bdrewery2015-11-251-4/+4
| | | | | | | | | | | directory. Tracking these leads to situations where meta mode will consider the file to be out of date if /bin/sh or /bin/ln are newer than the source file. There's no reason for meta mode to do this as make is already handling the rebuild dependency fine. Sponsored by: EMC / Isilon Storage Division
* Use ANSI C prototypes. Eliminates -Wold-style-definition warnings.rodrigc2015-09-2012-51/+28
|
* Remove names from prototypesrodrigc2015-09-203-7/+7
|
* Add declarations to eliminate -Wmissing-prototypes warnings.rodrigc2015-09-203-0/+15
|
* Use ANSI C prototypes.rodrigc2015-09-143-45/+14
| | | | Eliminates gcc 4.9 warnings.
* Switch libc from using _sig{procmask,action,suspend} symbols, whichkib2015-08-292-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | are aliases for the syscall stubs and are plt-interposed, to the libc-private aliases of internally interposed sigprocmask() etc. Since e.g. _sigaction is not interposed by libthr, calling signal() removes thr_sighandler() from the handler slot etc. The result was breaking signal semantic and rtld locking. The added __libc_sigprocmask and other symbols are hidden, they are not exported and cannot be called through PLT. The setjmp/longjmp functions for x86 were changed to use direct calls, and since PIC_PROLOGUE only needed for functional PLT indirection on i386, it is removed as well. The PowerPC bug of calling the syscall directly in the setjmp/longjmp implementation is kept as is. Reported by: Pete French <petefrench@ingresso.co.uk> Tested by: Michiel Boland <boland37@xs4all.nl> Reviewed by: jilles (previous version) Sponsored by: The FreeBSD Foundation MFC after: 1 week
* Add missing sdallocx updates and remove *allocm manpage links.jasone2015-08-182-5/+6
| | | | Submitted by: jbeich
* Update jemalloc to version 4.0.0.jasone2015-08-181-1/+2
|
* Document the fact that system(3) can easily be misused due to shell metadelphij2015-07-251-2/+14
| | | | | | | characters are honored. While I'm there also mention posix_spawn in the SEE ALSO section. MFC after: 2 weeks
* Fix major copy/paste and other style errors.pluknet2015-05-051-5/+10
|
* Apply the copyright the the same owners as the original malloc(3) where most ofbapt2015-05-011-2/+3
| | | | | | | | the text here comes from Reported by: many Discussed with: miod@OpenBSD.org Pointyhat to: bapt
* Import reallocarray(3) from OpenBSDbapt2015-05-014-2/+182
| | | | | | | | | Add a manpage for it, assign the copyright to the OpenBSD project on it since it is mostly copy/paste from OpenBSD manpage. style(9) fixes Differential Revision: https://reviews.freebsd.org/D2420 Reviewed by: kib
* qsort(3): small style(9) cleanups.pfg2015-03-051-10/+10
| | | | | Basically spaces vs. tabs. No functional change.
* qsort(3): enhance to handle 32-bit aligned data on 64-bit systemspfg2015-03-051-12/+21
| | | | | | | | | | | | | | Implement a small enhancement to the original qsort implementation: If the data is 32 bit aligned we can side-step the long type version and use int instead. The change brings a modest but significant improvement in 32 bit workloads. Relnotes: yes PR: 135718 Taken from: ache
* Adjust wording slightly to emphasize that random(3) should not be used forcperciva2015-02-251-3/+2
| | | | | | | | any applications which need unpredictable random numbers, not merely those which are cryptographic in nature. If you work for a lottery and you're using random(3) to select the winning numbers, please let me know.
* Update comment and NetBSD ID tag.pfg2015-02-061-3/+3
| | | | | The NetBSD revisions correspond to changes we have already done like __P() removal and ANSI-fication of definitions.
* tdelete(3): don't delete the node we are about to return.pfg2015-02-051-1/+2
| | | | | | CID: 272528 Obtained from: NetBSD (CVS rev. 1.4) MFC after: 2 weeks
* Fix known issues which blow up the process after dlopen("libthr.so")kib2015-01-033-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (or loading a dso linked to libthr.so into process which was not linked against threading library). - Remove libthr interposers of the libc functions, including __error(). Instead, functions calls are indirected through the interposing table, similar to how pthread stubs in libc are already done. Libc by default points either to syscall trampolines or to existing libc implementations. On libthr load, libthr rewrites the pointers to the cancellable implementations already in libthr. The interposition table is separate from pthreads stubs indirection table to not pull pthreads stubs into static binaries. - Postpone the malloc(3) internal mutexes initialization until libthr is loaded. This avoids recursion between calloc(3) and static pthread_mutex_t initialization. - Reinstall signal handlers with wrapper on libthr load. The _rtld_is_dlopened(3) is used to avoid useless calls to sigaction(2) when libthr is statically referenced from the main binary. In the process, fix openat(2), swapcontext(2) and setcontext(2) interposing. The libc symbols were exported at different versions than libthr interposers. Export both libc and libthr versions from libc now, with default set to the higher version from libthr. Remove unused and disconnected swapcontext(3) userspace implementation from libc/gen. No objections from: deischen Tested by: pho, antoine (exp-run) (previous versions) Sponsored by: The FreeBSD Foundation MFC after: 1 week
* Various mdoc fixes and a few EOL whitespace removals.brueffer2014-12-212-3/+3
| | | | Found with: mandoc -Tlint
* Fix quick_exit(3) manual page to match reality - the status was missing.trasz2014-12-131-2/+2
| | | | | MFC after: 1 month Sponsored by: The FreeBSD Foundation
* Use the __DECONST macro rather than hand rolling the same thing.brooks2014-10-241-5/+1
| | | | Sponsored by: DARPA, AFRL
* Add bsearch_b to the libc map and the stdlib header.pfg2014-09-011-0/+1
| | | | | | | | | | | | bsearch_b is the Apple blocks enabled version of bsearch(3). This was added to libc in Revision 264042 but the commit missed the declaration required to make use of it. While here move some other block-related functions to the BSD_VISIBLE block as these are non-standard. Phabric: D638 Reviewed by: theraven, wollman
* Minor style tweaks.pfg2014-08-131-7/+7
| | | | | Obtained from: OpenBSD (CVS rev. 1.7) MFC after: 3 days
* Fix hdestroy() compliance issue.pfg2014-07-211-1/+0
| | | | | | | | | | | | | | | | | | | The hcreate(3) implementation and related functions we inherited from NetBSD used to free() the key value, something that is not supported by the standard implementation. This would cause a segmentation fault when attempting to run the examples from the opengroup and linux manpages. NetBSD has added non-standard calls to provide the previous behaviour but hdestroy is not very commonly used so at this time it seems excessive to bring those to FreeBSD. Bump the __FreeBSD_version as this is an ABI change. Reference: http://bugs.dragonflybsd.org/issues/1398 MFC after: 2 weeks
* Update license.pfg2014-07-211-7/+2
| | | | | | NetBSD has removed the advertisement clause from this file. Obtained from: NetBSD (CVS rev. 1,8)
* Add re-entrant versions of the hash functions based on the GNU api.pfg2014-07-214-41/+153
| | | | | | | While testing this I found a conformance issue in hdestroy() that will be fixed in a subsequent commit. Obtained from: NetBSD (hcreate.c, CVS Rev. 1.7)
* libc/stdlib: Minor cleanups to code originating in NetBSDpfg2014-07-153-22/+14
| | | | | | | Mostly ANSIfication and typos. Obtained from: NetBSD MFC after: 5 days
* strfmon: reduce unnecessary snprintf.pfg2014-07-121-5/+3
| | | | | | | No need for the snprintf/asprintf dance; use fixed width formats. Obtained from: NetBSD (CVS rev. 1.8) MFC after: 1 week
* [mdoc] Fix previous change.pluknet2014-07-081-1/+1
|
* getopt(3): clarify GNU instead of NetBSD.pfg2014-07-041-1/+1
| | | | | | | | The manpage and the code for r267745 came from NetBSD but the option is inspired on GNU. Reported by: Ben Kaduk MFC after: 3 days
* use .Mt to mark up email addresses consistently (part4)bapt2014-06-232-3/+3
| | | | | PR: 191174 Submitted by: Franco Fichtner <franco at lastsummer.de>
* Merge intermediate OpenBSD v1.25 changes (almost identical to ours)ache2014-06-221-18/+12
| | | | | | to reduce diff and bump OpenBSD patch level to v1.26. MFC after: 2 weeks
* getopt(3): recognize option:: as GNU extension for "optional options".pfg2014-06-223-8/+22
| | | | | | | | | | Also ANSIfy a function declaration. While here update the OpenBSD patch level in getopt_long.c as we already have the corresponding change. Obtained from: NetBSD MFC after: 2 weeks
* realpath(): Properly fail "." or ".." components after non-directories.jilles2014-04-131-20/+6
| | | | | | | | | | | | | If realpath() is called on pathnames like "/dev/null/." or "/dev/null/..", it should fail with [ENOTDIR]. Pathnames like "/dev/null/" already failed as they should. Also, put the check for non-directories after lstatting the previous component instead of when the empty component (consecutive or trailing slashes) is detected, saving an lstat() call and some lines of code. PR: kern/82980 MFC after: 2 weeks
* Silence a warning with GCC that was breaking the build with Juniper's GCC.theraven2014-04-053-4/+7
| | | | Reviewed by: marcel
* Move _b functions into the 11.x symbol version namespace.theraven2014-04-031-4/+7
|
* Add support for some block functions that come from OS X. These aretheraven2014-04-0212-29/+264
| | | | | | | intended to build with any C compiler. Reviewed by: pfg MFC after: 3 weeks
* Replace use of ${.CURDIR} by ${LIBC_SRCTOP} and define ${LIBC_SRCTOP}marcel2014-03-042-8/+8
| | | | | | | | | | | if not already defined. This allows building libc from outside of lib/libc using a reach-over makefile. A typical use-case is to build a standard ILP32 version and a COMPAT32 version in a single iteration by building the COMPAT32 version using a reach-over makefile. Obtained from: Juniper Networks, Inc.
* Update jemalloc to version 3.5.0.jasone2014-01-232-1/+19
|
* ANSI-fy prototype.delphij2014-01-141-3/+1
| | | | MFC after: 2 weeks
* getopt_long.3: wording quibbleseadler2013-12-131-2/+2
| | | | | | | - Make wording more clear: "is expect" vs "is expected" [1] - Remove extraneous trailing period.. Reported by: dim [1]
* Do not force to run atexit handlers, which text comes from a dsokib2013-12-061-5/+10
| | | | | | | | | | | | | | | | | owning the handle passed to __cxa_finalize() but which are registered by other dso, when the process is inside exit(3). Running them makes the destruction order wrong, and there is hope that such destructors would not call dlclose(3), since it is pointless at this stage of the process existence. The change effectively disables the r211706 after the exit(3) is called. Reported and tested by: Michael Gmelin <freebsd@grem.de> Analyzed by: dim Sponsored by: The FreeBSD Foundation MFC after: 1 week
* system(): Restore behaviour for SIGINT and SIGQUIT.jilles2013-09-011-0/+2
| | | | | | | | | | | | As mentioned in r16117 and the book "Advanced Programming in the Unix Environment" by W. Richard Stevens, we should ignore SIGINT and SIGQUIT before forking, since it is not guaranteed that the parent process starts running soon enough. To avoid calling sigaction() in the vforked child, instead block SIGINT and SIGQUIT before vfork() and keep the sigaction() to ignore after vfork(). The FreeBSD kernel discards ignored signals, even if they are blocked; therefore, it is not necessary to unblock SIGINT and SIGQUIT earlier.
* Make example more correct (errstr is a pointer, not boolean).pjd2013-08-181-1/+1
|
* vfork(2) was listed as deprecated in 1994 (r1573) and was the falsepeter2013-08-131-19/+19
| | | | | | | | | | | reports of its impending demise were removed in 2009 (r199257). However, in 1996 (r16117) system(3) was switched from vfork(2) to fork(2) based partly on this. Switch back to vfork(2). This has a dramatic effect in cases of extreme mmap use - such as excessive abuse (500+) of shared libraries. popen(3) has used vfork(2) for a while. vfork(2) isn't going anywhere.
* [fix to r253380] __setenv: be explicit about placing '=' after nameavg2013-07-171-2/+1
| | | | | | | | | | This should a regression introduced in r253380 if malloc'ed memory happens to have '=' at the right place. Reported by: ache Pointyhat to: me (avg) MFC after: 1 day X-MFC with: r253380
OpenPOWER on IntegriCloud