| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
r315641:
bsnmp: don't leak snmp_client.fd in open_client_udp(..) on connect(2) failure
r315642:
bsnmp: explicitly test the return value for open_client_{local,udp} in snmp_open(..)
open_client_* returns -1 on failure; 0 on success. Ensure that the return value is
0 -- otherwise exit snmp_open(..).
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use calloc instead of malloc with buffers in snmp_{recv,send}_packet
This doesn't fix the issue noted in the PR, but at the very least it
cleans up the error so it looks a bit more sane, and in the event
that bsnmp did wander off into the weeds, the likelihood of it
crashing with more sensible output is greater, in my opinion
MFC counter set high so I have enough time to resolve the real
underlying bug in bsnmpwalk
PR: 215721
|
| |
|
|
|
|
| |
snmp_table_fetch_async: don't leak `work` if snmp_pdu_send(..) fails
CID: 1017276
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Prevent improper memory accesses after calling snmp_pdu_free and snmp_value_free
snmp_pdu_free: set pdu->nbindings to 0 to limit the damage that
could happen if a pdu was reused after calling the function, and
as both stack and heap allocation types are used in contrib/bsnmp
and usr.sbin/bsnmpd.
snmp_value_free: NULL out value->v.octetstring.octets after calling
free on it to prevent a double-free from occurring.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Be more strict about IpAddress type in snmp_value_parse(..)
- Use inet_pton with AF_INET instead of doing longhand with sscanf.
- Use gethostbyname2 with AF_INET to ensure that the hostname isn't
accidentally parsed with another address family, e.g. AF_INET6.
NB: IpAddress per RFC-2578 is IPv4 only. Work is in progress to add
the InetAddress type and friends documented in RFC-4001 and
elsewhere (which supports IPv4, IPv6, and more).
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r310931:
Use strdup in snmp_parse_server(..) when possible instead of malloc+strcpy
This simplifies the code and mutes a Coverity warning about sc->cport being
improperly allocated
CID: 1018247
r310942:
Unbreak the build by passing the string to strdup, not its length
Pointyhat to: ngie
r310988:
snmp_discover_engine: fix up req/resp (PDU object) handling a bit
- Call snmp_pdu_free on req and resp when done with the objects
- Call snmp_pdu_free on req before calling snmp_pdu_create on it
again
|
| |
|
|
|
|
| |
MFC r311003:
Fix spelling errors; bump .Dd for the change
|
| |
|
|
|
|
| |
MFC r311001:
Bump .Dd for the spelling and .Nm updates
|
| |
|
|
|
|
|
|
|
|
|
|
| |
MFC r310099,r311000,r311002:
r311000:
Fix spelling errors
r311002:
Install bsnmpclient(3) as snmp_client_{init,set_host,set_port}(3)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MFC r310500,r310660:
r310500:
Minor style(9) fixes
- Trailing whitespace cleanup
- Sort variables in snmp_dialog(..) by alignment
No functional change
r310660:
style(9): fix whitespace in pdu_encode_secparams(..)
|
| |
|
|
|
|
| |
MFC r310648:
style(9): clean up trailing whitespace
|
| |
|
|
|
|
|
|
| |
MFC r310499:
Sort #includes
No functional change
|
| |
|
|
|
|
|
|
| |
MFC r310202:
Clean up trailing and leading whitespace
Fix variable type alignment in snmp_dialog(..)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r256678 (by syrinx):
Fix SNMP Error response PDUs and properly encode them when using v3 auth/encryption.
r256680 (by syrinx):
Fix the -Wconversion warnings produced when compiling the SNMP agent.
r260986 (by harti):
Fix a problem with OBJECT IDENTIFIER encoding: need to check the
second subid to be less than 40, not the first when the first
subid is 0 or 1.
r272878 (by syrinx):
Fix a bug in decoding string indexes in snmp_target(3), thus causing
bsnmpd(1) to not send v3 notifications properly; while here add two
missing return statements which could lead to abort() in case of a
rollback
r286402 (by araujo):
Fix variable 'old' is used uninitialized whenever '&&' condition is false.
Spotted by clang.
|
| |
|
|
|
|
|
| |
Fix the function signatures when MK_CRYPT == no for snmp_get_local_keys and
snmp_passwd_to_keys
Reported by: Beeblebrox <zaphod@berentweb.com>
|
| |
|
|
|
|
|
|
|
| |
Fix bsnmpd remote denial of service vulnerability.
Reported by: dinoex
Submitted by: harti
Security: FreeBSD-SA-14:01.bsnmpd
Security: CVE-2014-1452
|
| |
|
|
|
| |
Submitted by: Christoph Mallon
MFC after: 3 days
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Sponsored by: The FreeBSD Foundation
Reviewed by: philip
Approved by: philip
|
| |
|
|
|
|
|
| |
unsed parameters.
Sponsored by: The FreeBSD Foundation
Reviewed by: philip@
|
| |
|
|
|
|
| |
Sponsored by: The FreeBSD Foundation
Reviewed by: philip@ (mostly)
Approved by: philip@
|
| |
|
|
|
|
|
|
| |
message authentication, packet encryption & view-based access control (RFC 3412, 3414, 3415).
Sponsored by: The FreeBSD Foundation
Reviewed by: philip@ (mostly)
Approved by: philip@
|
| |
|
|
|
|
| |
No change in rendered output, less mandoc lint warnings.
Tool provided by: Nobuyuki Koganemaru n-kogane at syd.odn.ne.jp
|
| |
|
|
|
| |
Reviewed by: ru
Approved by: harti
|
| |\
| |
| |
| | |
which included commits to RCS files with non-trunk default branches.
|
| | | |
|
| |\ \
| |/
| |
| | |
which included commits to RCS files with non-trunk default branches.
|
| | |
| |
| |
| |
| | |
for U?INT32_{MAX,MIN} from asn1.h into the .c files that actually require
them (the .h file doesn't refer to these macros).
|
| |/
|
|
| |
previous import.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
