summaryrefslogtreecommitdiffstats
path: root/bin
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix CID 1011370 (Resource leak) in ps.truckman2016-05-252-8/+11
| | | | | | | | | | | | | There is no need to to call strdup() on the value returned by fmt(). The latter calls fmt_argv() which always returns a dynamically allocated string, and calling strdup() on that leaks the memory allocated by fmt_argv(). Wave some const magic on ki_args and ki_env to make the direct assignment happy. This requires a tweak to the asprintf() case to avoid a const vs. non-const mismatch. Reported by: Coverity CID: 1011370 MFC after: 1 week
* Close from_fd if malloc() fails to avoid a file descriptor leak.truckman2016-05-251-0/+1
| | | | | | Reported by: Coverity CID: 1007203 MFC after: 1 week
* Match the descriptions of the \H and \h prompt string sequences to reality.truckman2016-05-251-3/+3
| | | | | | | They were swapped. X-Confirmed by: jilles MFC after: 1 week
* Hopefully fix Coverity CID 1008328 (Out-of-bounds write) in /bin/sh.truckman2016-05-231-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the magic constant 127 in the loop interation count with "PROMPTLEN - 1". gethostname() is not guaranteed to NUL terminate the destination string if it is too short. Decrease the length passed to gethostname() by one, and add a NUL at the end of the buffer to make sure the following loop to find the end of the name properly terminates. The default: case is the likely cause of Coverity CID 1008328. If i is 126 at the top of the loop interation where the default case is triggered, i will be incremented to 127 by the default case, then incremented to 128 at the top of the loop before being compared to 127 (PROMPTLENT - 1) and terminating the loop. Then the NUL termination code after the loop will write to ps[128]. Fix by checking for overflow before incrementing the index and storing the second character in the buffer. These fixes are not guaranteed to satisfy Coverity. The code that increments i in the 'h'/'H' and 'w'/'W' cases may be beyond its capability to analyze, but the code appears to be safe. Reported by: Coverity CID: 1008328 Reviewed by: jilles, cem MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D6482
* ed(1): simplify by using arc4random_buf().pfg2016-05-211-4/+1
| | | | Suggested by: ed
* ed(1): Cleanups for the DES mode.pfg2016-05-201-2/+2
| | | | | | | | | - Use arc4random_uniform(3). - Prevent a segmentation fault when ed receives a signal while being in getpass(). [1] Obtained from: OpenBSD [1] (CVS Rev. 1.15) MFC after: 2 weeks
* Rename getline with get_line to avoid collision with getline(3)bapt2016-05-101-14/+14
| | | | | | | When getline(3) in 2009 was added a _WITH_GETLINE guard has also been added. This rename is made in preparation for the removal of this guard Obtained from: NetBSD
* DIRDEPS_BUILD: Run the staged bootstrap-tools version of build-tools.bdrewery2016-05-092-3/+3
| | | | | | This avoids running target binaries. Sponsored by: EMC / Isilon Storage Division
* Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedngie2016-05-0419-526/+451
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | after r298107 Summary of changes: - Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed - Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc - Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously. - Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk - Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk. - Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo - Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup) Document the proposed changes in share/examples/tests/tests/... via examples so it's clear that ${PACKAGES}FILES is the suggested way forward in terms of replacing FILES. share/mk/bsd.README didn't seem like the appropriate method of communicating that info. MFC after: never probably X-MFC with: r298107 PR: 209114 Relnotes: yes Tested with: buildworld, installworld, checkworld; buildworld, packageworld Sponsored by: EMC / Isilon Storage Division
* sh: Handle empty hostname and $PWD when building promptvangyzen2016-05-041-2/+3
| | | | | | | | | | | If the hostname is empty and \h is used in $PS1, the remainder of the prompt following \h will be empty. Likewise for $PWD and \w. Fix it. Reviewed by: jilles MFC after: 1 week Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D6188
* Fix including Kyuafile in packaged base system.gjb2016-04-291-1/+2
| | | | | | | | | | | | Fix a related typo while here. Note, this change results in the Kyuafile inclusion in the runtime package, which needs to be fixed, however addresses the PR as far as I can tell in my tests. PR: 209114 Submitted by: ngie Sponsored by: The FreeBSD Foundation
* ed(1): switch two statements so we check the index before dereferencing.pfg2016-04-261-1/+1
| | | | | | This is related to r270256 but was missed in that occasion. MFC after: 3 days
* Stop using sbrk in csh. This is a legacy interface and its use within cshandrew2016-04-261-1/+1
| | | | | | | is invalid. It is used to find the size of allocated memory. As malloc may allocate memory with mmap it will fail to take this memory into account. Obtained from: brooks
* Use NULL instead of 0 for pointers.araujo2016-04-191-1/+1
| | | | | | kvm_open(3) will return NULL when it cannot access kernel virtual memory. MFC after: 2 weeks.
* Use NULL for pointers instead of 0.araujo2016-04-191-1/+1
| | | | MFC after: 2 weeks.
* sh: Write LINENO value to stack string directly.jilles2016-04-161-4/+6
|
* MFHgjb2016-04-163-7/+5
|\ | | | | | | Sponsored by: The FreeBSD Foundation
| * META_MODE: Don't rebuild build-tools targets during normal build.bdrewery2016-04-142-4/+4
| | | | | | | | | | | | | | | | | | This avoids 'build command changed' due to CFLAGS/CC changes during the normal build. Without this the build-tools targets end up rebuilding for the *target* rather than keeping the native versions built in build-tools. Sponsored by: EMC / Isilon Storage Division
| * sh: Simplify code by removing variable bracketed_name.jilles2016-04-131-3/+1
| |
| * rcp(1): replace 0 with NULL for pointers.pfg2016-04-111-1/+1
| | | | | | | | Found with devel/coccinelle.
* | MFHgjb2016-04-121-1/+1
| | | | | | | | Sponsored by: The FreeBSD Foundation
* | MFHgjb2016-04-116-11/+11
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * sh(1): replace 0 with NULL for pointers.pfg2016-04-092-2/+2
| | | | | | | | | | | | Found with devel/coccinelle. Reviewed by: jilles
| * sh: Fix some unquoted variables in tests.jilles2016-04-093-7/+7
| | | | | | | | | | The builtins/getopts1.0 test failed if a single-character file existed in the current directory.
| * Revert r296416 by removing SAVESIGVEC and switching to fork instead. Thismp2016-04-071-2/+2
| | | | | | | | | | | | | | | | fixes usage with system libraries which maintain their own signal state. PR: 208132 Obtained from: kib MFC after: 3 days
* | MFHgjb2016-04-045-4/+17
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * sh: Fix use-after-free if a trap replaces itself.jilles2016-03-283-1/+15
| | | | | | | | MFC after: 1 week
| * Fix bunch of .Xrs.trasz2016-03-281-2/+1
| | | | | | | | | | MFC after: 1 month Sponsored by: The FreeBSD Foundation
| * CCACHE_BUILD: Don't use ccache when generating some files with CC -E.bdrewery2016-03-241-1/+1
| | | | | | | | | | | | | | At least for ncurses this fixes a build error due to it trying to run 'ccache --version' to work around a gcc 5 bug using the fix in r287205. Sponsored by: EMC / Isilon Storage Division
* | MFHgjb2016-03-143-2/+12
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * sh: Fix copying uninitialized field 'special'.jilles2016-03-131-0/+5
| | | | | | | | | | | | | | This just copied uninitialized data and did not depend on it later, so it should not be dangerous. Found by: clang static analyzer
| * Fix handling of umtxp resource limit in sh(1)/ulimit(1), limits(1), addkib2016-03-122-2/+7
| | | | | | | | | | | | | | | | login.conf(5) support. Reviewed by: jilles Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D5610
* | MFHgjb2016-03-1022-3/+217
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * DIRDEPS_BUILD: Connect MK_TESTS.bdrewery2016-03-0919-0/+209
| | | | | | | | Sponsored by: EMC / Isilon Storage Division
| * sh: Add test for 'set -o nolog'.jilles2016-03-092-0/+5
| | | | | | | | | | The option does not do anything so check that the output of 'set +o' is different.
| * sh: Avoid out-of-bounds access in setoptionbyindex() for 'set -o nolog'.jilles2016-03-091-3/+3
| | | | | | | | Reported by: hrs
* | MFHgjb2016-03-072-3/+2
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * sh: Fix some dead stores.jilles2016-03-062-3/+2
| | | | | | | | Found by: clang static analyzer
* | MFHgjb2016-03-061-0/+1
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * Signal handling within tcsh vfork code path will conflict with some systemmp2016-03-051-0/+1
| | | | | | | | | | | | | | | | | | libraries (such as libthr) which maintain their own signal state. This change adds the tcsh SAVESIGVEC option to save and restore the sigvecs for the signals the child modifies before it execs. Reviewed by: kib, rwatson Reported by: kib
| * sh: Remove a redundant STPUTC check.jilles2016-03-021-1/+1
| |
| * sh: Don't trust that signal descriptions fit within 49 bytes.jilles2016-03-021-18/+18
| |
* | MFHgjb2016-03-022-19/+19
| | | | | | | | Sponsored by: The FreeBSD Foundation
* | MFHgjb2016-03-0211-328/+64
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * dump(1) -> dump(8).trasz2016-02-291-1/+1
| | | | | | | | | | MFC after: 1 month Sponsored by: The FreeBSD Foundation
| * Implement process-shared locks support for libthr.so.3, withoutkib2016-02-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | breaking the ABI. Special value is stored in the lock pointer to indicate shared lock, and offline page in the shared memory is allocated to store the actual lock. Reviewed by: vangyzen (previous version) Discussed with: deischen, emaste, jhb, rwatson, Martin Simmons <martin@lispworks.com> Tested by: pho Sponsored by: The FreeBSD Foundation
| * Add speed limit to dd(1). This is useful for testing RCTL disk io limitstrasz2016-02-285-7/+60
| | | | | | | | | | | | | | | | | | (when they actually get committed, that is), and might also come in handy in other situations. Reviewed by: wblock@ (man page) MFC after: 1 month Sponsored by: The FreeBSD Foundation
| * DIRDEPS_BUILD: Regenerate without local dependencies.bdrewery2016-02-244-320/+0
| | | | | | | | | | | | | | | | These are no longer needed after the recent 'beforebuild: depend' changes and hooking DIRDEPS_BUILD into a subset of FAST_DEPEND which supports skipping 'make depend'. Sponsored by: EMC / Isilon Storage Division
* | MFHgjb2016-02-244-1/+16
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * sh: Fix set -v and multiline history after r295825.jilles2016-02-234-1/+16
| | | | | | | | | | | | | | r295825 erroneously dropped the newline from the input data for 'set -v' output and multiline history. Reported by: vangyzen
OpenPOWER on IntegriCloud