| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fix in r300649 was not sufficient to convince Coverity that the
buffer was NUL terminated, even with the buffer pre-zeroed. Swap
the size and nmemb arguments to fread() so that a valid lenght is
returned, which we can use to terminate the string in the buffer
at the correct location. This should also quiet the complaint about
the return value of fread() not being checked.
Reported by: Coverity
CID: 1019054, 1009614
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
Increase the size of buf[] by one to allow room for a NUL character
at the end.
Reported by: Coverity
CID: 1019054
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
Note: tcsh(1) has a MK_TCSH=no test, so this should be a separate
package, which requires pre-install/post-install scripts, to be
added later.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
that's long gone.
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Submitted by: sef
Reviewed by: trasz
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D3540
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Off by default, build behaves normally.
WITH_META_MODE we get auto objdir creation, the ability to
start build from anywhere in the tree.
Still need to add real targets under targets/ to build packages.
Differential Revision: D2796
Reviewed by: brooks imp
|
| | |
|
| |\
| |/
|/| |
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| | | | |
| | \ | |
| |\ \ \ |
|
| | |/ /
| |/| |
| | | |
| | | | |
Requested by: Simon Gerraty <sjg@juniper.net>
|
| |_|/
|/| |
| | |
| | |
| | | |
PR: 191174
Submitted by: Franco Fichtner <franco@lastsummer.de>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
are always permitted for the file owner.
PR: kern/174948
MFC after: 1 week
|
| | |
| | |
| | |
| | |
| | |
| | | |
means delete_child, not delete.
MFC after: 1 week
|
| | |
| | |
| | |
| | |
| | | |
Submitted by: scottl
MFC after: 1 week
|
| |/
|/|
| |
| |
| |
| | |
one should really use -a and -x instead of -m.
MFC after: 1 week
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This self-written compiler warning, which is hopefully going to be
committed into LLVM sources soon, warns about potentially missing
`static' keywords, similar to -Wmissing-prototypes.
- bin/pax: Move external declaration of chdname and s_mask into extern.h.
- bin/setfacl: Move setfacl.c-specific stuff out of setfacl.h.
- sbin/mount_fusefs: Remove char *progname; use getprogname().
- others: add `static' where possible.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
# setfacl -m u:trasz:rwx x
# setfacl -m u:root:rwx x
# getfacl x
# file: x
# owner: root
# group: wheel
user::rw-
user:root:rwx
user:trasz:rwx
group::r--
mask::rwx
other::r--
# setfacl -m u:root:rwx x
setfacl: x: acl_calc_mask() failed: Invalid argument
setfacl: x: failed to set ACL mask
For NFSv4 ACLs, this sort of situation would result in duplicated
entries.
MFC after: 1 month
|
| |
| |
| |
| |
| |
| |
| | |
on assert.
PR: bin/165807
MFC after: 1 month
|
| |
| |
| |
| | |
MFC after: 1 month
|
|/
|
|
|
|
|
| |
should be "s", not "S".
PR: docs/162380
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
Disussed with: gavin
No objection from: doc
Approved by: joel
MFC after: 3 days
|
|
|
|
|
|
|
|
| |
and write_set) with setfacl(1).
PR: kern/154113
Submitted by: Shawn Webb <lattera at gmail dot com> (earlier version)
MFC after: 1 month
|
|
|
|
|
|
|
|
|
| |
that setfacl(1) exits with proper exit status on failure.
PR: bin/149780
Submitted by: Ævar Arnfjörð Bjarmason (original version)
Reviewed by: trasz
MFC after: 3 weeks
|
|
|
|
| |
MFC after: 4 days
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
| |
Approved by: jedgar
|
| |
|
|
|
|
| |
such as "setfacl -m ''".
|
|
|
|
| |
Reviewed by: rwatson
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initially, 'acl' (an 'acl_t *') is allocated, and its ACCESS_ACL and
DEFAULT_ACL fields are passed to the 'libc' ACL routines for subsequent
allocation. If the '-m' option (merge existing ACL with a new one) is
specified, then 'set_acl_mask()' will be called and passed one of the
two ACLs. This function, in turn, replaces this given ACL structure by
another, freshly allocated. However, the pointer in the 'acl' variable
in the caller is not updated. The caller then proceeds to free the ACL,
incurring in a double free condition.
Submitted by: Pedro Martelletto <pedro at ambientworks.net>
Approved by: rwatson (mentor)
|
|
|
|
|
| |
Pointed out by: rwatson
MFC after: 1 week
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
| |
Before this fix the -h flag was ignored (i.e. setfacl
always set the ACL on the file pointed to by the symbolic
link even when the -h flag requested that the ACL be set
on the symbolic link itself).
|
| |
|
| |
|
|
|
|
|
| |
MFC after: 1 week
Approved by: kan (mentor)
|
|
|
|
|
|
|
|
|
| |
next read filename overwrite previous one, resulting in acl being
applied only to the last name in the list.
Submitted by: Oleg Lomaka <oleg.lomaka at gmail com>
MFC after: 1 week
Approved by: kan (mentor)
|
| |
|
| |
|
|
|
|
| |
Sort standard sections in the (documented) preferred order.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
tools such as chmod(1) and ls(1) when it comes to acting on objects
that have POSIX.1e extended ACLs. Specifically, discuss the
substitution of the mask entry for the group entry in the mode
representation of the ACL. Differently worded from the submission,
and could probably use further refinement.
PR: 55319
Submitted by: Grzegorz Czaplinski <G.Czaplinski@prioris.mini.pw.edu.pl>
|
|
|
|
|
| |
PR: 55318
Submitted by: Grzegorz Czaplinski <G.Czaplinski@prioris.mini.pw.edu.pl>
|