| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Reviewed by: ed, jilles
MFC After: 3 days
|
|
|
|
|
|
| |
For these simple utilities, it doesn't harm to make all global variables
static. In fact, this allows the compiler to perform better forms of
optimisation and analysis.
|
|
|
|
|
|
|
| |
directories; it should not change the permission bits of already
existing directories.
Submitted by: Alex Unleashed (modified by me)
|
| |
|
|
|
|
|
|
|
| |
- Add WARNS?= 6
Approved by: stefanf, grehan (mentor)
Obtained from: DragonFlyBSD
|
| |
|
|
|
|
| |
PR: 71743
|
|
|
|
| |
OK'ed by: imp, core
|
| |
|
| |
|
|
|
|
|
|
|
| |
call returns `EISDIR', not `EEXIST', so that be prepared for that. This should
fix number of ports, that often call `mkdir -p //usr/local/foobar'. This
is just a quick workaround, the real fix would be either to avoid calling
mkdir("/", ...) or fix VFS code to return consistent errno for this case.
|
| |
|
|
|
|
| |
Reviewed by: jkh
|
|
|
|
|
|
|
|
|
| |
o Old-style K&R declarations have been converted to new C89 style
o register has been removed
o prototype for main() has been removed (gcc3 makes it an error)
o int main(int argc, char *argv[]) is the preferred main definition.
o Attempt to not break style(9) conformance for declarations more than
they already are.
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
This makes "mkdir /nonexistant/foo" complain that /nonexistant
doesn't exist rather than /nonexistant/foo which doesn't make much
sense.
Submitted (in a different form) by: W.H.Scholten <whs@xs4all.nl>
|
|
|
|
| |
Reviewed by: obrien
|
|
|
|
| |
Reviewed by: obrien
|
| |
|
|
|
|
| |
Obtained from: OpenBSD
|
|
|
|
|
|
| |
with Bruce again.
Reported by: bde
|
|
|
|
|
| |
if we are invoked with -m, use chmod() on the final directory component
in order to ensure the mode is correctly set.
|
|
|
|
|
|
|
| |
incorporating the intended fix. Attempt to address some of the
putative style bugs introduced. Others doubtless remain.
Embarrassed by: bde
|
|
|
|
|
|
| |
by the kernel as a security feature of some sort.
Submitted by: Wilfredo Sanchez <wsanchez@apple.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix mkdir -p to exit with the proper exit status and issue an error
message if it was unable to create all of the specified directories
and they did not previously exist. POSIX says:
The mkdir utility shall exit with one of the following values:
0 All the specified directories were created successfully or the
-p option was specified and all the specified directories now
exist.
E.g.
% mkdir -p /var/mkdir
mkdir: /var/mkdir: Permission denied
% touch /tmp/file
% mkdir -p /tmp/file/dir
mkdir: /tmp/file: Not a directory
Previously the above examples would exit with a zero exit status
and no error message. Something like the following run as a
normal user will still not produce an error:
% id
uid=629(mpp) gid=629(mpp)....
% mkdir -p /usr/local/etc
% ls -ld /usr/local/etc
drwxr-xr-x 4 bin bin 512 Dec 26 14:55 /usr/local/etc/
2) Cleaned up the mode handling to be more efficient when multiple
directories are being created.
3) Fixed a problem where directories could be created with the wrong mode
if the the -p option was specified and the build() routine returned
and error. It would leave the umask set incorrectly at this point.
4) Removed an unused variable.
Closes PR# 2304.
|
|
|
|
| |
posix standard on the topic.
|
| |
|
|
|
|
|
|
|
|
| |
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Reviewed by: phk
Submitted by: Josef Grosch <joeg@gagme.wwa.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
POSIX.2 looks pretty unequivocal to me, and it agrees with you.
Under the explanation of the "-p" option, it says, "Each dir operand that
names an existing directory shall be ignored without error." Under the
explanation of exit status zero, it says, "All the specified directories were
created successfully, or the-p option was specified and all the specified
directories now exist."
Seems to me POSIX requires exactly the behavior you want.
[ And I've made the change, which is also now compatible with 1.x - jkh ]
Reviewed by: jkh
Submitted by: jkh/tweten
|
|
|