| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
the cumulative exit status being overwritten when directory permissions
were being set. This was particularly bad when called from mv(1) to
perform a cross-device move as the original files were deleted even if
the copy failed.
Reported by: Slaven Rezic <slaven.rezic@berlin.de>
Patch by: bde
PR: 42789
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hack, thereby allowing future extensions to the structure (e.g., for extended
attributes) without rebreaking the ABI. FTSENT now contains a pointer to the
parent stream, which fts_compar() can then take advantage of, avoiding the
undefined behavior previously warned about. As a consequence of this change,
the prototype of the comparison function passed to fts_open() has changed
to reflect the required amount of constness for its use. All callers in the
tree are updated to use the correct prototype.
Comparison functions can now make use of the new parent pointer to access
the new stream-specific private data pointer, which is intended to assist
creation of reentrant library routines which use fts(3) internally.
Not objected to in spirit by: -arch
|
| |
|
|
|
|
|
| |
PR: 7828
Suggested by: Daniel O'Connor <doconnor@gsoft.com.au>
Approved by: sheldonh (mentor)
MFC after: 2 weeks
|
| |
|
|
| |
happy about it any more so change the usage to make buildworld work again.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
instead of making a copy of the link itself (SUSv3)
Obtained from: NetBSD
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Fix the case:
cp file nonexistent/
which create nonextstent as file while trailing slash clearly indicates
that nonexistent must be a directory.
Also fix the case:
cp file1 file2/
which should produce error.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
o __P has been reoved
o Old-style K&R declarations have been converted to new C89 style
o register has been removed
o prototype for main() has been removed (gcc3 makes it an error)
o int main(int argc, char *argv[]) is the preferred main definition.
o Attempt to not break style(9) conformance for declarations more than
they already are.
Approved by: arch@, new style(9)
|
| |
|
|
| |
a combination of my words and his. We will stop fiddling now. :-)
|
| |
|
|
|
|
|
| |
circumstances. This is a reworked version of the same fix, that does
not have this defect, and which fixes some style bugs at the same time.
Bug reported and fix reviewed by: bde
|
| |
|
|
|
|
|
|
|
|
| |
directories to be copied. Apply umask to newly created directories
when -p is not specified.
PR: 27970
PR: 31633
MFC after: 4 days
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the !(pflag && setfile()) case for regular files unless the copy is
owned by the same user and group. These bits have already been lost
(or never gained) in the correct way. The code didn't actually lose
the bits; it depended on them being lost already (apparently in all
cases) and attempted to gain them as necessary, but it often gained
them (and sometimes collateral bits) when wrong:
- pflag && setfile() == 0 case (i.e., for a successful cp -p):
setfile() copies all the attributes as correctly as possible (as
specified by POSIX), and we sometimes messed up the up the mode by
setting it again. Also, if the file is immutable, then setting the
mode again gave spurious errors (PR 20646).
- !pflag case. If the target is created, POSIX requires it to not
have the set[ug]id bits, but we sometimes copied them from the source.
If the target already exists, POSIX requires its mode to be unchanged,
but we sometimes copied the whole mode from the source.
PR: 20646
MFC after: 4 weeks
|
| |
|
|
| |
strings.
|
| |
|
|
| |
Reviewed by: obrien
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Idea taken from obrien.
Reviewed by: obrien
|
| | |
|
| |
|
|
| |
Submitted by: Philippe Charnier <charnier@xp11.frmug.org>
|
| |
|
|
|
|
|
|
|
|
| |
statement if blocks[*] when the else could be ambiguous, not defaulting
to int type and removal of some unused variables.
[*] This is explicitly allowed by style(9) when the single statement
spans more than one line.
Reviewed by: obrien, chuckr
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
posix standard on the topic.
|
| | |
|
| |
|
|
|
|
|
|
| |
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
option -f and -i are exclusive
respond `Y' is equal to `y'
fix usage string
remove isatty(3) check
Reviewed by: pst
|
| | |
|
| |
|
|
| |
Submitted by: pst, ache
|
| |
|
|
|
|
|
| |
option -f and -i are exclusive
all flag variables initialized with zero
respond `Y' is equal to `y'
update usage string
|
| |
|
|
| |
Reviewed by: phk
|
| |
|
|
| |
fifos.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
stat the pathname "" in order to decide that the pathname "/" is
a directory. This caused `cp kernel /' to fail if the kernel has
the POSIX behaviour of not allowing the pathname "" to be an alias
for ".". It presumably also caused `cp /etc/motd /' to fail in
the unlikely event that "." is not stat'able.
Be more careful about concatenating pathnames: don't check that
the pathname fits until prefixes have been discarded (the check
was too strict). Print the final pathname in error messages.
Terminate the target directory name properly for error messages.
Don't add a slash between components if there is already a slash.
|
| | |
|
| |
|
