| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code like t=$(stat -f %m "$file") segfaulted if -T was active and a trap
was taken while the shell was waiting for the child process to finish.
What happened was that the dotrap() call in waitforjob() was hit. This
re-entered command execution (including expand.c) at a point not expected by
expbackq(), and global state (unallocated stack string and argbackq) was
corrupted.
To fix this, change expbackq() to prepare for command execution to be
re-entered.
Reported by: bdrewery
|
| |
|
|
|
|
| |
PR: 213909
|
| |
|
| |
|
|
|
|
| |
Fix typo in comment.
|
| |
|
|
|
|
|
|
|
| |
If we asked to send sense data by setting CAM_SEND_SENSE, but SIM didn't
confirm transmission by setting CAM_SENT_SENSE, assume it was not sent.
Queue the I/O back to CTL for later REQUEST SENSE with ctl_queue_sense().
This is needed for error reporting on SPI HBAs like ahc(4)/ahd(4).
|
|
|
|
|
|
|
|
|
|
|
| |
dc(1): Merge minor changes from OpenBSD.
Prefer setvbuf() to setlinebuf() for portability.
Some style(9) and redundant tests for NULL.
These are only meant to ease up merging newer changes.
Obtained from: OpenBSD
|
|
|
|
|
|
|
| |
kern.cam.da.X.delete_method: add -width to .Bl macro call
Now the section width is set appropriately per the BIO_DELETE
parameter being described.
|
|
|
|
|
|
|
|
| |
Add missing section to .Xr macro calls for wpifw(4)
The driver manpage for wpifw(4) is missing, but will be added soon. This
fixes the other 2 .Xr calls lacking sections to match the 3rd,
syntactically correct, reference in the SEE ALSO section.
|
|
|
|
|
|
|
|
|
| |
Clean up ddb(4) slightly
- Delete empty Li macro uses [1]. This removes some spaces between
the optional command/subcommand arguments.
- Attempt to clarify "show lock" subcommand by being more
terse/direct. This addresses an issue with a contraction [2].
|
|
|
|
|
|
|
|
|
|
|
|
| |
Parameterize out the length of struct filed->f_lasttime as `MAXDATELEN`
This removes the hardcoded value for the field (16) and the equivalent
hardcoded lengths in logmsg(..).
This change is being done to help stage future work to add RFC5424/RFC5434
support to syslogd(8).
Obtained from: Isilon OneFS (dcd33d13da) (as part of a larger change)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r314189:
Fix up NULL/'\0' uses and fix 2 derefs after NULL
CID: 1018898, 1018899
r314190:
Fix some minor style nits: put parentheses around return values
r314191:
Fix up r314189
The conditional in do_buff_decode(..) after the while loop was accidentally
inverted. Only increment the pointer for fmt if it's not NUL.
|
|
|
|
|
|
|
|
|
|
| |
Fix warnings in lib/msun/tests/... to help pave way for WARNS?= 6.
- Staticize variables.
- Use nitems liberally. Wherever nitems is used, use unsigned integers
- Remove unused variables (argc, argv, etc)
This fixes most issues -- some issues remain in logarithm_test though.
|
|
|
|
| |
Fix "make depend" with geom_uzip.ko: add opt_geom.h to SRCS
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r305283:
Skip :test_large on i386
More assertions are failing on ^/head now.
PR: 205446
r314649:
Convert lib/msun/ctrig_test from TAP to ATF
This is being done as a precursor for work needed to annontate failing
testcases with clang 4.0+.
PR: 217528
|
|
|
|
| |
Fix "make depend" with nvme.ko: add opt_cam.h to SRCS
|
|
|
|
|
|
|
|
|
|
|
| |
Add shutdown/poweroff support to rescue(8)
shutdown is a safer way to power off than reboot (in general), because of
the added shutdown process that it executes via /etc/rc.shutdown . It was
odd that it was missing from rescue(8) since reboot and friends were
added in past commits.
While here, alias poweroff to shutdown for parity with sbin/shutdown/Makefile
|
|
|
|
|
|
|
| |
Conditionally compile certain programs into rescue(8) if requested
MK_CCD - ccdconfig
MK_ROUTED - routed, rtquery
|
|
|
|
| |
- Use virtualbox-ose-additions-nox11 for vagrant image to reduce size
|
|
|
|
|
| |
Remove extraneous arguments and options, which don't make sense for
a file documented in volume 5.
|
|
|
|
|
|
| |
Fix mismerge of r280849.
Reported by: des
|
|
|
|
|
|
|
| |
Fix lookup of original destination address when using a redirect rule.
Transparent proxying, e.g. to squid, is an example of this.
Obtained from: NetBSD ip_nat.c r1.17, ip_nat6.c r1.10
|
| |
|
| |
|
|
|
|
| |
Do not leak mount references for dying threads.
|
|
|
|
|
|
|
|
| |
Don't create pointless backups of generated files in "make sysent".
Any sensible workflow will include a revision control system from which
to restore the old files if required. In normal usage, developers just
have to clean up the mess.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r314556:
Correct MDSRCS use in <arch>/string/Makefile.inc.
- Remove .c files which duplicate entries in MISRCS.
- Use the same, less merge conflict prone style in all cases.
- Use MDSRCS for mips (.c and .S files both ended up in SRCS).
- Remove pointless sparc64 Makefile.inc.
- Remove uninformative foreign VCS ID entries.
Reviewed by: emaste, imp, jhb
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D9841
r314557:
Correct an misunderstanding of MDSRCS.
MDSRCS it intended to allow assembly versions of funtions with C
implementations listed in MISRCS. The selection of the correct
machdep_ldis?.c for a given architecture does not follow this pattern
and the file should be added to SRCS directly.
Reviewed by: emaste, imp, jhb
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D9841
r314558:
Garbage collect unused gdtoa related files on mips.
Reviewed by: emase, imp, jhb
MFC after: 1 week
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D9841
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r313021 (brd):
Force a few variables to be upper case when they are evaulated.
r313027 (brd):
Add a new vagrant-box target, to make it easier and less redundant
to only produce the Vagrant box and not upload it.
r313044 (brd):
Add some comments with examples on how to build Vagrant images.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix permissions on /tmp when installing the runtime package.
PR: 217574
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Fix grammar in some comments in subr_sleepqueue.c
While I'm here, remove trailing whitespace.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pf: use inet_ntoa_r() instead of inet_ntoa(); maybe fix IPv6 OS fingerprinting
inet_ntoa() cannot be used safely in a multithreaded environment
because it uses a static local buffer. Instead, use inet_ntoa_r()
with a buffer on the caller's stack.
This code had an INET6 conditional before this commit, but opt_inet6.h
was not included, so INET6 was never defined. Apparently, pf's OS
fingerprinting hasn't worked with IPv6 for quite some time.
This commit might fix it, but I didn't test that.
Relnotes: yes (if I/someone can test pf OS fingerprinting with IPv6)
Sponsored by: Dell EMC
|
|
|
|
|
|
| |
Make several improvements and corrections in the kenv(2) man page
Sponsored by: Dell EMC
|
|
|
|
|
|
|
|
|
| |
acpica: remove a superfluous NULL check
The address-of operator can't produce NULL (in practice).
Remove an unnecessary NULL check.
Sponsored by: Dell EMC
|
|
|
|
| |
Register nss_atexit() before parsing nsswitch.conf for the first time.
|
|
|
|
| |
Fix some memory leaks in CDDL code.
|
|
|
|
| |
Fix a ticks comparison in sched_pctcpu_update().
|
|
|
|
| |
Prevent CPU migration when checking the DTrace nofault flag on x86.
|
|
|
|
| |
Remove cpu_deepest_sleep variable.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix matching table entry value. Use real table value instead of its index
in valuestate array.
When opcode has size equal to ipfw_insn_u32, this means that it should
additionally match value specified in d[0] with table entry value.
ipfw_table_lookup() returns table value index, use TARG_VAL() macro to
convert it to its value. The actual 32-bit value stored in the tag field
of table_value structure, where all unspecified u32 values are kept.
PR: 217262
|
|
|
|
|
|
|
|
| |
vxge(4): double assignments.
Fix some suspicious code, likely caused by excessive copy-pasting.
Found with: coccinelle (da.cocci)
|
|
|
|
|
|
|
| |
Split the ficl CFLAGS when they refer to an arch-specific include path.
This is a minimal attempt to keep consistency in the Makefiles so that
moving ficl to somwehere like contrib will be less error prone.
|
|
|
|
|
|
| |
Add linux_preadv() and linux_pwritev() syscalls to Linuxulator.
Approved by: dchagin
|
|
|
|
|
| |
Do not invoke the resize event when previous provider's size was zero.
This is similar to r303637 fix for geom_disk.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add __int128-related symbols to libcxxrt's version map. Put these into
the same CXXABI verions as recent libstdc++.
Note that __int128 types are only available on arches where long long is
128 bit wide.
Noticed by: harti
MFC r314104:
Surround any unmangled C++ names in libcxxrt's version map with 'extern
"C++"', otherwise ld refuses to make the symbols global in the final
library. This causes the __int128-related symbols to go missing when
the library is stripped during installation.
Helpful hints: emaste
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PR30305: Implement proposed DR resolution to prevent slicing via
inherited constructor.
The rule we use is that a construction of a class type T from an
argument of type U cannot use an inherited constructor if U is the
same as T or is derived from T (or if the initialization would first
convert it to such a type). This (approximately) matches the rule in
use by GCC, and matches the current proposed DR resolution.
Pull in r291955 from upstream clang trunk (by Richard Smith):
PR31606: Generalize our tentative DR resolution for inheriting
copy/move constructors to better match the pre-P0136R1 behavior.
Together, these fix an issue with C++ using declarations sometimes
enabling illegal implicit casts.
Direct commit to stable/11, since head already has clang 4.0.0, which
includes this change.
Reported by: kami
PR: 215969
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MVF: 313876
7504 kmem_reap hangs spa_sync and administrative tasks
illumos/illumos-gate@405a5a0f5c3ab36cb76559467d1a62ba648bd809
https://github.com/illumos/illumos-gate/commit/405a5a0f5c3ab36cb76559467d1a62ba648bd80
https://www.illumos.org/issues/7504
We see long spa_sync(). We are waiting to hold dp_config_rwlock for writer. Some
other thread holds dp_config_rwlock for reader, then calls arc_get_data_buf(),
which finds that arc_is_overflowing()==B_TRUE. So it waits (while holding
dp_config_rwlock for reader) for arc_reclaim_thread to signal arc_reclaim_waiters_cv.
Before signaling, arc_reclaim_thread does arc_kmem_reap_now(), which takes ~seconds.
Author: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Approved by: Dan McDonald <danmcd@omniti.com>
|
|
|
|
|
| |
Obtained from: Panzura
Sponsored by: Panzura
|