summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* hyperv/hn: Add stat for # of chimney sending triessephe2016-04-272-0/+6
| | | | | MFC after: 1 week Sponsored by: Microsoft OSTC
* hyperv/vmbus: Mark sysctls MPSAFEsephe2016-04-272-9/+9
| | | | | MFC after: 1 week Sponsored by: Microsoft OSTC
* hyperv/hn: Mark sysctls MPSAFEsephe2016-04-271-26/+30
| | | | | MFC after: 1 week Sponsored by: Microsoft OSTC
* hyperv/hn: Remove unapplied comment.sephe2016-04-271-2/+0
| | | | | | | Chimney sending buffers are shared across channels. MFC after: 1 week Sponsored by: Microsoft OSTC
* hyperv/hn: Restart sending earlier once we gathered some free TX descssephe2016-04-272-3/+20
| | | | | | | | | | | | | | This greatly reduces the oqdrops under heavy workload. For TCP send/recv test (10K concurrent connections): oqdrops is reduced by 17% on sending side, and 57% on receiving side. For nginx-1.8/wrk-4 1KB object test (10K concurrent connections, 4 requests/connection): oqdrops is reduced by 44% on nginx side, and 10% on wrk side. MFC after: 1 week Sponsored by: Microsoft OSTC
* For pointers use NULL instead of 0.araujo2016-04-272-24/+24
| | | | | | Reviewed by: rpaulo MFC after: 2 weeks. Differential Revision: https://reviews.freebsd.org/D5946
* Use MIN() macro from sys/param.h.araujo2016-04-271-1/+1
| | | | MFC after: 2 weeks.
* Use MIN() macro from sys/param.h.araujo2016-04-271-1/+1
| | | | MFC after: 2 weeks.
* Use macro MIN() from sys/param.h.araujo2016-04-271-1/+1
| | | | MFC after: 2 weeks.
* Delay revmoing the last jail reference in prison_proc_free, and insteadjamie2016-04-272-12/+35
| | | | | | | | | | put it off into the pr_task. This is similar to prison_free, and in fact uses the same task even though they do something slightly different. This resolves a LOR between the process lock and allprison_lock, which came about in r298565. PR: 48471
* Use MIN() macro from sys/param.h.araujo2016-04-271-2/+2
| | | | MFC after: 2 weeks.
* Use macro MIN() from sys/param.h.araujo2016-04-271-2/+2
| | | | MFC after: 2 weeks.
* fsck_ffs: Revert partially the unsigned changes.pfg2016-04-271-1/+1
| | | | | | | | | Any value of uint16_t will be internally promoted to int so changing them to an unsigned value doesn't help. Missing revert value in suj_read(). X-MFC with: r298551
* fsck_ffs: Revert partially the unsigned changes.pfg2016-04-271-3/+3
| | | | | | | | | Any value of uint16_t will be internally promoted to int so changing them to an unsigned value doesn't help. Make clear we want to use uint32_t for closedisk() X-MFC with: r298551
* posix4_mib: Don't overrun facility_initialized arraycem2016-04-271-3/+3
| | | | | | | | | | The facility_initialized and facility arrays are the same size and were intended to be indexed the same. I believe this mismatch was just a typo/braino in r208731. Reported by: Coverity CID: 1017430 Sponsored by: EMC / Isilon Storage Division
* subr_mbpool: Don't free bogus pointer in error pathscem2016-04-261-4/+1
| | | | | | | | | | | An mbpool is allocated with a contiguous array of mbpages. Freeing an individual mbpage has never been valid. Don't do it. This bug has been present since this code was introduced in r117624 (2003). Reported by: Coverity CID: 1009687 Sponsored by: EMC / Isilon Storage Division
* netipsec: Don't leak memory when deep copy failscem2016-04-261-0/+1
| | | | | | Reported by: Coverity CID: 1331693 Sponsored by: EMC / Isilon Storage Division
* in_lltable_alloc and in6 copy: Don't leak LLE in error pathcem2016-04-262-8/+30
| | | | | | | | Fix a memory leak in error conditions introduced in r292978. Reported by: Coverity CIDs: 1347009, 1347010 Sponsored by: EMC / Isilon Storage Division
* Refactor DTS files for Zynq-based SoCsgonzo2016-04-264-387/+322
| | | | | | | | | | | - Factor out common part to zynq-7000.dtsi - Fix problem with Zynq interrupts by using interrupt "triples" in .dtsi file to differentiate between edge-triggered and level-triggered interrupts - cgem driver now recognizes "status" property Submitted by: Thomas Skibo <thomasskibo@yahoo.com> Differential Revision: https://reviews.freebsd.org/D6095
* tcp_usrreq: Free allocated buffer in relock casecem2016-04-261-2/+5
| | | | | | | | | | | | | | | | | The disgusting macro INP_WLOCK_RECHECK may early-return. In tcp_default_ctloutput() the TCP_CCALGOOPT case allocates memory before invoking this macro, which may leak memory. Add a _CLEANUP variant that takes a code argument to perform variable cleanup in the early return path. Use it to free the 'pbuf' allocated in tcp_default_ctloutput(). I am not especially happy with this macro, but I reckon it's not any worse than INP_WLOCK_RECHECK already was. Reported by: Coverity CID: 1350286 Sponsored by: EMC / Isilon Storage Division
* g_part_bsd64: Delete duplicate/dead codecem2016-04-261-2/+0
| | | | | | | | RAW_PART is handled earlier in the loop. Reported by: Coverity CID: 1223201 Sponsored by: EMC / Isilon Storage Division
* g_part_bsd64: Check for valid on-disk npartitions valuecem2016-04-261-1/+2
| | | | | | | | | | | | | | | | | This value is u32 on disk, but assigned to an int in memory. After we do the implicit conversion via assignment, check that the result is at least one[1] (non-negative[2]). 1. The subsequent for-loop iterates from gpt_entries minus one, down, until reaching zero. A negative or zero initial index results in undefined signed integer overflow. 2. It is also used to index into arrays later. In practice, we expected non-malicious disks to contain small positive values. Reported by: Coverity CID: 1223202 Sponsored by: EMC / Isilon Storage Division
* ciss(4): Fix overrun of arraycem2016-04-261-2/+2
| | | | | | | | | | The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members. Most of the time it is iterated correctly. This patch fixes the two instances where the driver iterated off the end of the array. Reported by: Coverity CID: 1305492 Sponsored by: EMC / Isilon Storage Division
* iscsi_initiator(4): Fix use-after-free, double-freecem2016-04-261-2/+0
| | | | | | | | | | ism_stop() already destroys and frees 'sp', including a call to ic_destroy(). Don't dereference 'sp' after ism_stop() and don't invoke ic_destroy() on the freed memory either. Reported by: Coverity CIDs: 1006109, 1304861 Sponsored by: EMC / Isilon Storage Division
* Use crcopysafe in jail_attach.jamie2016-04-261-7/+5
|
* Add dtb/zynq to the list of extra modules required by Zedboardgonzo2016-04-261-0/+2
|
* Add dtb/zynq to generate dtb files for Zynq-based boardsgonzo2016-04-261-0/+7
| | | | | | | | | It seems that the only way to supply dtb to loader on Zynq-based SoCs is to manually generate dtb and place it to pre-defined location on SD card or TFTP server where loader can pick it up. More modern approach is to add modules/dtb/%soc% module and let installworld target generate dtb and copy them to /boot/dtb/ where they can be loaded by ubldr
* aacraid(4): Fix some mostly trivial buffer overrunscem2016-04-261-3/+5
| | | | | | | | | | strcpy(3) emits a trailing nul byte, trampling fields after the intended destination. Instead, use strncpy(3), intentionally leaving these fields not nul-terminated. Reported by: Coverity CIDs: 1031024, 1305463, 1305494, 1305545 Sponsored by: EMC / Isilon Storage Division
* msdosfs: Prevent buffer overflow when expanding win95 nameskp2016-04-262-9/+23
| | | | | | | | | | | | In win2unixfn() we expand Windows 95 style long names. In some cases that requires moving the data in the nbp->nb_buf buffer backwards to make room. That code failed to check for overflows, leading to a stack overflow in win2unixfn(). We now check for this event, and mark the entire conversion as failed in that case. This means we present the 8 character, dos style, name instead. PR: 204643 Differential Revision: https://reviews.freebsd.org/D6015
* radix_mpath: Don't derefence a NULL pointer in for loop iterationcem2016-04-261-1/+1
| | | | | | | | | | | | | | | | | | It seems rn_dupedkey may be NULL, because of the NULL check inside the loop. (Also, the rt gets assigned from rn_dupedkey and NULL checked at top of loop.) However, the for-loop update condition happens before the top-of-loop check and dereferences 'rt' unconditionally. Instead, NULL-check before dereferencing. If rn_dupedkey cannot in fact be NULL, or something else protects this, feel free to revert this and add an ASSERT of some kind instead. This was introduced in r191080 (2009) and moved around slightly in r293657. Reported by: Coverity CID: 1348482 Sponsored by: EMC / Isilon Storage Division
* PCI Enhanced Allocation: Annotate an intentional switch fallthroughcem2016-04-261-0/+1
| | | | | | | | | | This is a trivial follow-up to r296308. Annotate the intentional fallthrough to make it clear for future readers and linters. Reported by: Coverity CID: 1352716 Discussed with: jhb Sponsored by: EMC / Isilon Storage Division
* osd(9): Change array pointer to array pointer type from void*cem2016-04-267-19/+20
| | | | | | | | | | | | | This is a minor follow-up to r297422, prompted by a Coverity warning. (It's not a real defect, just a code smell.) OSD slot array reservations are an array of pointers (void **) but were cast to void* and back unnecessarily. Keep the correct type from reservation to use. osd.9 is updated to match, along with a few trivial igor fixes. Reported by: Coverity CID: 1353811 Sponsored by: EMC / Isilon Storage Division
* Fix up r298368ngie2016-04-261-1/+1
| | | | | | | | | | | | Remove the semicolon accidentally added after the new conditional that tests that /dev/zero is opened successfully. MFC after: 1 week X-MFC with: r298368 Pointhat to: ngie Reported by: Coverity CID: 1354980 Sponsored by: EMC / Isilon Storage Division
* iwm(4): Don't dereference potentially NULL pointer before NULL checkcem2016-04-261-1/+1
| | | | | | | | | Introduced in r298594. There is no path before the 'vap == NULL' check where vap is not already dereferenced. Reported by: Coverity CID: 1354979 Sponsored by: EMC / Isilon Storage Division
* Remove redundant word.bhd2016-04-261-1/+1
| | | | | Reviewed by: bjk, bcr Differential Revision: https://reviews.freebsd.org/D6064
* emu10kx: Don't iterate beyond array boundscem2016-04-261-1/+1
| | | | | | Reported by: Coverity CID: 1354978 Sponsored by: EMC / Isilon Storage Division
* Redo the changes to the SYSV IPC sysctl functions from r298585, so theyjamie2016-04-263-83/+50
| | | | | | don't (mis)use sbufs. PR: 48471
* kgssapi: Don't leak memory in error casescem2016-04-261-3/+9
| | | | | | Reported by: Coverity CIDs: 1007046, 1007047, 1007048 Sponsored by: EMC / Isilon Storage Division
* WITH_META_MODE: Allow buildkernel to create .meta files with curdir==objdir.bdrewery2016-04-261-0/+5
| | | | | | | | | | Without this the incremental build was broken since .depend.* are not generated with .MAKE.MODE=meta and .meta files were not created to track dependencies. Typically meta mode does not create .meta files when building with curdir==objdir but the kernel build is special. Reported by: Nikolai Lifanov <lifanov@mail.lifanov.com> Sponsored by: EMC / Isilon Storage Division
* [mips] correctly represent memory region allocations >> 2^^31adrian2016-04-261-2/+2
| | | | | | | Without this, it'd get promoted incorrectly and fail allocation. Submitted by: Mori Hiroki <yamori813@yahoo.co.jp> Reviewed by: imp
* Fix the parameter type according to method declaration.br2016-04-261-1/+1
| | | | This fixes compilation on riscv with GCC 5.2.0
* Build fix. Add howmany() and nitems() macros to bootloader kernel shim.hselasky2016-04-261-0/+2
|
* sys: extend use of the howmany() macro when available.pfg2016-04-2621-77/+68
| | | | | We have a howmany() macro in the <sys/param.h> header that is convenient to re-use as it makes things easier to read.
* Mark the unused period argument __unused.bz2016-04-261-1/+2
| | | | | | Reviewed by: andrew MFC after: 2 weeks Sponsored by: DARPA/AFRL
* Add function needed for linking USB test application.hselasky2016-04-261-0/+6
|
* sys/dev: extend use of the howmany() macro when available.pfg2016-04-2630-52/+47
| | | | | We have a howmany() macro in the <sys/param.h> header that is convenient to re-use as it makes things easier to read.
* sys/boot: make use of the howmany() macro when available.pfg2016-04-263-7/+8
| | | | | We have a howmany() macro in the <sys/param.h> header that is convenient to re-use as it makes things easier to read.
* Add GEOM::physpath documentation to devd.conf(5)asomers2016-04-261-0/+2
| | | | | | | | Suggested by: trasz Reviewed by: trasz MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D6063
* sys/arm: make use of the howmany() macro when available.pfg2016-04-264-4/+4
| | | | | We have a howmany() macro in the <sys/param.h> header that is convenient to re-use as it makes things easier to read.
* sys/powerpc: make use of the howmany() macro when available.pfg2016-04-263-4/+4
| | | | | We have a howmany() macro in the <sys/param.h> header that is convenient to re-use as it makes things easier to read.
OpenPOWER on IntegriCloud