| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Submitted by: Grégory Soutadé <soutade@gmail.com> (via github pull request)
|
|
|
|
| |
Approved by: re (gjb, implicit, relnotes)
|
|
|
|
| |
Sponsored by: Chelsio Communications
|
|
|
|
| |
Reported by: lidl
|
| |
|
|
|
|
|
|
| |
Submitted by: Artem V. Andreev <Artem.Andreev at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not returning if rtype == RPCBVERS_STAT will cause us to overrun the inf array, as
it's defined to be exactly RPCBVERS_STAT elements in rpcb_prot.x:
> include/rpc/rpcb_prot.x:typedef rpcb_stat rpcb_stat_byvers[RPCBVERS_STAT];
The proposed change also matches the rest of the rtype upper bound checks in the
file, so the original change was likely a typo.
MFC after: 2 weeks
Reported by: Coverity
CID: 1007567
Reviewed by: truckman
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
| |
Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
Reported by: Coverity
CID: 1304340
Reviewed by: lidl
Differential Revision: https://reviews.freebsd.org/D6749
Sponsored by: Rubicon Communications (Netgate)
|
|
|
|
|
| |
between our libpam and stock OpenPAM, meaning that it is now possible to
replace the base libpam with a hypothetical ports version of OpenPAM.
|
|
|
|
| |
MFC after: 1 month
|
|
|
|
| |
MFC after: 1 month
|
|
|
|
|
|
|
|
|
|
|
| |
If malloc() fails to allocate linep, then free olinep (if it exists)
before returning to avoid a memory leak.
Reported by: Coverity
CID: 1016716
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D6755
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the ai->ai_addrlen <= minsiz test fails, then freeaddrinfo()
does not get called to free the memory just allocated by getaddrinfo().
Fix by moving ai->ai_addrlen <= minsiz to a separate nested if
block, and keep freeaddrinfo() in the outer block so that freeaddrinfo()
will be called whenever getaddrinfo() succeeds.
Reported by: Coverity
CID: 1273652
Reviewed by: ume
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D6756
|
|
|
|
| |
MFC after: 1 month
|
|
|
|
| |
MFC after: 1 month
|
|
|
|
| |
MFC after: 1 month
|
|
|
|
|
|
| |
MFC after: 1 week
Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D6745
|
|
|
|
|
|
| |
Reviewed by: hselasky (earlier version)
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D6740
|
|
|
|
| |
MFC after: 1 month
|
|
|
|
|
| |
Obtained from: Mellanox Technologies
MFC after: 1 month
|
|
|
|
|
|
|
| |
Pass -n (do not emit comments) when saving mtree information for future
mergemaster(8) runs.
MFC after: 3 days
|
|
|
|
|
|
| |
MFC after: 1 week
Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D6744
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fix in r300649 was not sufficient to convince Coverity that the
buffer was NUL terminated, even with the buffer pre-zeroed. Swap
the size and nmemb arguments to fread() so that a valid lenght is
returned, which we can use to terminate the string in the buffer
at the correct location. This should also quiet the complaint about
the return value of fread() not being checked.
Reported by: Coverity
CID: 1019054, 1009614
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the process credentials were not changed. This can happen if an
error occured trying to activate the setuid binary. And on error, if
new credentials were not yet assigned, they must be freed to not
create the leak.
Use oldcred == NULL as the predicate to detect credential
reassignment.
Reported and tested by: pho
Sponsored by: The FreeBSD Foundation
|
|
|
|
| |
on revision r301496.
|
| |
|
|
|
|
| |
- Reset DMA indexes after disabling DMA.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than guarding close(fd) with an fd >= 0 test and setting fd
to -1 when it is closed to avoid a potential double-close, just
move the close() call after the conditional "goto make_token". This
moves the close() call totally outside the loop to avoid the
possibility of calling it twice. This should also prevent a Coverity
warning about checking fd for validity after it was previously passed
to read().
Reported by: Coverity
CID: 1355335
MFC after: 1 week
X-MFC with: r299484
|
|
|
|
| |
Reviewed by: mjg
|
|
|
|
|
|
|
| |
CASPER_SERVICE_STDIO - Casper will not close the first three descriptors (stdin,
stdout and stderr) this can be helpful for debugging.
CASPER_SERVICE_FD - Capser will not close all other descriptors, this can
be useful for a filesystem service.
|
|
|
|
|
|
|
|
| |
This went mostly unnoticed with the deprecation of the GNU toolchain
in tier 1 platforms. Fix it now for the rest.
PR: 169901
MFC after: 3 days
|
|
|
|
| |
As in UFS r300366.
|
|
|
|
|
|
|
|
|
| |
In the case where cam_iosched_init() fails, the ada and da softcs were leaked.
Instead, free them.
Reported by: Coverity
CID: 1356039
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
|
|
|
| |
Fix some memory leaks. Some may remain.
Reported by: Coverity
Discussed with: mmacy
CIDs: 1356036, 1356037, 1356038
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
| |
Replace spaces with tabs. No functional change.
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
|
|
| |
still be used, however this is expected to be removed soon.
Obtained from: ABT Systems Ltd
Relnotes: yes
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If strlen(hostp) was zero, the stack array 'nam' would never be initialized
before being strdup()ed. Fix this by initializing it to the empty string.
It's possible some external condition makes this case impossible, in which
case, an assertion instead of this workaround is appropriate.
Introduced in r299848.
Reported by: Coverity
CID: 1355336
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to an accidental mismatch between allocation and release in the slow path
of iflib_if_transmit, if a caller passed 9-16 mbufs to the routine, the mbuf
array would be leaked.
Fix the mismatch by removing the magic numbers in favor of nitems() on the
stack array. According to mmacy, this leak is unlikely.
Reported by: Coverity
Discussed with: mmacy
CID: 1356040
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
|
|
| |
Introduced in r301518.
Reported by: Coverity
CID: 1356266
Sponsored by: EMC / Isilon Storage Division
|
|
|
|
|
|
|
|
|
| |
the exact CPU we are running on to set the cpu functions. Relax the check
to ignore the CPU revision. Even so this may still be too specific.
Reviewed by: mmel
Sponsored by: ABT Systems Ltd
Differential Revision: https://reviews.freebsd.org/D6504
|
|
|
|
|
|
|
| |
While here assign error a bit later.
Reviewed by: Damjan Jovanovich
Obtained from: NetBSD
|
|
|
|
| |
Obtained from: NetBSD
|
| |
|
|
|
|
|
| |
Reported by: araujo
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
| |
Reported by: bdrewery
Sponsored by: The FreeBSD Foundation
|
|
|
|
| |
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
| |
Reported by: jbeich
Sponsored by: The FreeBSD Foundation
|