summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* MFC r318895: Fix several problems with mapping code in mps(4).slm2017-06-0114-881/+1778
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MFC r318896: Fix several problems with mapping code in mpr(4). -Add several comments describing what the mapping code is doing. -Added a callout timer to improve check for missing devices when discovery has completed so that missing counts are incremented correctly. -Fix problems with missing counts not being saved to the HBA. -Update man pages mps(4) and mpr(4) to include a description of the use use_phy_num sysctl variable. -Remove channel field in the mapping structure because it's not used. -Improve logging by using mps_dprint or mpr_dprint instead of printf and adding more logging where appropriate. -Add check for a bad index before writing mapping entries to controller. -The high missing count check in the mapping table was using the incorrect initial value, which could lead to a bad result. -The usage of the IN_USE flag for volume mapping was changed to be more intuitive, and was not being used correctly. -The check for a free DPM entry was changed, as this was completely wrong. -Updates to the missing count for volumes were not being done correctly, so this function was completely rewritten. -_mapping_add_to_removal_table() was overly complicated and incorrectly used, so this function was rewritten. -Missing counts for all devices were not being incremented properly, so this functionality was added. -The search for space in the mapping table for missing enclosures was not calculating the found space correctly due to not breaking out of a loop when required, and the num_found variable was not being reset when needed. -Retries when a device fails to get added due to a full mapping table were removed because this is unneccessary. -mps_mapping_is_reinit_required() and mpr_mapping_is_reinit_required() were removed because they were not being used. -Some functions were renamed to avoid confusion between Target IDs and SAS IDs. -_mapping_check_update_ir_mt_idx() was removed because it was overly complicating volume mapping. -The setting of the maxtargets variable was changed to include max volumes. -The setting of the initiator_id variable was changed to be the invalid target ID after all targets, including volumes. Previously, this was set to the last valid target ID. -Don't exclude target IDs of RAID components or check for a reuse of a target ID for RAID components. -Some endienness was added. Approved by: ken, mav
* Document r319436, mpr(4) tri-mode support.gjb2017-06-011-1/+4
| | | | Sponsored by: The FreeBSD Foundation
* MFC r286567, r286568, r289426, r289429, r295113, r295286, r299367, r299369,slm2017-06-0130-559/+4053
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r308217, r308301, r311958, r312437, r318188, r318427, r318679 r286567: Remove some unused code. Obtained from: Netflix, Inx. r286568: Remove mps_request_polled(), it's redundant to mps_wait_command() Obtained from: Netflix, Inc. r289426: Remove _FreeBSD_version check for something that was only an issue with 9-CURRENT. Obtained from: Netlfix, Inc MFC after: 3 days r289429: Revert an extra hunk that crept into the last commit. Submitted by: emax Obtained from: Netflix, Inc. MFC after: 3 days r295113: Clean up unused-but-set-variable spotted by gcc-4.9. Reviewed by: mav, slm Approved by: rodrigc (mentor) MFC after: 2 weeks Sponsored by: gandi.net r295286: Add sysctls for dumping out the device mapping tables. I'm finding this useful for debugging device-target translation bugs. MFC after: 3 days Sponsored by: Netflix r299367: Remove NULL checks after M_WAITOK allocations from mps(4). Reviewed by: asomers@ MFC after: 1 month Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D6296 r299369: Remove NULL checks after M_WAITOK allocations from mpr(4). Reviewed by: asomers@ MFC after: 1 month Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D6297 r308217: Add a fallback to the device mapper logic. We've seen systems in the field that are apparently misconfigured by the manufacturer and cause the mapping logic to fail. The fallback allows drive numbers to be assigned based on the PHY number that they're attached to. Add sysctls and tunables to overrid this new behavior, but they should be considered only necessary for debugging. Reviewed by: imp, smh Obtained from: Netflix MFC after: 3 days Sponsored by: D8403 r308301: Record the LogInfo field when reporting the IOCStatus. Helps in debugging errors. Submitted by: slm Obtained from: Netflix MFC after: 3 days r311958: Print out the number of queues/MSIx vectors. Sponsored by: Netflix r312437: Rework the debug print API. Event printing no longer gets special handling. All of the printing from the tables file now has wrappers so that the handling is cleaner and it's possible to print something out (say, during development) without having to fight the global debug flags. This re-org will also make it easier to have the tables be compiled out at build time if desired. Other than fixing some minor bugs, there are no user-visible changes from this change Sponsored by: Netflix, Inc. Differential Revision: D9238 r318188: Improve error messages during command timeout for the mpr and mps drivers. Sponsored by: Netflix r318427: Add tri-mode support (SAS/SATA/PCIe). This includes NVMe device support and adds support for the following adapters: SAS 3408 SAS 3416 SAS 3508 SAS 3516 SAS 3616 SAS 3708 SAS 3716 Reviewed by: ken, scottl, asomers, mav Approved by: ken, scottl, mav MFC after: 2 weeks Relnotes: yes Differential Revision: https://reviews.freebsd.org/D10095 r318679: Fix powerpc compiler error. Approved by: ken
* MFC r318832: MFV r316923: 8026 retire zfs_throttle_delay and ↵avg2017-06-011-3/+0
| | | | zfs_throttle_resolution
* MFC r318830: MFV r316921: 8027 tighten up dsl_pool_dirty_deltaavg2017-06-011-1/+1
|
* MFC r318450:kib2017-06-012-0/+103
| | | | | | Add tests for some cases in r318298. PR: 219154
* MFC r319096: zfs_lookup: fix bogus arguments to lookup of "snapshot" directoryavg2017-06-011-1/+1
|
* Regenerate src.conf(5)ngie2017-06-011-1/+15
|
* MFC r314579,r314785:ngie2017-06-0113-14/+52
| | | | | | | | | | | | | | | | | | | r314579 (by np): Add cxgbetool(8) to the base system. Move cxgbetool from tools/tools to usr.sbin. Compile and install it on platforms where cxgbe(4) is built by default. Knobs (WITH_CXGBETOOL and WITHOUT_CXGBETOOL) have been added so that the user can override the default setting. r314785: Fix some trivial manlint warnings Sentences should begin on new lines, per manlint. Bump .Dd for the change
* MFC r318437:ngie2017-06-011-8/+1
| | | | | | Revert local changes to find_progenv accidentally committed in r318436 MFC with: r318436
* MFC r318436:ngie2017-06-016-1/+206
| | | | | | | | | | | | | | | | | usr.bin/getconf: add some initial tests Items tested via this commit are: - Some basic POSIX constants. - Some valid programming environments with -v. - Some invalid programming environments via -v. NOTE: this test makes assumptions about ILP32/LP32 vs LP64 that are currently not true on all architectures to avoid hardcoding some architectures in the tests. I'm working on improving getconf(1) to be more sane about handling ILP32/LP32 vs LP64. Future commits are coming soon to address this. Tested with: amd64, i386
* MFC r318434:ngie2017-06-011-2/+3
| | | | | | Make the `.gperf.c` suffix rule depend on fake-gperf.awk Parameterize out fake-gperf.awk to avoid duplicating the path
* MFC r318177:ngie2017-06-012-4/+2
| | | | | | Unconditionally install udp(4) and udplite(4) again I added this to the MK_USB != no block in error in r278202.
* MFC r319157:ngie2017-06-011-1/+2
| | | | | | | | fma_test: mute a warning about unreachable code on amd64 by restructuring the #ifdef block to only handle the rest of the logic in the loop in the #else case. CID: 1346844
* MFC r319158:ngie2017-06-011-1/+1
| | | | | | | | logarithm_test: assert that feclearexcept succeeds This helps ensure that test preconditons are fulfilled. CID: 1346572
* MFC r318179:ngie2017-06-011-0/+2
| | | | | | | | procstat(1): also reference icmp(4) and sctp(4) This was missed in the previous commit by accident. MFC with: r318178
* MFC r318175:ngie2017-06-011-3/+6
| | | | | | | | | | | | procstat(1): clarify the Signal Disposition section - Fix a typo (SIGIGN -> SIG_IGN). Use .Dv when referencing SIG_IGN. - Use semi-colons as soft breaks when separating sentences for the FLAGS section. - Tweak wording for C slightly to flow better and to be a bit more technically correct (signals with handlers installed will be caught by the target program). - Reference signal(3) in the SEE ALSO section.
* MFC r318178:ngie2017-06-011-1/+59
| | | | | | | procstat(1): document all possible `PRO` (network protocol) values Reference the appropriate section 4 manpages for networking protocols.
* MFC r319156,r319159:ngie2017-06-012-1/+2
| | | | | | | | | | | | | | | | | | r319156: :nvlist_unpack__duplicate_key : check the result of nvlist_pack(3) This fixes a potential NULL pointer dereference. CID: 1362051 r319159: :dnvlist_get_string__default_value: fix a bogus string comparison test Check actual_value vs "5", not "5" vs itself. CID: 1362021
* Bump copyright years after previous commit.gjb2017-05-312-1/+4
| | | | Sponsored by: The FreeBSD Foundation
* Whitespace fixes to conform to FDP style.gjb2017-05-313-6/+7
| | | | Sponsored by: The FreeBSD Foundation
* Document r318675, fix the client side krpc from doing TCPgjb2017-05-311-1/+7
| | | | | | reconnects for ERESTART from sosend(). Sponsored by: The FreeBSD Foundation
* Document r309258, max_align_t for C11 compliance.gjb2017-05-311-1/+2
| | | | Sponsored by: The FreeBSD Foundation
* MFC r318593:asomers2017-05-312-10/+13
| | | | | | Fix build of AIO tests with -DDEBUG Also, redefine some constants for clarity. No functional change.
* Document r313558, garbage IP addresses in UDP log_in_vain messagesgjb2017-05-311-0/+6
| | | | | | fix. Sponsored by: The FreeBSD Foundation
* Document r316040, kvm_close(3) return error fix.gjb2017-05-311-1/+3
| | | | Sponsored by: The FreeBSD Foundation
* Document r317375, RTT used for receive buffer auto resizing.gjb2017-05-311-0/+9
| | | | Sponsored by: The FreeBSD Foundation
* Document r319243, rpcbind(8) warmstart support knob.gjb2017-05-311-0/+6
| | | | Sponsored by: The FreeBSD Foundation
* Document r319270, cxgbe(4) firmware update.gjb2017-05-311-4/+4
| | | | Sponsored by: The FreeBSD Foundation
* Document r317434, ipf(4) 'keep frags' no longer implicit withgjb2017-05-311-1/+4
| | | | | | 'keep state' Sponsored by: The FreeBSD Foundation
* Document r308915, zfsbootcfg(8).gjb2017-05-311-1/+3
| | | | Sponsored by: The FreeBSD Foundation
* Document r316046, WITHOUT_LIBTHR properly removes optional files.gjb2017-05-311-0/+6
| | | | Sponsored by: The FreeBSD Foundation
* Document r313206, inetd(8) buildable without libwrap(3).gjb2017-05-311-1/+4
| | | | Sponsored by: The FreeBSD Foundation
* Document r309340, GARP retransmit capability.gjb2017-05-312-1/+8
| | | | Sponsored by: The FreeBSD Foundation
* Document r312359, r314019: alc(4) Killer E2400/E2500 support.gjb2017-05-312-0/+10
| | | | Sponsored by: The FreeBSD Foundation
* Document r311507, cxgbe(4) firmware 1.16.26.0.gjb2017-05-311-1/+7
| | | | | | Document r316485, qlnx(4) addition. Sponsored by: The FreeBSD Foundation
* MFC r319086:kib2017-05-311-2/+5
| | | | Mention that the basep argument to getdirentries(2) can be NULL.
* MFC r317632:ngie2017-05-311-1/+2
| | | | | | Fix "make cscope-clean" when .OBJDIR already exists The cscope generated files are always put in .CURDIR .
* MFC r316742:ngie2017-05-311-2/+2
| | | | | | Clarify units for mediasize and sectorsize in DoFile(..) They're byte quantities.
* MFC r316740:ngie2017-05-311-1/+2
| | | | | | | | Clarify `minfree` warning message in check_space(..) - State that the units are kB. - Be more complete/concise in terms of what is required (in this case `minfree` must be at least `X`kB)
* MFC r317311,r317312,r319019:ngie2017-05-311-2/+2
| | | | | | | | | | | | | | | | | | | | | | | r317311: Check for failures from getpagesize(3) Return errno on failure, similar to the open(2) call above it. CID: 1193753 r317312: Fix type for `pagesize` to match the return type for getpagesize(3) to fix the build Pointyhat to: ngie r319019: Remove getpagesize(3) error checking added in r317312 getpagesize(3) no longer fails as of r317436.
* MFC r319056,r319058,r319059,r319060,r319061,r319078:ngie2017-05-312-31/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r319056: tests/sys/file/ftruncate_test: use an exit code of 1 instead of -1 with err*(3). An exit code of -1 is implementation defined -- it's best to stick with something well-defined (1). r319058: Create a deterministic file in the kyua sandbox, instead of a temporary file outside the kyua sandbox This helps ensure that the file is removed at test exit, and as a side effect, cures a warning about umasks with Coverity. r319059: Use an exit code of 1 instead of -1 for reasons noted in r319056 r319060: Use main(void) instead of main(argc __unused, argv __unused) r319061: Don't leak accept_fd on thread completion CID: 1296068 r319078: Tweak r319058 slightly - Specify an explicit mode when using O_CREAT per open(2). - Fix the error message (add missing enclosing parentheses). MFC with: r319058
* MFC ↵ngie2017-05-319-97/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r319027,r319028,r319029,r319030,r319031,r319033,r319034,r319035,r319036,r319037,r319038,r319039,r319040,r319041,r319042,r319043,r319044,r319045,r319046: r319027: lib/libc/tests/nss: use calloc appropriately The pattern used prior to this commit was `calloc(1, n * sizeof(type))`; the pattern that should be used however is `calloc(n, sizeof(type))`. r319028: Sort make variables to suit style.Makefile(5) This is being done prior to functional changes. r319029: Staticize functions and remove unused variables to aid with bumping WARNS r319030: Fix -Wsign-compare warnings r319031: getusershell_test: staticize run_tests(..) to fix warnings r319033: getserv_test: fix -Wsign-compare and -Wmissing-prototypes warnings r319034: getaddrinfo_test: fix -Wsign-compare warnings r319035: getrpc_test: fix -Wmissing-prototypes and -Wsign-compare warnings r319036: getproto_test: fix -Wmissing-prototypes and -Wsign-compare warnings r319037: getaddrinfo_test: mark unused function parameters __unused to fix -Wunused warnings r319038: getusershell_test: mark mdata parameter in compare_usershell __unused r319039: getserv_test: mark unused parameters __unused to fix corresponding warnings r319040: getrpc_test: fix -Wunused warnings - Mark unused function parameters unused. - Remove an unused function prototype. r319041: getproto_test: fix -Wunused warnings Mark unused parameters __unused in functions. r319042: gethostby_test: fix multiple warning types - Fix -Wmissing-declaration warning by staticizing run_tests. - Fix -Wsign-compare warnings by casting size_t types to int for comparisons. Reindent some of the code in sdump_hostent(..) to accomodate the overall changes. r319043: getpw_test: fix -Wunused warnings - Mark unused parameters __unused. - Put dump_passwd under DEBUG as it's only used in that case. r319044: getgr_test: fix -Wunused warnings r319045: Fix -Wunused and -Wshadow warnings r319046: Fix a -Wunused-but-set-variable warning reported by gcc 6.3.0
* MFC r318514-r318515, r318517, r318917delphij2017-05-313-66/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r318514: Use size_t. Inspired by: OpenBSD src/lib/libc/stdlib/qsort.c,v 1.11 r318515: The current qsort(3) implementation ignores the sizes of partitions, and always perform recursion on the left partition, then use a tail call to handle the right partition. In the worst case this could require O(N) levels of recursions. Reduce the possible recursion level to log2(N) by always recursing on the smaller partition instead. Obtained from: PostgreSQL 9d6077abf9d6efd992a59f05ef5aba981ea32096 r318517: Sync qsort.c with userland r318515. (Note that MIN macro is removed in favor of sys/param.h's version). PR: 213922 r318917: Disconnect heimdal version of qsort.c from build because we are already using libc's version of qsort. PR: bin/213922
* Partial MFC r288030 (rodrigc):delphij2017-05-311-3/+1
| | | | Use ANSI C prototypes. Eliminates -Wold-style-definition warnings.
* MFC r279663,r279666 (pfg):delphij2017-05-311-22/+31
| | | | | | | | | | | | | | | | | | | | r279663: qsort(3): enhance to handle 32-bit aligned data on 64-bit systems Implement a small enhancement to the original qsort implementation: If the data is 32 bit aligned we can side-step the long type version and use int instead. The change brings a modest but significant improvement in 32 bit workloads. r279666: qsort(3): small style(9) cleanups. Basically spaces vs. tabs. No functional change.
* MFC r316649:delphij2017-05-311-1/+1
| | | | Add missing double quote to fix r316635 commit.
* MFC r311989 (cem):delphij2017-05-3110-28/+28
| | | | libkern: Remove obsolete 'register' keyword
* MFC r316635:delphij2017-05-311-13/+3
| | | | | | Enable 16-bit longest_match for x86. This gives a ~2% improvement in compression tests.
* MFC r313327:delphij2017-05-311-1/+1
| | | | Reflect actual NetBSD revision we already have.
OpenPOWER on IntegriCloud