summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * MFC r313568:ken2017-02-131-13/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ------------------------------------------------------------------------ r313568 | ken | 2017-02-10 15:02:45 -0700 (Fri, 10 Feb 2017) | 68 lines Change the isp(4) driver to not adjust the tag type for REQUEST SENSE. The isp(4) driver was changing the tag type for REQUEST SENSE commands to Head of Queue, when the CAM CCB flag CAM_TAG_ACTION_VALID was NOT set. CAM_TAG_ACTION_VALID is set when the tag action in the XPT_SCSI_IO is not CAM_TAG_ACTION_NONE and when the target has tagged queueing turned on. In most cases when CAM_TAG_ACTION_VALID is not set, it is because the target is not doing tagged queueing. In those cases, trying to send a Head of Queue tag may cause problems. Instead, default to sending a simple tag. IBM tape drives claim to support tagged queueing in their standard Inquiry data, but have the DQue bit set in the control mode page (mode page 10). CAM correctly detects that these drives do not support tagged queueing, and clears the CAM_TAG_ACTION_VALID flag on CCBs sent down to the drives. This caused the isp(4) driver to go down the path of setting the tag action to a default value, and for Request Sense commands only, set the tag action to Head of Queue. If an IBM tape drive does get a Head of Queue tag, it rejects it with Invalid Message Error (0x49,0x00). (The Qlogic firmware translates that to a Transport Error, which the driver translates to an Unrecoverable HBA Error, or CAM_UNREC_HBA_ERROR.) So, by default, it wasn't possible to get a good response from a REQUEST SENSE to an FC-attached IBM tape drive with the isp(4) driver. IBM tape drives (tested on an LTO-5 with G9N1 firmware and a TS1150 with 4470 firmware) also have a bug in that sending a command with a non-simple tag attribute breaks the tape drive's Command Reference Number (CRN) accounting and causes it to ignore all subsequent commands because it and the initiator disagree about the next expected CRN. The drives do reject the initial command with a head of queue tag with an Invalid Message Error (0x49,0x00), but after that they ignore any subsequent commands. IBM confirmed that it is a bug, and sent me test firmware that fixes the bug. However tape drives in the field will still exhibit the bug until they are upgraded. Request Sense is not often sent to targets because most errors are reported automatically through autosense in Fibre Channel and other modern transports. ("Modern" meaning post SCSI-2.) So this is not an error that would crop up frequently. But Request Sense is useful on tape devices to report status information, aside from error reporting. This problem is less serious without FC-Tape features turned on, specifically precise delivery of commands (which enables Command Reference Numbers), enabled on the target and initiator. Without FC-Tape features turned on, the target would return an error and things would continue on. And it also does not cause problems for targets that do tagged queueing, because in those cases the isp(4) driver just uses the tag type that is specified in the CCB, assuming the CAM_TAG_ACTION_VALID flag is set, and defaults to sending a Simple tag action if it isn't an ordered or head of queue tag. sys/dev/isp/isp.c: In isp_start(), don't try to send Request Sense commands with the Head of Queue tag attribute if the CCB doesn't have a valid tag action. The tag action likely isn't valid because the target doesn't support tagged queueing. Sponsored by: Spectra Logic ------------------------------------------------------------------------
| * MFC r313174: Clean up documentation of AF_UNIX control messages.jilles2017-02-122-60/+76
| | | | | | | | | | | | | | | | | | | | Document AF_UNIX control messages in unix(4) only, not split between unix(4) and recv(2). Also, warn about LOCAL_CREDS effective uid/gid fields, since the write could be from a setuid or setgid program (with the explicit SCM_CREDS and LOCAL_PEERCRED, the credentials are read at such a time that it can be assumed that the process intends for them to be used in this context).
| * MFC r313273:ngie2017-02-121-36/+23
| | | | | | | | | | | | | | | | style(9) cleanup - Delete trailing whitespace - Fix alignment/variable sorting - Delete single-line enclosing braces
| * Unbreak lib/csu for i386 and amd64 (MK_LIB32 == yes) after r313582ngie2017-02-111-1/+1
| | | | | | | | | | | | | | | | I accidentally goofed up the directory for lib/libc in the CFLAGS This is a direct commit to this branch Pointyhat to: ngie
| * MFC r311950 (by bz):cy2017-02-111-4/+4
| | | | | | | | | | | | | | | | Get rid of a compiler warning which I saw too often. Include netinet/in.h before ip_compat.t which will then check if IPPROTO_IPIP is defined or not. Doing it the other way round, ip_compat.h would not find it defined and netinet/in.h then redefine it.
| * MFC r312102,r312108:ngie2017-02-112-6/+7
| | | | | | | | | | | | | | | | | | | | r312102: Note that sys/types.h is required on FreeBSD for kqueue(2), unlike NetBSD r312108: Delete trailing whitespace and use __arraycount instead of nitems in contrib code
| * MFC r312513:ngie2017-02-111-17/+17
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312514:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312523:ngie2017-02-112-0/+52
| | | | | | | | | | | | | | Add some basic -s flag testcases for cut(1) The remaining functionality seems to be covered in one form or another via the NetBSD ATF testcase.
| * MFC r312508:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312507:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312506:ngie2017-02-112-3/+3
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312505:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312504:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312502:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312501:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312500:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312499:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312498:ngie2017-02-111-3/+3
| | | | | | | | | | | | Use SRCTOP-relative paths and .CURDIR with :H instead of ".." specified paths This simplifies pathing in make/displayed output
| * MFC r312497:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312495:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312494:ngie2017-02-111-2/+2
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312493:ngie2017-02-111-2/+2
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This simplifies pathing in make/displayed output
| * MFC r312491:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312490:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312489:ngie2017-02-111-11/+11
| | | | | | | | | | | | Use SRCTOP-relative paths and .CURDIR with :H instead of ".." specified paths This implifies pathing in make/displayed output
| * MFC r312486:ngie2017-02-111-3/+3
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312485:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312483:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312482:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312481:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312480:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312479:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312477:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312475:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312474:ngie2017-02-112-12/+12
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312473:ngie2017-02-111-2/+2
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312472:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312471:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312470:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312469:ngie2017-02-111-3/+3
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312468:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312467:ngie2017-02-119-15/+15
| | | | | | | | | | | | Use SRCTOP-relative paths and .CURDIR with :H instead of ".." specified paths This implifies pathing in make/displayed output
| * MFC r312466:ngie2017-02-111-3/+3
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312465:ngie2017-02-111-4/+3
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312464:ngie2017-02-111-3/+3
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312463:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * Unbreak the build after ^/stable/10@r313571ngie2017-02-111-1/+4
| | | | | | | | | | | | | | | | | | | | Update FILES per tests removed in beforementioned commit, which were accidentally overlooked, no doubt due to conflicts after base packaging work. This is a direct commit to ^/stable/10 Reported by: Jenkins (FreeBSD-stable-10-amd64-build job)
| * MFC r312462:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
| * MFC r312461:ngie2017-02-111-1/+1
| | | | | | | | | | | | Use SRCTOP-relative paths to other directories instead of .CURDIR-relative ones This implifies pathing in make/displayed output
OpenPOWER on IntegriCloud