summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* MFC r298881, 298882, 298883, 298885:pfg2016-05-1518-22/+22
| | | | | | | Minor spelling fixes in: tools, share, bluetooth, pmcstat, etc Many of these have user-visible strings.
* MFC r298031: Static pointers need not be initialized.cy2016-05-141-3/+3
|
* MFC r298030: Use NULL instead of 0 for pointer comparison.cy2016-05-142-5/+5
|
* MFC r275385 (by bapt):dim2016-05-14582-47702/+151911
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sync the svn template with the one from ports MFC r289180 (by peter): Update from svn-1.8.14 to 1.9.2. Formal release notes are available: https://subversion.apache.org/docs/release-notes/1.9.html Of particular note, the client checkout format has *not* changed so upgrades should *not* be required. When reading a repository (file:// or running as a local server), an improved fsfs version 7 is available with significant performance improvements. An optional upgrade is possible to use the new features. Without the upgrade, this is fully read/write compatible with the version 6 fsfs as in svn-1.8. MFC r298845: Update from subversion 1.9.2 to 1.9.4. This contains only bug fixes, no new features. The repository format is also unchanged from 1.9.2. Full list of changes between 1.9.4 and earlier versions: https://svn.apache.org/repos/asf/subversion/tags/1.9.4/CHANGES Note that the two security issues fixed in 1.9.4 (CVE-2016-2167 and CVE-2016-2168) do not affect the version of Subversion in the FreeBSD base system, since neither SASL nor Apache modules are enabled. MFC r298996: Re-sync the FreeBSD-specific Subversion template with the one from ports. Relnotes: yes
* MFC r298831:pfg2016-05-145-11/+11
| | | | boot/forth: minor spelling fixes.
* MFC r298829pfg2016-05-145-5/+5
| | | | sys/compat/linux*: minor spelling fixes.
* MFC r299694:markj2016-05-131-1/+1
| | | | Fix a bug in r298340: "sim" was referenced after being unset.
* MFC r298809, r298817pfg2016-05-133-14/+14
| | | | Minor spelling fixes.
* MFC r298839:ngie2016-05-131-3/+12
| | | | | | | | | Fix memory allocation edgecases in kvm_argv(..) - Don't leak nbufp on realloc failure in kvm_argv - Catch malloc errors with bufp - Set buflen last in the "buflen == 0" case to ensure that bufp/nbufp is properly reallocated on the next go around
* MFC r298842:ngie2016-05-131-0/+1
| | | | | | Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails CID: 1341474
* MFC r298844:ngie2016-05-132-1/+2
| | | | | | | Make SERVERS REQUIRE clean when MK_KERBEROS==no Make kdc run BEFORE SERVERS instead of being REQUIREd by SERVERS, so systems that pedantically check REQUIREs function after r270782
* MFC r299162,r299163:ngie2016-05-132-1/+11
| | | | | | | | | | | | | | | | | r299162: Only install NIS section 8 manpages if MK_NIS != no r299163: Fix r299162 share/man/man8/Makefile: - Add src.opts.mk so MK_NIS can be tested - Fix typo in MK_NIS conditional tools/build/mk/OptionalObsoleteFiles.inc: - Remove WIP diff from ^/user/ngie/detangle-rc
* MFC r298463:ngie2016-05-131-0/+2
| | | | | | | | Add FEATURE knob for testing for UFS extended attribute kernel support Support can be verified via `feature_present("ufs_extattr")`, etc. Relnotes: yes
* MFC r298462:ngie2016-05-131-1/+1
| | | | | | | | | | | Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning This will also now detect error conditions with value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)` could fail if iifp->physaddr and/or iifp->physaddrlen were deemed invalid. CID: 1006551
* MFC r298665:ngie2016-05-131-3/+5
| | | | | | | | | | | | r298665 (by cem): aacraid(4): Fix some mostly trivial buffer overruns strcpy(3) emits a trailing nul byte, trampling fields after the intended destination. Instead, use strncpy(3), intentionally leaving these fields not nul-terminated. CIDs: 1031024, 1305463, 1305494, 1305545
* MFC r298670:ngie2016-05-131-2/+2
| | | | | | | | | | | | r298670 (by cem): ciss(4): Fix overrun of array The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members. Most of the time it is iterated correctly. This patch fixes the two instances where the driver iterated off the end of the array. CID: 1305492
* MFC r298339:ngie2016-05-131-4/+4
| | | | | | | | | | r298339 (by cem): sound(4): Don't use-after-free in midi module unload Also, use ANSI function parameter definitions (void) while here. CID: 1006107
* MFC r298340:ngie2016-05-131-0/+1
| | | | | | | | r298340 (by cem): sym(4): Don't double-free 'sim' in failure case CID: 1006106
* MFC r298671,r298672:ngie2016-05-131-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | r298671 (by cem): g_part_bsd64: Check for valid on-disk npartitions value This value is u32 on disk, but assigned to an int in memory. After we do the implicit conversion via assignment, check that the result is at least one[1] (non-negative[2]). 1. The subsequent for-loop iterates from gpt_entries minus one, down, until reaching zero. A negative or zero initial index results in undefined signed integer overflow. 2. It is also used to index into arrays later. In practice, we expected non-malicious disks to contain small positive values. CID: 1223202 r298672 (by cem): g_part_bsd64: Delete duplicate/dead code RAW_PART is handled earlier in the loop. CID: 1223201
* MFC r298676:ngie2016-05-131-0/+1
| | | | | | | | r298676 (by cem): netipsec: Don't leak memory when deep copy fails CID: 1331693
* MFC r298677:ngie2016-05-131-4/+1
| | | | | | | | | | | | | r298677 (by cem): subr_mbpool: Don't free bogus pointer in error paths An mbpool is allocated with a contiguous array of mbpages. Freeing an individual mbpage has never been valid. Don't do it. This bug has been present since this code was introduced in r117624 (2003). CID: 1009687
* MFC r298337:ngie2016-05-131-1/+1
| | | | | | | | | | | | r298337 (by cem): pty(4): Use strlcpy to guarantee destination buffer isn't overrun The devtoname() name is strcpyed into a small stack buffer. Sure, we always expect the name to be ttyXX (or ptyXX). If that's the case, strlcpy() doesn't hurt. CID: 1006768
* MFC r298334:ngie2016-05-131-1/+3
| | | | | | | | | | r298334 (by cem): drm2(4): Fix double-free in low-memory error path Reallocf frees 'block'; don't attempt to free it again. CID: 1091165
* MFC r298669:ngie2016-05-131-2/+0
| | | | | | | | | | | | r298669 (by cem): iscsi_initiator(4): Fix use-after-free, double-free ism_stop() already destroys and frees 'sp', including a call to ic_destroy(). Don't dereference 'sp' after ism_stop() and don't invoke ic_destroy() on the freed memory either. CIDs: 1006109, 1304861
* MFC r298336:ngie2016-05-131-1/+1
| | | | | | | | | | | r298336 (by cem): kgssapi(4): Fix string overrun in Kerberos principal construction 'buf.value' was previously treated as a nul-terminated string, but only allocated with strlen() space. Rectify this. CID: 1007639
* MFC r295134,r298338,r298655:ngie2016-05-133-30/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r295134 (by cem): kcrypto_aes: Use separate sessions for AES and SHA1 Some hardware supports AES acceleration but not SHA1, e.g., AES-NI extensions. It is useful to have accelerated AES even if SHA1 must be software. Suggested by: asomers r298338 (by cem): kgssapi(4): Don't allow user-provided arguments to overrun stack buffer An over-long path argument to gssd_syscall could overrun the stack sockaddr_un buffer. Fix gssd_syscall to not permit that. If an over-long path is provided, gssd_syscall now returns EINVAL. It looks like PRIV_NFS_DAEMON isn't granted anywhere, so my best guess is that this is likely only triggerable by root. CID: 1006751 r298655 (by cem): kgssapi: Don't leak memory in error cases CIDs: 1007046, 1007047, 1007048
* MFC r298333:ngie2016-05-131-1/+2
| | | | | | | | | | | | | r298333 (by cem): Make Racct macro slightly more gracious given RACCT_UNDEFINED rctl_string_to_rule could previously index below the zeroth element of racct_types via the macro. Maybe it shouldn't use the macro on RACCT_UNDEFINED. But given every other RACCT_ definition is non-negative, it seems pretty easy to foot-shoot this one without the check. CID: 1305574
* MFC r298328:ngie2016-05-131-1/+1
| | | | | | | | | | | r298328 (by cem): bpf_getdltlist: Don't overrun 'lst' 'lst' is allocated with 'n1' members. 'n' indexes 'lst'. So 'n == n1' is an invalid 'lst' index. This is a follow-up to r296009. CID: 1352743
* MFC r298678:ngie2016-05-131-3/+3
| | | | | | | | | | | | r298678 (by cem): posix4_mib: Don't overrun facility_initialized array The facility_initialized and facility arrays are the same size and were intended to be indexed the same. I believe this mismatch was just a typo/braino in r208731. CID: 1017430
* MFC r297986, r298017 to vdev_geom.casomers2016-05-121-6/+24
| | | | | | | | | | | | | | r297986 | asomers | 2016-04-14 13:20:31 -0600 (Thu, 14 Apr 2016) | 6 lines Update a debugging message in vdev_geom_open_by_guids for consistency with similar messages elsewhere in the file. r298017 | asomers | 2016-04-14 17:14:41 -0600 (Thu, 14 Apr 2016) | 8 lines Add more debugging statements in vdev_geom.c Log a debugging message whenever geom functions fail in vdev_geom_attach. Printing these messages is controlled by vfs.zfs.debug
* MFC r298977: Fix a memory leak introduced with the devctl intergration ofscottl2016-05-121-0/+1
| | | | cam_periph
* MFC r299115:kib2016-05-123-4/+18
| | | | | Warn about consequences of suspending threads in arbitrary state of execution
* MFC r299114:kib2016-05-122-4/+2
| | | | | | | Do not leak THR_FLAGS_SUSPENDED from the previous suspend/resume cycle. PR: 209233
* MFC r298755:pfg2016-05-123-5/+5
| | | | | | sys/geom: spelling fixes. These affect debugging messages.
* MFC r299035: sh: Handle empty hostname and $PWD when building promptvangyzen2016-05-111-2/+3
| | | | | | If the hostname is empty and \h is used in $PS1, the remainder of the prompt following \h will be empty. Likewise for $PWD and \w. Fix it.
* MFC r299004: Work around (ignore) broken SRAT tablesvangyzen2016-05-111-2/+6
|
* MFC r296300:markj2016-05-111-1/+1
| | | | Fix a typo that prevented pw(8) from setting a user's UID to 0.
* MFC r297832: MFV r297831: 6322 ZFS indirect block predictive prefetchmav2016-05-115-23/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Paul Dagnelie <pcd@delphix.com> Author: Alexander Motin <mav@FreeBSD.org> Improve speculative prefetch of indirect blocks. Scalability of many operations on wide ZFS pool can be limited by requirement to prefetch indirect blocks first. Recently added asynchronous indirect block read partially helped, but did not solve the problem completely. This patch extends existing prefetcher functionality to explicitly work with indirect blocks. Before this change prefetcher issued reads for up to 8MB of data in advance. With this change it also issues indirect block reads for up to 64MB of data in advance, so that when it will be time to actually read those data, it can be done immediately. Alike effect can be achieved by just increasing maximal data prefetch distance, but at higher memory cost. Also this change introduces indirect block prefetch for rewrite operations, that was never done before. Previously ARC miss for Indirect blocks regularly blocked rewrites, converting perfectly aligned asynchronous operations into synchronous read-write pairs, significantly reducing maximal rewrite speed. While being there this issue was also fixed: - prefetch was done always, even if caching for the dataset was completely disabled. Testing on FreeBSD with zvol on top of 6x striped 2x mirrored pool of 12 assorted HDDs shown me such performance numbers: ------- BEFORE -------- Write 491363677 bytes/sec Read 312430631 bytes/sec Rewrite 97680464 bytes/sec -------- AFTER -------- Write 493524146 bytes/sec Read 438598079 bytes/sec Rewrite 277506044 bytes/sec Closes #65 Closes #80 openzfs/openzfs@792fd28ac04f78cc5e43ead2d72a96f244ea84e8
* MFC r297509: MFV r297506: 6738 zfs send stream padding needs documentationmav2016-05-111-1/+17
| | | | | | | | | | | Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed by: Paul Dagnelie <pcd@delphix.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Approved by: Robert Mustacchi <rm@joyent.com> Author: Eli Rosenthal <eli.rosenthal@delphix.com> illumos/illumos-gate@c20404ff77119516354b0d112d28b7ea0dadd303
* MFC r297507: MFV r297504:mav2016-05-111-7/+6
| | | | | | | | | | | | 6681 zfs list burning lots of time in dodefault() via dsl_prop_* Reviewed by: Patrick Mooney <patrick.mooney@joyent.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Approved by: Matthew Ahrens <mahrens@delphix.com> Author: Alex Wilson <alex.wilson@joyent.com> illumos/illumos-gate@d09e4475f635b6f66ee68d8c17a32bba7be17c96
* MFC r297763: MFV r297760: 6418 zpool should have a label clearing commandmav2016-05-116-86/+115
| | | | | | | | | | | | | | | Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Author: Will Andrews <will@firepipe.net> Closes #83 Closes #32 openzfs/openzfs@9663688425131744221ea99f9e66b9ed964492ae FreeBSD already had `zpool labelclear` functionality, so this is mostly just a diff reduction.
* MFC r297508: MFV r297505:mav2016-05-112-3/+7
| | | | | | | | | | | | | 6739 userland version of cv_timedwait_hires() always assumes absolute time Reviewed by: Paul Dagnelie <pcd@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Reviewed by: Robert Mustacchi <rm@joyent.com> Approved by: Robert Mustacchi <rm@joyent.com> Author: George Wilson <george.wilson@delphix.com> illumos/illumos-gate@41c6413cb54bf338d7a59ed789ec2e0e44c35e6f
* MFC r298703:pfg2016-05-112-10/+10
| | | | | | | | | | cam: unsign some types to match their definitions and avoid overflows. numpatterns is u_int. ctl: CTL_NUM_MODE_PAGES comes from sizeof(). In struct:ctl_scsiio, kern_sg_entries is uint32_t.
* MFC r298698:pfg2016-05-115-10/+10
| | | | | | | | | | | | | | | geom: unsign some types to match their definitions and avoid overflows. In struct:gctl_req, nargs is unsigned. In mirror: g_mirror_syncreqs is unsigned. In raid: in struct:g_raid_volume, v_disks_count is unsigned. In virstor: in struct:g_virstor_softc, n_components is unsigned.
* MFC r298904:wblock2016-05-1011-13/+13
| | | | | Spelling fixes supplied by pfg@, detected with codespell, plus additional misspellings detected by igor.
* MFC 294923asomers2016-05-101-0/+8
| | | | | | | | | | Fix grep_test:recurse with ZFS and TMPFS tmpdirs contrib/netbsd-tests/usr.bin/grep/t_grep.sh Fix grep_test:recurse when /tmp is either zfs or tmpfs. The test was relying on an implicit ordering of directory recursion which happens to be true when using UFS. grep's specification requires no such ordering. The solution is to ignore the order of grep's results.
* MFC 297868asomers2016-05-101-16/+3
| | | | | | | | | | | | | | | | | | | | Fix rare double free in vdev_geom_attrchanged sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c Don't drop the g_topology_lock before freeing old_physpath. That opens up a race where one thread can call vdev_geom_attrchanged, set old_physpath, drop the g_topology_lock, then block trying to acquire the SCL_STATE lock. Then another thread can come into vdev_geom_attrchanged, set old_physpath to the same value, and proceed to free it. When the first thread resumes, it will free the same location. It turns out that the SCL_STATE lock isn't needed. It was originally added by gibbs to protect vd->vdev_physpath while updating the same. However, the update process subsequently was switched to an atomic operation (a pointer swap). Now, there is no need for the SCL_STATE lock, and hence no need to drop the g_topology_lock.
* MFC 299205: Restore name=value format of PCI location strings.jhb2016-05-101-1/+2
| | | | | | | | | | When devctl was added, the location string for PCI devices was changed to use the PCI "selector" that pciconf and devctl accept. However, devd assumes that location strings are formatted as a list of name=value pairs. As a result, devd is no longer parsing any of the values out of PCI device events. Restore the previous format of the PCI location strings to restore the location and slot keywords in case any devd scripts are using this. Add the "selector" as a new 'dbsf' location variable.
* MFC r298591davidcs2016-05-102-3/+2
| | | | | 1. Removed -Wno-shift-negative-value from Makefile 2. Fixed warning its absence caused in bxe_elink.c
* MFC r298496davidcs2016-05-101-141/+0
| | | | Remove Unused/Dead Code
OpenPOWER on IntegriCloud