diff options
Diffstat (limited to 'test/SemaCXX/warn-redundant-move.cpp')
| -rw-r--r-- | test/SemaCXX/warn-redundant-move.cpp | 72 |
1 files changed, 48 insertions, 24 deletions
diff --git a/test/SemaCXX/warn-redundant-move.cpp b/test/SemaCXX/warn-redundant-move.cpp index feb9e6f..abfb001 100644 --- a/test/SemaCXX/warn-redundant-move.cpp +++ b/test/SemaCXX/warn-redundant-move.cpp @@ -1,5 +1,6 @@ // RUN: %clang_cc1 -fsyntax-only -Wredundant-move -std=c++11 -verify %s // RUN: %clang_cc1 -fsyntax-only -Wredundant-move -std=c++11 -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -ast-dump | FileCheck %s --check-prefix=CHECK-AST // definitions for std::move namespace std { @@ -12,6 +13,7 @@ template <class T> typename remove_reference<T>::type &&move(T &&t); } } +// test1 and test2 should not warn until after implementation of DR1579. struct A {}; struct B : public A {}; @@ -20,15 +22,7 @@ A test1(B b1) { return b1; return b2; return std::move(b1); - // expected-warning@-1{{redundant move}} - // expected-note@-2{{remove std::move call}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" - // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:22-[[@LINE-4]]:23}:"" return std::move(b2); - // expected-warning@-1{{redundant move}} - // expected-note@-2{{remove std::move call}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" - // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:22-[[@LINE-4]]:23}:"" } struct C { @@ -46,25 +40,9 @@ C test2(A a1, B b1) { return b2; return std::move(a1); - // expected-warning@-1{{redundant move}} - // expected-note@-2{{remove std::move call}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" - // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:22-[[@LINE-4]]:23}:"" return std::move(a2); - // expected-warning@-1{{redundant move}} - // expected-note@-2{{remove std::move call}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" - // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:22-[[@LINE-4]]:23}:"" return std::move(b1); - // expected-warning@-1{{redundant move}} - // expected-note@-2{{remove std::move call}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" - // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:22-[[@LINE-4]]:23}:"" return std::move(b2); - // expected-warning@-1{{redundant move}} - // expected-note@-2{{remove std::move call}} - // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" - // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:22-[[@LINE-4]]:23}:"" } // Copy of tests above with types changed to reference types. @@ -90,3 +68,49 @@ C test4(A& a1, B& b1) { return std::move(b1); return std::move(b2); } + +// PR23819, case 2 +struct D {}; +D test5(D d) { + return d; + // Verify the implicit move from the AST dump + // CHECK-AST: ReturnStmt{{.*}}line:[[@LINE-2]] + // CHECK-AST-NEXT: CXXConstructExpr{{.*}}struct D{{.*}}void (struct D &&) + // CHECK-AST-NEXT: ImplicitCastExpr + // CHECK-AST-NEXT: DeclRefExpr{{.*}}ParmVar{{.*}}'d' + + return std::move(d); + // expected-warning@-1{{redundant move in return statement}} + // expected-note@-2{{remove std::move call here}} + // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:10-[[@LINE-3]]:20}:"" + // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:21-[[@LINE-4]]:22}:"" +} + +namespace templates { + struct A {}; + struct B { B(A); }; + + // Warn once here since the type is not dependent. + template <typename T> + A test1(A a) { + return std::move(a); + // expected-warning@-1{{redundant move in return statement}} + // expected-note@-2{{remove std::move call here}} + // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:22}:"" + // CHECK: fix-it:"{{.*}}":{[[@LINE-4]]:23-[[@LINE-4]]:24}:"" + } + void run_test1() { + test1<A>(A()); + test1<B>(A()); + } + + // T1 and T2 may not be the same, the warning may not always apply. + template <typename T1, typename T2> + T1 test2(T2 t) { + return std::move(t); + } + void run_test2() { + test2<A, A>(A()); + test2<B, A>(A()); + } +} |
