diff options
| author | wpaul <wpaul@FreeBSD.org> | 1998-02-11 19:15:32 +0000 |
|---|---|---|
| committer | wpaul <wpaul@FreeBSD.org> | 1998-02-11 19:15:32 +0000 |
| commit | 02d038fd998585a7608df56138da13e4055bdfd9 (patch) | |
| tree | 5ae4bf5154055f173471b14854e0c97cf969c450 /usr.sbin/ypserv/Makefile | |
| parent | 2f8caa4fd654ed1b60b4125cc7de07882455bddb (diff) | |
| download | FreeBSD-src-02d038fd998585a7608df56138da13e4055bdfd9.zip FreeBSD-src-02d038fd998585a7608df56138da13e4055bdfd9.tar.gz | |
Fix a bug in the database handle caching. This has to do with the way the
underlying database code works. When dealing with first/next queries, you
have the notion of a database 'cursor,' which is essentially a file pointer
for the database. To select the first entry, you do a fetch with the
R_FIRST flag set, then you can use the R_NEXT flag to enumerate the other
entries in the database. Unfortunately, doing a direct fetch with no flag
does _not_ set the 'cursor,' so you can't do a direct fetch and then
enumerate the table from there.
The bug is that cached handles generated as the result of a YPPROC_MATCH
were being treated as though they were the same as handles generated by
a YPPROC_FIRST, which is not the case. The manifestation is that if you
do a 'ypmatch first-key-in-map map' followed by a yp_first()/yp_next()
pair, the yp_first() and yp_next() both return the first key in the
table, which makes the entry appear to be duplicated.
A couple smaller things since I'm here:
- yp_main.c and yp_error.c both have a global 'int debug' in them.
For some reason, our cc/ld doesn't flag this as a multiply defined
symbol even though it should. Removed the declaration from yp_main.c;
we want the one in yp_error.c.
- The Makefile wasn't installing ypinit in the right place.
Diffstat (limited to 'usr.sbin/ypserv/Makefile')
| -rw-r--r-- | usr.sbin/ypserv/Makefile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr.sbin/ypserv/Makefile b/usr.sbin/ypserv/Makefile index 76fe709..937c467 100644 --- a/usr.sbin/ypserv/Makefile +++ b/usr.sbin/ypserv/Makefile @@ -1,4 +1,4 @@ -# $Id: Makefile,v 1.3 1997/11/10 21:22:17 wpaul Exp $ +# $Id: Makefile,v 1.12 1997/11/10 22:17:09 wpaul Exp $ PROG= ypserv SRCS= yp_svc.c yp_server.c yp_dblookup.c yp_dnslookup.c \ @@ -33,7 +33,7 @@ afterinstall: ${.CURDIR}/Makefile.yp \ ${DESTDIR}/var/yp/Makefile.dist ${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 555 \ - ${.CURDIR}/ypinit.sh ${BINDIR}/ypinit + ${.CURDIR}/ypinit.sh ${DESTDIR}/${BINDIR}/ypinit @if [ ! -f ${DESTDIR}/var/yp/Makefile.dist ]; then \ ln -s ${DESTDIR}/var/yp/Makefile.dist \ ${DESTDIR}/var/yp/Makefile; fi |
