Completely rip-out and redesign sysinstall's refresh model as well

as redoing all the menus to have proper, or at least non-hallucinogenic,
keyboard accelerators.

This requires my recent update to libdialog to work properly and will
probably also exhibit some other "interesting" behavior while the last
few missing screen clears are found (which is why I'm not going to MFC
immediately).  At least now, however, sysinstall does not gratuitously
redraw random screens at the drop of a hat and drive serial console
installers out of their minds.

1 files changed, 4 insertions, 5 deletions

diff --git a/usr.sbin/sysinstall/doc.c b/usr.sbin/sysinstall/doc.c
index 513259a..5a873d1 100644
--- a/usr.sbin/sysinstall/doc.c
+++ b/usr.sbin/sysinstall/doc.c
@@ -72,14 +72,14 @@ docBrowser(dialogMenuItem *self)
 		      "not appear to be correct.   Would you like me to do that now?",
 		      browser, variable_get(VAR_BROWSER_BINARY)))
 	    vsystem("pkg_delete %s %s", !strcmp(variable_get(VAR_CPIO_VERBOSITY), "high") ? "-v" : "", browser);
-	return DITEM_FAILURE | DITEM_RESTORE;
+	return DITEM_FAILURE;
     }
 
     /* Run browser on the appropriate doc */
     if (dmenuOpenSimple(&MenuHTMLDoc, FALSE))
-	return DITEM_SUCCESS | DITEM_RESTORE;
+	return DITEM_SUCCESS;
     else
-	return DITEM_FAILURE | DITEM_RESTORE;
+	return DITEM_FAILURE;
 }
 
 /* Try to show one of the documents requested from the HTML doc menu */
@@ -114,9 +114,8 @@ docShowDocument(dialogMenuItem *self)
     }
     if (where) {
 	sprintf(tmp, "%s %s", browser, where);
-	dialog_clear();
 	systemExecute(tmp);
-	return DITEM_SUCCESS | DITEM_RESTORE;
+	return DITEM_SUCCESS;
     }
     else {
 	msgConfirm("Hmmmmm!  I can't seem to access the documentation you selected!\n"