Fix a few bugs, some of which I introduced in recent commits:

- clean_mtab():
    Actually use the strdup'd version of the host that we go to the
    trouble of creating.
- do_umntall/do_umount:
    Don't return success if clnt_create() fails.
    Don't access a client pointer after it has been destroyed.
    Remember to destroy the authentication information we created.

1 files changed, 1 insertions, 1 deletions

diff --git a/usr.sbin/rpc.umntall/mounttab.c b/usr.sbin/rpc.umntall/mounttab.c
index d4b1865..01ce78c 100644
--- a/usr.sbin/rpc.umntall/mounttab.c
+++ b/usr.sbin/rpc.umntall/mounttab.c
@@ -189,7 +189,7 @@ clean_mtab(char *hostp, char *dirp, int verbose) {
 	/* Copy hostp in case it points to an entry that we are zeroing out. */
 	host = strdup(hostp);
 	for (mtabp = mtabhead; mtabp != NULL; mtabp = mtabp->mtab_next) {
-		if (strcmp(mtabp->mtab_host, hostp) != 0)
+		if (strcmp(mtabp->mtab_host, host) != 0)
 			continue;
 		if (dirp != NULL && strcmp(mtabp->mtab_dirp, dirp) != 0)
 			continue;