o De-staticise things that don't need to be static.

o Bring the static ``ttystate'' into struct prompt so that
  the tilde context is per prompt and not global.
o Comment the remaining static variables so that it's
  clear why they're static.
o Add some XXX comments suggesting that our interface list
  and our hostname should be re-generated after a signal
  (say SIGUSR1) so that a machine with PCCARDs has a chance.

1 files changed, 9 insertions, 3 deletions

diff --git a/usr.sbin/ppp/route.c b/usr.sbin/ppp/route.c
index d4ac9ed..328c047 100644
--- a/usr.sbin/ppp/route.c
+++ b/usr.sbin/ppp/route.c
@@ -17,7 +17,7 @@
  * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED
  * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  *
- * $Id: route.c,v 1.46 1998/06/10 00:16:07 brian Exp $
+ * $Id: route.c,v 1.47 1998/06/15 19:06:23 brian Exp $
  *
  */
 
@@ -194,8 +194,14 @@ p_flags(struct prompt *prompt, u_long f, int max)
 const char *
 Index2Nam(int idx)
 {
-  static char **ifs;
-  static int nifs, debug_done;
+  /*
+   * XXX: Maybe we should select() on the routing socket so that we can
+   *      notice interfaces that come & go (PCCARD support).
+   *      Or we could even support a signal that resets these so that
+   *      the PCCARD insert/remove events can signal ppp.
+   */
+  static char **ifs;		/* Figure these out once */
+  static int nifs, debug_done;	/* Figure out how many once, and debug once */
 
   if (!nifs) {
     int mib[6], have, had;