diff options
| author | brian <brian@FreeBSD.org> | 1997-12-18 01:10:13 +0000 |
|---|---|---|
| committer | brian <brian@FreeBSD.org> | 1997-12-18 01:10:13 +0000 |
| commit | ad6dc08636347bbd8aebe3658eabf43dadb4aa90 (patch) | |
| tree | aafc13d009a2e0a3d0723158fd0477a09d74d91e /usr.sbin/ppp/modem.c | |
| parent | 71fc17164f9d8dcc7f930336a677c5601e0255dd (diff) | |
| download | FreeBSD-src-ad6dc08636347bbd8aebe3658eabf43dadb4aa90.zip FreeBSD-src-ad6dc08636347bbd8aebe3658eabf43dadb4aa90.tar.gz | |
Replace
strcpy(a, b); /* a and b are the same size */
with
strncpy(a, b, sizeof(a));
a[sizeof(a)-1] = '\0';
Making the code `correct at a glance'.
Suggested by: Theo de Raadt <deraadt@cvs.openbsd.org>
Diffstat (limited to 'usr.sbin/ppp/modem.c')
| -rw-r--r-- | usr.sbin/ppp/modem.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/usr.sbin/ppp/modem.c b/usr.sbin/ppp/modem.c index cef758d..014dd8a 100644 --- a/usr.sbin/ppp/modem.c +++ b/usr.sbin/ppp/modem.c @@ -17,7 +17,7 @@ * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. * - * $Id: modem.c,v 1.66 1997/11/18 14:52:06 brian Exp $ + * $Id: modem.c,v 1.67 1997/11/22 03:37:41 brian Exp $ * * TODO: */ @@ -680,7 +680,8 @@ HangupModem(int flag) if (modem >= 0) { char ScriptBuffer[SCRIPT_LEN]; - strcpy(ScriptBuffer, VarHangupScript); /* arrays are the same size */ + strncpy(ScriptBuffer, VarHangupScript, sizeof(ScriptBuffer)); + ScriptBuffer[sizeof(ScriptBuffer) - 1] = '\0'; LogPrintf(LogDEBUG, "HangupModem: Script: %s\n", ScriptBuffer); if (flag || !(mode & MODE_DEDICATED)) { DoChat(ScriptBuffer); |
