Notice and warn about unterminated quoted strings in commands.

The entire command is ignored if the syntax is invalid...

1 files changed, 8 insertions, 3 deletions

diff --git a/usr.sbin/ppp/exec.c b/usr.sbin/ppp/exec.c
index d1f3f64..0ded3cb 100644
--- a/usr.sbin/ppp/exec.c
+++ b/usr.sbin/ppp/exec.c
@@ -141,15 +141,20 @@ exec_Create(struct physical *p)
 
           log_Printf(LogDEBUG, "Exec'ing ``%s''\n", p->name.base);
 
+          if ((argc = MakeArgs(p->name.base, argv, VECSIZE(argv))) < 0) {
+            log_Printf(LogWARN, "Syntax error in exec command\n");
+            _exit(127);
+          }
+
+          command_Expand(argv, argc, (char const *const *)argv,
+                         p->dl->bundle, 0, realpid);
+
           dup2(fids[1], STDIN_FILENO);
           dup2(fids[1], STDOUT_FILENO);
           dup2(fids[1], STDERR_FILENO);
           for (i = getdtablesize(); i > STDERR_FILENO; i--)
             fcntl(i, F_SETFD, 1);
 
-          argc = MakeArgs(p->name.base, argv, VECSIZE(argv));
-          command_Expand(argv, argc, (char const *const *)argv,
-                         p->dl->bundle, 0, realpid);
           execvp(*argv, argv);
           printf("execvp failed: %s: %s\r\n", *argv, strerror(errno));
           _exit(127);