diff options
| author | attilio <attilio@FreeBSD.org> | 2011-08-07 18:37:05 +0000 |
|---|---|---|
| committer | attilio <attilio@FreeBSD.org> | 2011-08-07 18:37:05 +0000 |
| commit | 18728bba7168d9fe3ad61b25beaa7a8c9bc10664 (patch) | |
| tree | ae555cee6f8bd0c9014e1f72795900cc72b5f198 /usr.sbin/pmcstat/pmcstat.h | |
| parent | d5a429b2e4110c4c333667ce5db2f6b094707707 (diff) | |
| download | FreeBSD-src-18728bba7168d9fe3ad61b25beaa7a8c9bc10664.zip FreeBSD-src-18728bba7168d9fe3ad61b25beaa7a8c9bc10664.tar.gz | |
Convert pmcstat about using cpuset_t rather than relying on plain 32 bit
ints. That fixes a first bug where pmcstat wasn't using the old
cpumask_t interface and now also brings the full support for more
than 32 cpus.
While here, make the functions pmcstat_clone_event_descriptor() and
pmcstat_get_cpumask() private to pmcstat.
The problem of assuming cpu dense masks still persists and should be
eventually fixed, as reported by avg.
Tested by: pluknet
Reviewed by: gnn
Approved by: re (kib)
Diffstat (limited to 'usr.sbin/pmcstat/pmcstat.h')
| -rw-r--r-- | usr.sbin/pmcstat/pmcstat.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/usr.sbin/pmcstat/pmcstat.h b/usr.sbin/pmcstat/pmcstat.h index c9c24a9..6b64b76 100644 --- a/usr.sbin/pmcstat/pmcstat.h +++ b/usr.sbin/pmcstat/pmcstat.h @@ -33,6 +33,8 @@ #ifndef _PMCSTAT_H_ #define _PMCSTAT_H_ +#include <sys/_cpuset.h> + #define FLAG_HAS_TARGET 0x00000001 /* process target */ #define FLAG_HAS_WAIT_INTERVAL 0x00000002 /* -w secs */ #define FLAG_HAS_OUTPUT_LOGFILE 0x00000004 /* -O file or pipe */ @@ -140,7 +142,7 @@ struct pmcstat_args { FILE *pa_graphfile; /* where to send the callgraph */ int pa_graphdepth; /* print depth for callgraphs */ double pa_interval; /* printing interval in seconds */ - uint32_t pa_cpumask; /* filter for CPUs analysed */ + cpuset_t pa_cpumask; /* filter for CPUs analysed */ int pa_ctdumpinstr; /* dump instructions with calltree */ int pa_topmode; /* delta or accumulative */ int pa_toptty; /* output to tty or file */ @@ -159,8 +161,6 @@ extern struct pmcstat_args args; /* command line args */ /* Function prototypes */ void pmcstat_attach_pmcs(void); void pmcstat_cleanup(void); -void pmcstat_clone_event_descriptor( - struct pmcstat_ev *_ev, uint32_t _cpumask); int pmcstat_close_log(void); void pmcstat_create_process(void); void pmcstat_find_targets(const char *_arg); @@ -178,7 +178,6 @@ int pmcstat_process_log(void); int pmcstat_keypress_log(void); void pmcstat_display_log(void); void pmcstat_pluginconfigure_log(char *_opt); -uint32_t pmcstat_get_cpumask(const char *_a); void pmcstat_topexit(void); #endif /* _PMCSTAT_H_ */ |
