Remove "extern" from function prototypes, and fix some (but not all)

style(9) violations.

MFC after:	1 week

1 files changed, 51 insertions, 65 deletions

diff --git a/usr.sbin/nscd/protocol.h b/usr.sbin/nscd/protocol.h
index 2df9b81..dea2397 100644
--- a/usr.sbin/nscd/protocol.h
+++ b/usr.sbin/nscd/protocol.h
@@ -37,8 +37,7 @@
 #define BUFSIZE_INVALID(x) (!BUFSIZE_CORRECT(x))
 
 /* structures below represent the data that are sent/received by the daemon */
-struct cache_write_request
-{
+struct cache_write_request {
 	char	*entry;
 	char	*cache_key;
 	char	*data;
@@ -48,13 +47,11 @@ struct cache_write_request
 	size_t	data_size;
 };
 
-struct cache_write_response
-{
+struct cache_write_response {
 	int	error_code;
 };
 
-struct cache_read_request
-{
+struct cache_read_request {
 	char	*entry;
 	char	*cache_key;
 
@@ -62,8 +59,7 @@ struct cache_read_request
 	size_t	cache_key_size;
 };
 
-struct cache_read_response
-{
+struct cache_read_response {
 	char	*data;			// ignored if error_code is not 0
 	size_t	data_size;		// ignored if error_code is not 0
 
@@ -75,16 +71,14 @@ enum transformation_type {
 	TT_ALL = 1	// transform all entries
 };
 
-struct cache_transform_request
-{
+struct cache_transform_request {
 	char	*entry; 		// ignored if entry_length is 0
 	size_t	entry_length;
 
 	int	transformation_type;
 };
 
-struct cache_transform_response
-{
+struct cache_transform_response {
 	int	error_code;
 };
 
@@ -149,8 +143,7 @@ enum comm_element_t {
  * The comm_element is used as the holder of any known (defined above) data
  * type that is to be sent/received.
  */
-struct comm_element
-{
+struct comm_element {
 	union {
 	struct cache_write_request c_write_request;
 	struct cache_write_response c_write_response;
@@ -167,97 +160,90 @@ struct comm_element
 	struct cache_mp_read_session_request c_mp_rs_request;
 	struct cache_mp_read_session_response c_mp_rs_response;
 	struct cache_mp_read_session_read_response c_mp_rs_read_response;
-	};
+	} /* anonymous */;
 	enum comm_element_t type;
 };
 
-extern void init_comm_element(struct comm_element *, enum comm_element_t type);
-extern void finalize_comm_element(struct comm_element *);
+void init_comm_element(struct comm_element *, enum comm_element_t type);
+void finalize_comm_element(struct comm_element *);
 
 /*
  * For each type of data, there is three functions (init/finalize/get), that
  * used with comm_element structure
  */
-extern void init_cache_write_request(struct cache_write_request *);
-extern void finalize_cache_write_request(struct cache_write_request *);
-extern struct cache_write_request *get_cache_write_request(
-	struct comm_element *);
+void init_cache_write_request(struct cache_write_request *);
+void finalize_cache_write_request(struct cache_write_request *);
+struct cache_write_request *get_cache_write_request(struct comm_element *);
 
-extern void init_cache_write_response(struct cache_write_response *);
-extern void finalize_cache_write_response(struct cache_write_response *);
-extern struct cache_write_response *get_cache_write_response(
-	struct comm_element *);
+void init_cache_write_response(struct cache_write_response *);
+void finalize_cache_write_response(struct cache_write_response *);
+struct cache_write_response *get_cache_write_response(struct comm_element *);
 
-extern void init_cache_read_request(struct cache_read_request *);
-extern void finalize_cache_read_request(struct cache_read_request *);
-extern struct cache_read_request *get_cache_read_request(
-	struct comm_element *);
+void init_cache_read_request(struct cache_read_request *);
+void finalize_cache_read_request(struct cache_read_request *);
+struct cache_read_request *get_cache_read_request(struct comm_element *);
 
-extern void init_cache_read_response(struct cache_read_response *);
-extern void finalize_cache_read_response(struct cache_read_response *);
-extern struct cache_read_response *get_cache_read_response(
-	struct comm_element *);
+void init_cache_read_response(struct cache_read_response *);
+void finalize_cache_read_response(struct cache_read_response *);
+struct cache_read_response *get_cache_read_response(struct comm_element *);
 
-extern void init_cache_transform_request(struct cache_transform_request *);
-extern void finalize_cache_transform_request(struct cache_transform_request *);
-extern struct cache_transform_request *get_cache_transform_request(
+void init_cache_transform_request(struct cache_transform_request *);
+void finalize_cache_transform_request(struct cache_transform_request *);
+struct cache_transform_request *get_cache_transform_request(
 	struct comm_element *);
 
-extern void init_cache_transform_response(struct cache_transform_response *);
-extern void finalize_cache_transform_response(
-	struct cache_transform_response *);
-extern struct cache_transform_response *get_cache_transform_response(
+void init_cache_transform_response(struct cache_transform_response *);
+void finalize_cache_transform_response(struct cache_transform_response *);
+struct cache_transform_response *get_cache_transform_response(
 	struct comm_element *);
 
-extern void init_cache_mp_write_session_request(
+void init_cache_mp_write_session_request(
 	struct cache_mp_write_session_request *);
-extern void finalize_cache_mp_write_session_request(
+void finalize_cache_mp_write_session_request(
 	struct cache_mp_write_session_request *);
-extern struct cache_mp_write_session_request *
-    	get_cache_mp_write_session_request(
-	struct comm_element *);
+struct cache_mp_write_session_request *
+    	get_cache_mp_write_session_request(struct comm_element *);
 
-extern void init_cache_mp_write_session_response(
+void init_cache_mp_write_session_response(
 	struct cache_mp_write_session_response *);
-extern void finalize_cache_mp_write_session_response(
+void finalize_cache_mp_write_session_response(
 	struct cache_mp_write_session_response *);
-extern struct cache_mp_write_session_response *
+struct cache_mp_write_session_response *
 	get_cache_mp_write_session_response(struct comm_element *);
 
-extern void init_cache_mp_write_session_write_request(
+void init_cache_mp_write_session_write_request(
 	struct cache_mp_write_session_write_request *);
-extern void finalize_cache_mp_write_session_write_request(
+void finalize_cache_mp_write_session_write_request(
 	struct cache_mp_write_session_write_request *);
-extern struct cache_mp_write_session_write_request *
+struct cache_mp_write_session_write_request *
 	get_cache_mp_write_session_write_request(struct comm_element *);
 
-extern void init_cache_mp_write_session_write_response(
+void init_cache_mp_write_session_write_response(
 	struct cache_mp_write_session_write_response *);
-extern void finalize_cache_mp_write_session_write_response(
+void finalize_cache_mp_write_session_write_response(
 	struct cache_mp_write_session_write_response *);
-extern struct cache_mp_write_session_write_response *
+struct cache_mp_write_session_write_response *
 	get_cache_mp_write_session_write_response(struct comm_element *);
 
-extern void init_cache_mp_read_session_request(
+void init_cache_mp_read_session_request(
 	struct cache_mp_read_session_request *);
-extern void finalize_cache_mp_read_session_request(
+void finalize_cache_mp_read_session_request(
 	struct cache_mp_read_session_request *);
-extern struct cache_mp_read_session_request *get_cache_mp_read_session_request(
+struct cache_mp_read_session_request *get_cache_mp_read_session_request(
 	struct comm_element *);
 
-extern void init_cache_mp_read_session_response(
+void init_cache_mp_read_session_response(
 	struct cache_mp_read_session_response *);
-extern void finalize_cache_mp_read_session_response(
+void finalize_cache_mp_read_session_response(
 	struct cache_mp_read_session_response *);
-extern struct cache_mp_read_session_response *
-    	get_cache_mp_read_session_response(
-	struct comm_element *);
+struct cache_mp_read_session_response *
+    	get_cache_mp_read_session_response(struct comm_element *);
 
-extern void init_cache_mp_read_session_read_response(
+void init_cache_mp_read_session_read_response(
 	struct cache_mp_read_session_read_response *);
-extern void finalize_cache_mp_read_session_read_response(
+void finalize_cache_mp_read_session_read_response(
 	struct cache_mp_read_session_read_response *);
-extern struct cache_mp_read_session_read_response *
+struct cache_mp_read_session_read_response *
 	get_cache_mp_read_session_read_response(struct comm_element *);
 
 #endif