diff options
author | jhb <jhb@FreeBSD.org> | 2014-04-22 15:17:32 +0000 |
---|---|---|
committer | jhb <jhb@FreeBSD.org> | 2014-04-22 15:17:32 +0000 |
commit | 5022630d02f5b911fe694cc20729470ba0fd4ba9 (patch) | |
tree | c59f81394d3e1c00dcaf36382173ec1b0679b0f8 /usr.sbin/mfiutil | |
parent | e0eab30ea6b68b98dc68f4728bbc07d8c02fd52d (diff) | |
download | FreeBSD-src-5022630d02f5b911fe694cc20729470ba0fd4ba9.zip FreeBSD-src-5022630d02f5b911fe694cc20729470ba0fd4ba9.tar.gz |
- Fix an off by one error when checking for the stop event. This resulted
in not showing the most recent event by default.
- When the stop even is hit, break out of the outer loop to stop fetching
more events.
MFC after: 1 week
Diffstat (limited to 'usr.sbin/mfiutil')
-rw-r--r-- | usr.sbin/mfiutil/mfi_evt.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/usr.sbin/mfiutil/mfi_evt.c b/usr.sbin/mfiutil/mfi_evt.c index c9a1a6d..901c0bd 100644 --- a/usr.sbin/mfiutil/mfi_evt.c +++ b/usr.sbin/mfiutil/mfi_evt.c @@ -33,6 +33,7 @@ #include <sys/errno.h> #include <err.h> #include <fcntl.h> +#include <stdbool.h> #include <stdio.h> #include <stdlib.h> #include <strings.h> @@ -534,6 +535,7 @@ show_events(int ac, char **av) struct mfi_evt_log_state info; struct mfi_evt_list *list; union mfi_evt filter; + bool first; long val; char *cp; ssize_t size; @@ -640,7 +642,9 @@ show_events(int ac, char **av) close(fd); return (ENOMEM); } - for (seq = start;;) { + first = true; + seq = start; + for (;;) { if (mfi_get_events(fd, list, num_events, filter, seq, &status) < 0) { error = errno; @@ -650,8 +654,6 @@ show_events(int ac, char **av) return (error); } if (status == MFI_STAT_NOT_FOUND) { - if (seq == start) - warnx("No matching events found"); break; } if (status != MFI_STAT_OK) { @@ -669,13 +671,14 @@ show_events(int ac, char **av) * the case that our stop point is earlier in * the buffer than our start point. */ - if (list->event[i].seq >= stop) { + if (list->event[i].seq > stop) { if (start <= stop) - break; + goto finish; else if (list->event[i].seq < start) - break; + goto finish; } mfi_decode_evt(fd, &list->event[i], verbose); + first = false; } /* @@ -686,6 +689,9 @@ show_events(int ac, char **av) seq = list->event[list->count - 1].seq + 1; } +finish: + if (first) + warnx("No matching events found"); free(list); close(fd); |