diff options
| author | eadler <eadler@FreeBSD.org> | 2012-10-22 03:07:05 +0000 |
|---|---|---|
| committer | eadler <eadler@FreeBSD.org> | 2012-10-22 03:07:05 +0000 |
| commit | a603c87b0251c5b6077c28864b1aeb21c40f4086 (patch) | |
| tree | 90ec7fe4bf0dae506d699603babb4917082f098a /usr.sbin/edquota | |
| parent | b55c76b1b0ad13886a22eb6abb2363bb324bc7cb (diff) | |
| download | FreeBSD-src-a603c87b0251c5b6077c28864b1aeb21c40f4086.zip FreeBSD-src-a603c87b0251c5b6077c28864b1aeb21c40f4086.tar.gz | |
Check the return error of set[e][ug]id. While this can never fail in the
current version of FreeBSD, this isn't guarenteed by the API.
Custom security modules, or future implementations of the setuid and
setgid may fail.
Submitted by: Erik Cederstrand
Approved by: cperciva
MFC after: 3 days
Diffstat (limited to 'usr.sbin/edquota')
| -rw-r--r-- | usr.sbin/edquota/edquota.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/usr.sbin/edquota/edquota.c b/usr.sbin/edquota/edquota.c index 0957011..930a460 100644 --- a/usr.sbin/edquota/edquota.c +++ b/usr.sbin/edquota/edquota.c @@ -453,8 +453,10 @@ editit(char *tmpf) const char *ed; sigsetmask(omask); - setgid(getgid()); - setuid(getuid()); + if (setgid(getgid()) != 0) + err(1, "setgid failed"); + if (setuid(getuid()) != 0) + err(1, "setuid failed"); if ((ed = getenv("EDITOR")) == (char *)0) ed = _PATH_VI; execlp(ed, ed, tmpf, (char *)0); |
