Fix for the following behavior:

$ crontab -e
[Add an entry with an error in the crontab file.]
crontab: errors in crontab file, can't install
Do you want to retry the same edit? yes
[Exit the editor without any changes.]
crontab: no changes made to crontab
[Entry is lost.]

Now crontab will loop until the error is fixed, or the
user answers no.

1 files changed, 6 insertions, 4 deletions

diff --git a/usr.sbin/cron/crontab/crontab.c b/usr.sbin/cron/crontab/crontab.c
index a347a9f..9cda6f6 100644
--- a/usr.sbin/cron/crontab/crontab.c
+++ b/usr.sbin/cron/crontab/crontab.c
@@ -309,6 +309,7 @@ edit_cmd() {
 	WAIT_T		waiter;
 	PID_T		pid, xpid;
 	mode_t		um;
+	int		syntax_error = 0;
 
 	log_it(RealUser, Pid, "BEGIN EDIT", User);
 	(void) sprintf(n, CRON_TAB(User));
@@ -446,15 +447,15 @@ edit_cmd() {
 	}
 	if (statbuf.st_dev != fsbuf.st_dev || statbuf.st_ino != fsbuf.st_ino)
 		errx(ERROR_EXIT, "temp file must be edited in place");
-	if (mtime == statbuf.st_mtime) {
+	if (mtime == statbuf.st_mtime && !syntax_error) {
 		warnx("no changes made to crontab");
 		goto remove;
 	}
 	warnx("installing new crontab");
 	switch (replace_cmd()) {
-	case 0:
+	case 0:			/* Success */
 		break;
-	case -1:
+	case -1:		/* Syntax error */
 		for (;;) {
 			printf("Do you want to retry the same edit? ");
 			fflush(stdout);
@@ -462,6 +463,7 @@ edit_cmd() {
 			(void) fgets(q, sizeof q, stdin);
 			switch (islower(q[0]) ? q[0] : tolower(q[0])) {
 			case 'y':
+				syntax_error = 1;
 				goto again;
 			case 'n':
 				goto abandon;
@@ -470,7 +472,7 @@ edit_cmd() {
 			}
 		}
 		/*NOTREACHED*/
-	case -2:
+	case -2:		/* Install error */
 	abandon:
 		warnx("edits left in %s", Filename);
 		goto done;