diff options
author | pfg <pfg@FreeBSD.org> | 2015-07-31 01:12:31 +0000 |
---|---|---|
committer | pfg <pfg@FreeBSD.org> | 2015-07-31 01:12:31 +0000 |
commit | 8597d814df1fcc6d7e612a9da2dfc99025f98867 (patch) | |
tree | 684fe37e59dec9562bcc64a9ee05d502613b3c2c /usr.bin | |
parent | 685318f335be91988efd5573d69047da1a3398ac (diff) | |
download | FreeBSD-src-8597d814df1fcc6d7e612a9da2dfc99025f98867.zip FreeBSD-src-8597d814df1fcc6d7e612a9da2dfc99025f98867.tar.gz |
Buffer overflow in wall(1).
This affected syslogd, wall and talkd.
Detected by FORTIFY_SOURCE GSoC (with clang).
Submitted by: Oliver Pinter
Differential Revision: https://reviews.freebsd.org/D3254
Reviewed by: delphij, jmg
MFC after: 3 days
Diffstat (limited to 'usr.bin')
-rw-r--r-- | usr.bin/wall/ttymsg.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr.bin/wall/ttymsg.c b/usr.bin/wall/ttymsg.c index 37b09e9..1317a4b 100644 --- a/usr.bin/wall/ttymsg.c +++ b/usr.bin/wall/ttymsg.c @@ -62,7 +62,7 @@ ttymsg(struct iovec *iov, int iovcnt, const char *line, int tmout) struct iovec localiov[7]; ssize_t left, wret; int cnt, fd; - static char device[MAXNAMLEN] = _PATH_DEV; + char device[MAXNAMLEN] = _PATH_DEV; static char errbuf[1024]; char *p; int forked; @@ -71,8 +71,8 @@ ttymsg(struct iovec *iov, int iovcnt, const char *line, int tmout) if (iovcnt > (int)(sizeof(localiov) / sizeof(localiov[0]))) return ("too many iov's (change code in wall/ttymsg.c)"); + strlcat(device, line, sizeof(device)); p = device + sizeof(_PATH_DEV) - 1; - strlcpy(p, line, sizeof(device)); if (strncmp(p, "pts/", 4) == 0) p += 4; if (strchr(p, '/') != NULL) { |