diff options
author | uqs <uqs@FreeBSD.org> | 2015-12-29 11:24:41 +0000 |
---|---|---|
committer | uqs <uqs@FreeBSD.org> | 2015-12-29 11:24:41 +0000 |
commit | 11e0dd6c90098a31b4ee84a2af39114001952d67 (patch) | |
tree | b886de70650826ff015bc0343d808ffba0f524fd /usr.bin | |
parent | d4f2c120c09150a7012ceea91a74ea068aa5a9c6 (diff) | |
download | FreeBSD-src-11e0dd6c90098a31b4ee84a2af39114001952d67.zip FreeBSD-src-11e0dd6c90098a31b4ee84a2af39114001952d67.tar.gz |
Fix type mismatches for malloc(3) and Co.
This is rather pedantic, as for most architectures it holds that
sizeof(type *) == sizeof(type **)
Found by: clang static analyzer
Reviewed by: ed
Differential Revision: https://reviews.freebsd.org/D4722
Diffstat (limited to 'usr.bin')
-rw-r--r-- | usr.bin/column/column.c | 2 | ||||
-rw-r--r-- | usr.bin/locate/locate/util.c | 4 | ||||
-rw-r--r-- | usr.bin/xargs/xargs.c | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/usr.bin/column/column.c b/usr.bin/column/column.c index b092deb..eb8ca66 100644 --- a/usr.bin/column/column.c +++ b/usr.bin/column/column.c @@ -244,7 +244,7 @@ maketbl(void) p = NULL) if (++coloff == maxcols) { if (!(cols = realloc(cols, ((u_int)maxcols + - DEFCOLS) * sizeof(char *))) || + DEFCOLS) * sizeof(wchar_t *))) || !(lens = realloc(lens, ((u_int)maxcols + DEFCOLS) * sizeof(int)))) err(1, NULL); diff --git a/usr.bin/locate/locate/util.c b/usr.bin/locate/locate/util.c index 3ac69b5..9130e37 100644 --- a/usr.bin/locate/locate/util.c +++ b/usr.bin/locate/locate/util.c @@ -93,7 +93,7 @@ colon(dbv, path, dot) char **pv; if (dbv == NULL) { - if ((dbv = malloc(sizeof(char **))) == NULL) + if ((dbv = malloc(sizeof(char *))) == NULL) err(1, "malloc"); *dbv = NULL; } @@ -123,7 +123,7 @@ colon(dbv, path, dot) *(p + slen) = '\0'; } /* increase dbv with element p */ - if ((dbv = realloc(dbv, sizeof(char **) * (vlen + 2))) + if ((dbv = realloc(dbv, sizeof(char *) * (vlen + 2))) == NULL) err(1, "realloc"); *(dbv + vlen) = p; diff --git a/usr.bin/xargs/xargs.c b/usr.bin/xargs/xargs.c index c56ab60..955711c 100644 --- a/usr.bin/xargs/xargs.c +++ b/usr.bin/xargs/xargs.c @@ -234,7 +234,7 @@ main(int argc, char *argv[]) * NULL. */ linelen = 1 + argc + nargs + 1; - if ((av = bxp = malloc(linelen * sizeof(char **))) == NULL) + if ((av = bxp = malloc(linelen * sizeof(char *))) == NULL) errx(1, "malloc failed"); /* @@ -471,7 +471,7 @@ prerun(int argc, char *argv[]) * Allocate memory to hold the argument list, and * a NULL at the tail. */ - tmp = malloc((argc + 1) * sizeof(char**)); + tmp = malloc((argc + 1) * sizeof(char *)); if (tmp == NULL) { warnx("malloc failed"); xexit(*argv, 1); |