diff options
| author | dim <dim@FreeBSD.org> | 2012-08-05 15:55:36 +0000 |
|---|---|---|
| committer | dim <dim@FreeBSD.org> | 2012-08-05 15:55:36 +0000 |
| commit | 7c93ab23a4ba04ce7f001aa304895edb49b287fd (patch) | |
| tree | e0c9be26c547323831ff1617a49ac4a49d471400 /usr.bin | |
| parent | 23e8ad15ba0d4a5039ab4848efc224275b2ad810 (diff) | |
| download | FreeBSD-src-7c93ab23a4ba04ce7f001aa304895edb49b287fd.zip FreeBSD-src-7c93ab23a4ba04ce7f001aa304895edb49b287fd.tar.gz | |
In usr.bin/make/var.c, function ParseModifier(), initialize the 'error'
variable to NULL, to avoid using it uninitialized in certain cases.
This fixes the following clang 3.2 warning:
usr.bin/make/var.c:1770:10: error: variable 'error' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (vp->execute) {
^~~~~~~~~~~
usr.bin/make/var.c:1777:10: note: uninitialized use occurs here
if (error)
^~~~~
usr.bin/make/var.c:1770:6: note: remove the 'if' if its condition is always true
if (vp->execute) {
^~~~~~~~~~~~~~~~~
usr.bin/make/var.c:1768:23: note: initialize the variable 'error' to silence this warning
const char *error;
^
= NULL
MFC after: 1 week
Diffstat (limited to 'usr.bin')
| -rw-r--r-- | usr.bin/make/var.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/usr.bin/make/var.c b/usr.bin/make/var.c index 477c4a9..7cde060 100644 --- a/usr.bin/make/var.c +++ b/usr.bin/make/var.c @@ -1765,7 +1765,7 @@ ParseModifier(VarParser *vp, char startc, Var *v, Boolean *freeResult) if ((vp->ptr[0] == 's') && (vp->ptr[1] == 'h') && (vp->ptr[2] == endc || vp->ptr[2] == ':')) { - const char *error; + const char *error = NULL; if (vp->execute) { newStr = Buf_Peel( |
