diff options
| author | rwatson <rwatson@FreeBSD.org> | 2001-09-15 17:09:39 +0000 |
|---|---|---|
| committer | rwatson <rwatson@FreeBSD.org> | 2001-09-15 17:09:39 +0000 |
| commit | fabafaba5edb2134c95c2846c27aafeeb85e1c86 (patch) | |
| tree | b4698650e914f8a85c2073abd026d2319f2b243f /usr.bin | |
| parent | c9e6468209086f9593798c95d10513b47935bacf (diff) | |
| download | FreeBSD-src-fabafaba5edb2134c95c2846c27aafeeb85e1c86.zip FreeBSD-src-fabafaba5edb2134c95c2846c27aafeeb85e1c86.tar.gz | |
o Modify NFS rights comment to note that the early credential changes
to test for a home directory don't set up the additional groups, and
as such may limit users conservatively. This does not affect the
eventual credentials selected.
Diffstat (limited to 'usr.bin')
| -rw-r--r-- | usr.bin/login/login.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/usr.bin/login/login.c b/usr.bin/login/login.c index 35a5294..93c745f 100644 --- a/usr.bin/login/login.c +++ b/usr.bin/login/login.c @@ -394,7 +394,13 @@ main(argc, argv) lc = login_getpwclass(pwd); quietlog = login_getcapbool(lc, "hushlogin", 0); - /* Switching needed for NFS with root access disabled */ + /* + * Switching needed for NFS with root access disabled. + * + * XXX: This change fails to modify the additional groups for the + * process, and as such, may restrict rights normally granted + * through those groups. + */ (void)setegid(pwd->pw_gid); (void)seteuid(rootlogin ? 0 : pwd->pw_uid); if (!*pwd->pw_dir || chdir(pwd->pw_dir) < 0) { |
