Fix display of idle processes, which had been broken since rev. 1.56 of

machine.c. The traditional condition was (pctcpu > 0 || SRUN), but the
negation of the condition logic (from select to skip) made this come
out as (pctcpu > 0 && SRUN), leading to a very erratic display, except
for purely CPU bound processes.

This has been discussed in the mail lists some time ago and I have used
top with this patch on my systems for more than a year without problems
(just forgot to commit it earlier, since my systems were all fixed ...).

1 files changed, 2 insertions, 1 deletions

diff --git a/usr.bin/top/machine.c b/usr.bin/top/machine.c
index fb1823e..92c82fa 100644
--- a/usr.bin/top/machine.c
+++ b/usr.bin/top/machine.c
@@ -603,7 +603,8 @@ get_process_info(struct system_info *si, struct process_select *sel,
 			continue;
 
 		if (displaymode == DISP_CPU && !show_idle &&
-		    (pp->ki_pctcpu == 0 || pp->ki_stat != SRUN))
+		    (pp->ki_pctcpu == 0 ||
+		     pp->ki_stat == SSTOP || pp->ki_stat == SIDL))
 			/* skip idle or non-running processes */
 			continue;