diff options
author | pluknet <pluknet@FreeBSD.org> | 2011-06-30 09:20:26 +0000 |
---|---|---|
committer | pluknet <pluknet@FreeBSD.org> | 2011-06-30 09:20:26 +0000 |
commit | ced9bcf26f7e7107339e61b56b9ba7ceba6049ac (patch) | |
tree | 575265b5d6e4cdf5e24b18371edd3a23bd818157 /usr.bin/quota | |
parent | 4fe845568de43a3a5da76d77483beffedbafa858 (diff) | |
download | FreeBSD-src-ced9bcf26f7e7107339e61b56b9ba7ceba6049ac.zip FreeBSD-src-ced9bcf26f7e7107339e61b56b9ba7ceba6049ac.tar.gz |
Fix quota(1) output.
- Fix calculation of 1024-byte sized blocks from disk blocks shown when -h
option isn't specified. It was broken with quota64 integration.
- In prthumanval(): limit the size of a buffer passed to humanize_number()
to a width of 5 bytes but allow a shorter length if requested. That's what
users expect.
PR: bin/150151
Reviewed by: Kirk McKusick
Diffstat (limited to 'usr.bin/quota')
-rw-r--r-- | usr.bin/quota/quota.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/usr.bin/quota/quota.c b/usr.bin/quota/quota.c index 6cc3517..67d9c5a 100644 --- a/usr.bin/quota/quota.c +++ b/usr.bin/quota/quota.c @@ -264,8 +264,11 @@ prthumanval(int len, u_int64_t bytes) { char buf[len + 1]; - humanize_number(buf, sizeof(buf), bytes, "", HN_AUTOSCALE, - HN_B | HN_NOSPACE | HN_DECIMAL); + /* + * Limit the width to 5 bytes as that is what users expect. + */ + humanize_number(buf, sizeof(buf) < 5 ? sizeof(buf) : 5, bytes, "", + HN_AUTOSCALE, HN_B | HN_NOSPACE | HN_DECIMAL); (void)printf(" %*s", len, buf); } @@ -352,10 +355,13 @@ showquotas(int type, u_long id, const char *name) prthumanval(7, dbtob(qup->dqblk.dqb_bhardlimit)); } else { printf(" %7ju%c %7ju %7ju", - dbtob(1024) * (uintmax_t)qup->dqblk.dqb_curblocks, + (uintmax_t)dbtob(qup->dqblk.dqb_curblocks) + / 1024, (msgb == NULL) ? ' ' : '*', - dbtob(1024) * (uintmax_t)qup->dqblk.dqb_bsoftlimit, - dbtob(1024) * (uintmax_t)qup->dqblk.dqb_bhardlimit); + (uintmax_t)dbtob(qup->dqblk.dqb_bsoftlimit) + / 1024, + (uintmax_t)dbtob(qup->dqblk.dqb_bhardlimit) + / 1024); } if (msgb != NULL) bgrace = timeprt(qup->dqblk.dqb_btime); |