wordexp(): Improve some error codes.

Distinguish between WRDE_BADVAL and WRDE_SYNTAX based on when the error
occurred (parsing or execution), not based on whether WRDE_UNDEF was passed.

Also, return WRDE_NOSPACE for a few more unexpected results from sh.

1 files changed, 9 insertions, 0 deletions

diff --git a/tools/regression/lib/libc/gen/test-wordexp.c b/tools/regression/lib/libc/gen/test-wordexp.c
index 069190f..68b1578 100644
--- a/tools/regression/lib/libc/gen/test-wordexp.c
+++ b/tools/regression/lib/libc/gen/test-wordexp.c
@@ -206,6 +206,15 @@ main(int argc, char *argv[])
 	assert(strcmp(we.we_wordv[0], "\\") == 0);
 	assert(we.we_wordv[1] == NULL);
 	wordfree(&we);
+	/* Two syntax errors that are not detected by the current we_check(). */
+	r = wordexp("${IFS:+'}", &we, 0);
+	assert(r == WRDE_SYNTAX);
+	r = wordexp("${IFS:+'}", &we, WRDE_UNDEF);
+	assert(r == WRDE_SYNTAX);
+	r = wordexp("$(case)", &we, 0);
+	assert(r == WRDE_SYNTAX);
+	r = wordexp("$(case)", &we, WRDE_UNDEF);
+	assert(r == WRDE_SYNTAX);
 
 	/* With a SIGCHLD handler that reaps all zombies. */
 	sa.sa_flags = 0;