diff options
author | emaste <emaste@FreeBSD.org> | 2017-05-15 13:05:02 +0000 |
---|---|---|
committer | emaste <emaste@FreeBSD.org> | 2017-05-15 13:05:02 +0000 |
commit | 18124cfbb4489771fb4c72a2c0ae5e6c4c0dcde5 (patch) | |
tree | bf7e12131fbe3957d3bd2a466f0f32d4faf5dc0d /tools/build | |
parent | 79418433f6d86af1b6b965812d6f81b8efb5e81f (diff) | |
download | FreeBSD-src-18124cfbb4489771fb4c72a2c0ae5e6c4c0dcde5.zip FreeBSD-src-18124cfbb4489771fb4c72a2c0ae5e6c4c0dcde5.tar.gz |
MFC r316706: makeman: don't copy $FreeBSD$ tags from source files into output
Copying the source VCS ID from WITH_/WITHOUT_* into the generated
src.conf.5 is not necessary, as it is generally possible to determine
the same information using the VCS to examine commit metadata. The
individual source files also match the name of the option recorded in
the generated file, so it is clear from where the content originated.
The copied IDs generate extraneous, non-content noise in the generated
src.conf.5 in some cases, including the first time the file is generated
on a stable branch. In addition, the source file $FreeBSD$ tags are not
expanded by git or other non-Subversion VCSs, which means that makeman
previously could not be used in a non-Subversion working tree.
I accept that there's some desire to keep these, but on balance believe
there is more benefit in removing them.
Sponsored by: The FreeBSD Foundation
Diffstat (limited to 'tools/build')
-rwxr-xr-x | tools/build/options/makeman | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/tools/build/options/makeman b/tools/build/options/makeman index 52f72ee..198d8bd 100755 --- a/tools/build/options/makeman +++ b/tools/build/options/makeman @@ -1,12 +1,12 @@ #!/bin/sh # # This file is in the public domain. +# +# $FreeBSD$ set -o errexit export LC_ALL=C -ident='$FreeBSD$' - t=$(mktemp -d -t makeman) trap 'test -d $t && rm -rf $t' exit @@ -119,12 +119,9 @@ show() main() { - ident=${ident#$} - ident=${ident% $} fbsdid='$'FreeBSD'$' cat <<EOF .\" DO NOT EDIT-- this file is automatically generated. -.\" from ${ident} .\" ${fbsdid} .Dd $(echo $(LC_TIME=C date +'%B %e, %Y')) .Dt SRC.CONF 5 @@ -237,7 +234,7 @@ EOF fi echo ".It Va ${opt}" - sed -e's/\$\(FreeBSD: .*\) \$/from \1/' ${opt} + sed -e'/\$FreeBSD.*\$/d' ${opt} if [ -n "${targets}" ] ; then echo '.Pp' echo 'It is a default setting on' |