Fix a logic error in osethostid() that was introduced in rev. 1.34:

allow hostid to be set when suser() returns 0, not when it returns
an error. This would have allowed non-root users to set the host ID.

1 files changed, 4 insertions, 3 deletions

diff --git a/sys/kern/kern_xxx.c b/sys/kern/kern_xxx.c
index f3d8154..47988da 100644
--- a/sys/kern/kern_xxx.c
+++ b/sys/kern/kern_xxx.c
@@ -144,11 +144,12 @@ osethostid(td, uap)
 {
 	int error;
 
-	mtx_lock(&Giant);
 	if ((error = suser(td)))
-		hostid = uap->hostid;
+		return (error);
+	mtx_lock(&Giant);
+	hostid = uap->hostid;
 	mtx_unlock(&Giant);
-	return (error);
+	return (0);
 }
 
 /*