summaryrefslogtreecommitdiffstats
path: root/sys
diff options
context:
space:
mode:
authorcperciva <cperciva@FreeBSD.org>2004-02-22 01:10:11 +0000
committercperciva <cperciva@FreeBSD.org>2004-02-22 01:10:11 +0000
commitf8fa6977f57df76fb0b2a68f902f288323e38041 (patch)
treeafae31bc79130693d371bd6daccabce156a524a5 /sys
parentd3deac34eade92a59c9f9262249091a21405ff12 (diff)
downloadFreeBSD-src-f8fa6977f57df76fb0b2a68f902f288323e38041.zip
FreeBSD-src-f8fa6977f57df76fb0b2a68f902f288323e38041.tar.gz
Check that xfer != NULL before dereferencing it, not after.
Reported by: "Ted Unangst" <tedu@coverity.com> Approved by: rwatson (mentor)
Diffstat (limited to 'sys')
-rw-r--r--sys/dev/firewire/firewire.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/firewire/firewire.c b/sys/dev/firewire/firewire.c
index 6af01a0..db9d5a8 100644
--- a/sys/dev/firewire/firewire.c
+++ b/sys/dev/firewire/firewire.c
@@ -973,10 +973,10 @@ fw_xfer_alloc_buf(struct malloc_type *type, int send_len, int recv_len)
struct fw_xfer *xfer;
xfer = fw_xfer_alloc(type);
- xfer->send.pay_len = send_len;
- xfer->recv.pay_len = recv_len;
if (xfer == NULL)
return(NULL);
+ xfer->send.pay_len = send_len;
+ xfer->recv.pay_len = recv_len;
if (send_len > 0) {
xfer->send.payload = malloc(send_len, type, M_NOWAIT | M_ZERO);
if (xfer->send.payload == NULL) {
OpenPOWER on IntegriCloud