diff options
| author | mjacob <mjacob@FreeBSD.org> | 1999-12-20 16:16:53 +0000 |
|---|---|---|
| committer | mjacob <mjacob@FreeBSD.org> | 1999-12-20 16:16:53 +0000 |
| commit | e880d379fa195b770284ec71a1a2c3dfd9b1d40a (patch) | |
| tree | d6c02698bbeb80d2889788ca706d0d0775a81efd /sys | |
| parent | 61c79b122e44f58607ac5f393bcf9b4a7a821178 (diff) | |
| download | FreeBSD-src-e880d379fa195b770284ec71a1a2c3dfd9b1d40a.zip FreeBSD-src-e880d379fa195b770284ec71a1a2c3dfd9b1d40a.tar.gz | |
Make sure we don't look at an edt entry that could go away when we try
and figure out whether to probe higher than logical unit 7.
Obtained from:gibbs@freebsd.org
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/cam/cam_xpt.c | 22 |
1 files changed, 15 insertions, 7 deletions
diff --git a/sys/cam/cam_xpt.c b/sys/cam/cam_xpt.c index 83e2a5b..0fb8d65 100644 --- a/sys/cam/cam_xpt.c +++ b/sys/cam/cam_xpt.c @@ -4896,7 +4896,7 @@ xpt_scan_bus(struct cam_periph *periph, union ccb *request_ccb) if (request_ccb->ccb_h.status != CAM_REQ_CMP) { struct cam_ed *device; struct cam_et *target; - int s; + int s, phl; /* * If we already probed lun 0 successfully, or @@ -4905,16 +4905,24 @@ xpt_scan_bus(struct cam_periph *periph, union ccb *request_ccb) * the next lun. */ target = request_ccb->ccb_h.path->target; + /* + * We may touch devices that we don't + * hold references too, so ensure they + * don't disappear out from under us. + * The target above is referenced by the + * path in the request ccb. + */ + phl = 0; s = splcam(); device = TAILQ_FIRST(&target->ed_entries); - if (device != NULL) - device = TAILQ_NEXT(device, links); + if (device != NULL) { + phl = device->quirk->quirks & CAM_QUIRK_HILUNS; + if (device->lun_id == 0) + device = TAILQ_NEXT(device, links); + } splx(s); - if ((lun_id != 0) || (device != NULL)) { - /* Try the next lun */ - if (lun_id < (CAM_SCSI2_MAXLUN-1) || - (device->quirk->quirks & CAM_QUIRK_HILUNS)) + if (lun_id < (CAM_SCSI2_MAXLUN-1) || phl) lun_id++; } } else { |
